Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing misc errors and errors found from users on discord and adding support for spoolman multicolors #203

Merged
merged 13 commits into from
Dec 20, 2024
Merged

Fixing misc errors and errors found from users on discord and adding support for spoolman multicolors #203

merged 13 commits into from
Dec 20, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 20, 2024 •
edited
Loading

Major Changes in this PR

  • Found problem where AFC.py was using self.AFC.stepper, changed to self.stepper
  • Fixed error where AFC_error was not referenced correctly
  • Added more printing errors to help others out .
  • Added homing checks to TOOL_LOAD and TOOL_UNLOAD
  • In prep using common function for setting spoolman data
  • Updated a while loop that should of been indented under a if statement when hub cutting
  • Updated changelog dates
  • Fixed cut macro to only rip on the last cut like originally intended based of comments in macro, before it was always ripping for every cut

Notes to Code Reviewers

How the changes in this PR are tested

  • Tested tool loading and unloading sequences
  • Manually called macros with wrong names to verify they would error out correctly

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711
Fixing places where AFC_error was not referenced correctly
7e9b042
@jimmyjon711
Fixing misc errors
7f616f5 
- Fixing self.AFC in AFC.py file, updated to self
- Adding more checking to make sure printer was homed if user was to call TOOL_LOAD and TOOL_UNLOAD macros
- Adding more error print outs to help the user
@jimmyjon711
Using common set_spoolid function when setting spoolid during prep
5641d9b 
- Added check to see if spoolman color is multicolor
@jimmyjon711
Updating reporting of lane to be uppercase so it consistent with othe…
5cf952b 
…r reporting
@jimmyjon711
Indenting while loop that should be under hub cut if statement
66e6609
@jimmyjon711
Fixing changelog, combining dates and making sure dates are in the ri…
9ffdb70 
…ght order
@jimmyjon711
Changing lane.name to lane since lane is the name
6e09b7d
@jimmyjon711
Fixing cut macro so it only rips on the last cut like originally inte…
a6dc0d4 
…nded
@jimmyjon711
Removing lane name from message when calling handle_lane_failure erro…
95d4be5 
…r function
@jimmyjon711
Updating changelog
ad07848
@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 20, 2024 23:06
@MG-longshot MG-longshot merged commit 50f330d into ArmoredTurtle:DEV Dec 20, 2024
1 check passed
@jimmyjon711 jimmyjon711 deleted the error_fixes branch December 20, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MG-longshot MG-longshot MG-longshot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjon711 @MG-longshot