Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability improvements for README.md #197

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

ejsears
Copy link
Contributor

@ejsears ejsears commented Dec 18, 2024

Major Changes in this PR

  • Add some requested information to the README

Notes to Code Reviewers

How the changes in this PR are tested

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

README.md Outdated
@@ -207,25 +226,33 @@ Debug information about the respooler system can be found by visiting the follow

`{ip address}/printer/objects/query?AFC`

### LEDs not displaying correct color
<details>
<summary>LEDs not displaying correct color</summary>
Copy link
Contributor

@jimmyjon711 jimmyjon711 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary sections look weird and don't apply the code sections and new lines when looking at the rich text
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah. They showed up fine for me. I'll revert them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmyjon711 Adjusted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me approved

@MG-longshot MG-longshot merged commit bbb6020 into ArmoredTurtle:main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants