Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confirmation prompt #186

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix confirmation prompt #186

merged 1 commit into from
Dec 13, 2024

Conversation

ejsears
Copy link
Contributor

@ejsears ejsears commented Dec 13, 2024

Major Changes in this PR

Standardize confirm_continue to look like the other prompts and add default Y.

Notes to Code Reviewers

How the changes in this PR are tested

  • Local testing.

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@ejsears ejsears changed the base branch from main to DEV December 13, 2024 21:15
MG-longshot
MG-longshot approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@MG-longshot MG-longshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see no issues

@MG-longshot MG-longshot merged commit 0324cb9 into ArmoredTurtle:DEV Dec 13, 2024
1 check passed
@ejsears ejsears deleted the fix-confirmation-prompt branch December 13, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MG-longshot MG-longshot MG-longshot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejsears @MG-longshot