Mg longshot #174
Merged
Mg longshot #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjon711
reviewed
Dec 6, 2024
| @@ -238,10 +238,15 @@ def prep_callback(self, eventtime, state): | |||
| if self.load_state == True and self.prep_state == True: | |||
| self.status = 'Loaded' | |||
| self.AFC.afc_led(self.AFC.led_ready, led) | |||
| else: | |||
There was a problem hiding this comment.
This else statement need to stay, if a lane is ejected the led stays green
jimmyjon711
reviewed
Dec 6, 2024
extras/AFC_stepper.py
Outdated
| @@ -238,10 +238,18 @@ def prep_callback(self, eventtime, state): | |||
| if self.load_state == True and self.prep_state == True: | |||
| self.status = 'Loaded' | |||
| self.AFC.afc_led(self.AFC.led_ready, led) | |||
| elif self.name == self.AFC.current and self.AFC.STATUS == 'Printing' and self.AFC.lanes[self.unit][self.name]['runout_lane'] != 'NONE': | |||
There was a problem hiding this comment.
Suggested change
| elif self.name == self.AFC.current and self.AFC.STATUS == 'Printing' and self.AFC.lanes[self.unit][self.name]['runout_lane'] != 'NONE': | |
| elif self.name == self.AFC.current and self.IDLE.state == 'Printing' and self.AFC.lanes[self.unit][self.name]['runout_lane'] != 'NONE': |
jimmyjon711
reviewed
Dec 6, 2024
| self.gcode = self.printer.lookup_object('gcode') | ||
| self.STATUS= self.IDLE.state |
There was a problem hiding this comment.
Since this will always return the same state and not update, this line can be removed
jimmyjon711
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes in this PR
Notes to Code Reviewers
How the changes in this PR are tested
PR Checklist: (Checked-off items are either done or do not apply to this PR)