split of unit types #144
Merged
split of unit types #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started the split of unit types to individual modules
jimmyjon711
approved these changes
Nov 28, 2024
jimmyjon711
reviewed
Nov 28, 2024
extras/AFC_prep.py
Outdated
|
|
||
| try: unit_type = self.printer.lookup_object('AFC_{}'.format(CUR_HUB.type.replace('_', ''))) | ||
| except: | ||
| self.ERROR.AFC_error("{} not supported".format(CUR_HUB.type, False)) |
There was a problem hiding this comment.
Oops typed this wrong in my example
Suggested change
| self.ERROR.AFC_error("{} not supported".format(CUR_HUB.type, False)) | |
| self.ERROR.AFC_error("{} not supported".format(CUR_HUB.type), False) |
MG-longshot
commented
Nov 28, 2024
| @@ -813,7 +813,8 @@ def get_status(self, eventtime): | |||
| str["system"]["extruders"][EXTRUDE]['tool_end_sensor'] = True == CUR_EXTRUDER.tool_end_state if CUR_EXTRUDER.tool_end is not None else False | |||
| if CUR_EXTRUDER.buffer_name != None: | |||
| str["system"]["extruders"][EXTRUDE]['buffer'] = CUR_EXTRUDER.buffer_name | |||
| str["system"]["extruders"][EXTRUDE]['buffer_status'] = CUR_EXTRUDER.buffer.buffer_status() | |||
| CUR_BUFFER = self.printer.lookup_object('AFC_buffer ' + CUR_EXTRUDER.buffer_name) | |||
There was a problem hiding this comment.
thought so but the buffer status function had been moved to AFC_buffer status on the dev
fixed typo
jimmyjon711
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started the split of unit types to individual modules