feat(prompts): Render model invocation params in prompt details view #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cephalization
commented
Dec 18, 2024
cephalization
commented
Dec 18, 2024
Comment on lines
+89
to
+90
| width={PROMPT_VERSIONS_LIST_WIDTH} | ||
| minWidth={PROMPT_VERSIONS_LIST_WIDTH} |
There was a problem hiding this comment.
This should likely be set to width=100% and have the parent constrain the width with a px value. That way we can render this list in both the prompt aside and the versions tab and let the parent decide how much space it takes up.
dosubot
bot
added
size:XL
cephalization
changed the title
mikeldking
deleted the
cephalization/prompts/5777-show-invocation-params-prompt-details
branch
mikeldking
added a commit
that referenced
this pull request
Dec 26, 2024
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <[email protected]>
mikeldking
added a commit
that referenced
this pull request
Dec 26, 2024
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <[email protected]>
mikeldking
added a commit
that referenced
this pull request
Dec 27, 2024
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <[email protected]>
mikeldking
added a commit
that referenced
this pull request
Dec 28, 2024
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <[email protected]>
mikeldking
added a commit
that referenced
this pull request
Dec 31, 2024
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompt.invocation.params.mov
Resolves #5777