-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename vehicle-specific RC_Channel and GCS_MAVLink files #28934
Rename vehicle-specific RC_Channel and GCS_MAVLink files #28934
Conversation
I like this. It would be nice to interleave the commits to avoid so much of a bisect pit (i.e. do each vehicle's commit in sequence rather than two blocks for all vehicles). I assume the copter case would also require the same order of magnitude of changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renaming of files will make backports tricky but besides that the changes themselves are pretty small, thanks!
0c97598
to
2290611
Compare
Good point, I've interleaved the commits now.
Not sure what you mean here. The "1500" was a |
You mentioned only Plane in the context of that 1500 number. It looks like the problem affects both Plane and Copter so that number is for both? Not quibbling about the count, just want to accurately know what vehicles would be affected. |
The entire codebase. Primarily 14 files containing the 7 classes, but there are going to be statics floating around, probably. |
2290611
to
c42258b
Compare
We are somewhat inconsistent with our file naming for these derived classes.
So, for example, we have GCS_Plane and GCS_Copter which contain the classes
GCS_Plane
andGCS_Copter
, but we useGCS_Mavlink.h
for both Plane and Copter to holdGCS_MAVLINK_Plane
andGCS_MAVLINK_Copter
.This PR renames the RC_Channel and GCS_MAVLink files for the vehicles to be closer to the class names they contain. The class name defines in GCS_MAVLink_Plane.cpp, however, is still
GCS_MAVLINK_Plane
rather thanGCS_MAVLink_Plane
. There are 1500 lines to change to correct the case, and that's going to make backports difficult. Probably something to do closer to the middle of a release cycle.