AP_Scripting: fix outstanding luacheck issues #28931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Dec 23, 2024
rmackay9
reviewed
Dec 23, 2024
|
I'm happy with the changes affecting scripts I'm responsible for |
rmackay9
approved these changes
Dec 23, 2024
tpwrules
reviewed
Dec 23, 2024
libraries/AP_Scripting/applets/Aerobatics/FixedWing/RateBased/sport_aerobatics.lua
Outdated
Show resolved
Hide resolved
Comment on lines
-42
to
-47
| -- clear vars we don't need anymore | ||
| slew_down_time = nil | ||
| slew_up_time = nil | ||
| pwm_range = nil | ||
|
|
||
|
|
There was a problem hiding this comment.
Could enclose the above in a do ... end block to create a new scope and actually destroy them but since they are just numbers it is probably a net negative.
IamPete1
force-pushed
the
scr_luacheck_fix
branch
from
f13d4f1 to
3b0d1a8
Compare
tpwrules
previously requested changes
Dec 23, 2024
tpwrules
approved these changes
Dec 23, 2024
tridge
reviewed
Dec 24, 2024
| @@ -474,11 +464,10 @@ function do_knife_edge(arg1,arg2) | |||
| if not running then | |||
| running = true | |||
| height_PI.reset() | |||
| knife_edge_s = now | |||
| knife_edge_ms = now | |||
tridge
previously requested changes
Dec 24, 2024
There was a problem hiding this comment.
I think the Scipting_Controller.lua and sport_aerobatics.lua should be broken out for @Hwurzburg to look at
IamPete1
force-pushed
the
scr_luacheck_fix
branch
from
3b0d1a8 to
e3b69a5
Compare
Changes to those two files have been dropped. |
rmackay9
dismissed
tridge’s stale review
Tridge's request to remove aerobatics has been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the lua check issues, no more
-- luacheck: only 0. There are still lots of lua language server issues that we should fix.....