waf: add defaults.parm support to esp32 using ROMFS #28867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And drop broken remnants of code using apj_tool to do it.
srmainwaring
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
LGTM. Tested with esp32s3empty:
Edit esp32s3empty.h to enable ROM_FS:
-#define AP_FILESYSTEM_ESP32_ENABLED 0
+#define AP_FILESYSTEM_ESP32_ENABLED 1
#define AP_SCRIPTING_ENABLED 0
-#define HAL_USE_EMPTY_STORAGE 1
+// #define HAL_USE_EMPTY_STORAGE 1Add ./libraries/AP_HAL_ESP32/hwdef/esp32s3empty/defaults.parm
LOG_DISARMED 1
SERIAL0_PROTOCOL 0Clean, configure, build, upload and verify that the console does not display mavlink. Found I need to switch vehicle type and power cycle to be sure the changes are picked up.
It's already conditionally defined to nullptr in the top-level AP_HAL.
rmackay9
approved these changes
Dec 23, 2024
davidbuzz
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And drop broken remnants of code using apj_tool to do it. Now just load the file at
libraries/AP_HAL_ESP32/hwdef/<board>/defaults.parmuntil we get hwdef.dat support in.According to tridge, apj_tool is deprecated anyway. It's difficult to use because the .bin has an XOR checksum and SHA256 checksum that would have to be patched up. So just switch to using the already-working ROMFS.
Tested on the stampfly.