Skip to content

Commit

Permalink
Bug fix. Nodejs invocation was broken
Browse files Browse the repository at this point in the history
Signed-off-by: Prabhu Subramanian <[email protected]>
  • Loading branch information
prabhu committed Oct 5, 2023
1 parent 2eaa060 commit 973f1c7
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name := "atom"
ThisBuild / organization := "io.appthreat"
ThisBuild / version := "1.2.4"
ThisBuild / version := "1.2.5"
ThisBuild / scalaVersion := "3.3.1"

val chenVersion = "0.0.11"
Expand Down
2 changes: 1 addition & 1 deletion wrapper/nodejs/build.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
rm -rf plugins/atom*
rm -rf plugins/bin plugins/lib
if [ -e "../../target/atom.zip" ]; then
cp -rf ../../target/atom.zip plugins/
unzip -q plugins/atom.zip -d plugins
Expand Down
4 changes: 2 additions & 2 deletions wrapper/nodejs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const JAVA_OPTS = `${
process.env.JAVA_OPTS || ""
} -Xmx${freeMemoryGB}G ${JVM_ARGS}`;
export const APP_MAIN_CLASS = "io.appthreat.atom.Atom";
export const ATOM_VERSION = "1.2.0";
export const ATOM_VERSION = "1.2.5";

This comment has been minimized.

Copy link
@prabhu

prabhu Oct 5, 2023

Author Contributor

We need to move away from this hardcoded versioning model.

export const APP_CLASSPATH = join(
APP_LIB_DIR,
`io.appthreat.atom-${ATOM_VERSION}-classpath.jar`
Expand Down Expand Up @@ -57,7 +57,7 @@ export const executeAtom = (atomArgs) => {
.concat([
"-cp",
atomLibs.join(delimiter),
`-Dlog4j.configurationFile=${LOG4J_CONFIG}`,
`-Dlog4j2.configurationFile=${LOG4J_CONFIG}`,
APP_MAIN_CLASS,
...atomArgs
]);
Expand Down
4 changes: 2 additions & 2 deletions wrapper/nodejs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion wrapper/nodejs/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@appthreat/atom",
"version": "1.2.4",
"version": "1.2.5",
"description": "Create atom (⚛) representation for your application, packages and libraries",
"exports": "./index.js",
"type": "module",
Expand Down

0 comments on commit 973f1c7

Please sign in to comment.