fix: make theme uploads more tolerant #5617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are missing keys in the light or dark theme file, we simply replace them with default values.
This is not a good way of handling errors, but it's better than failing indiscriminately without any proper feedback.
I've added a
getMissingKeys
to compare and see which values are missing, and written some quick unit tests for it. We should find a way to use it so we can let users know if their theme has missing values.Relates: #5359
PR Checklist