Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill field_settings on creating linked view #5598

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

zoli
Copy link
Contributor

@zoli zoli commented Jun 21, 2024

  1. Create a grid
  2. create a board view from that grid
  3. Change group field of the board view

You will see that the cards are empty and if you click on the card it throws an error.

The problem is the field_settings in field_infos are empty. The root cause is that on creating linked view it doesn't add fields settings from the view we are linking to.
I fixed this by getting field settings from the parent view (the one we are linking new view) and adding it to the new view that is getting created.

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@Xazin Xazin added the v0.6.2 label Jun 27, 2024
@Xazin Xazin merged commit b24fbc6 into AppFlowy-IO:main Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants