Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space issues #5531

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Fix space issues #5531

merged 12 commits into from
Jun 14, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jun 13, 2024

Feature Preview

closes #5530

  • disable the space migration for local user
  • display the space icon in breadcrumb and disable the space entry
Screenshot 2024-06-13 at 15 11 36
  • The icon and the title are not aligned center.
Screenshot 2024-06-13 at 15 13 54
  • incorrect space icon corner radius
Screenshot 2024-06-13 at 15 15 01
  • missed tooltip
Screenshot 2024-06-13 at 15 16 38
  • use general as default space name
  • space name overflows if it's too long
  • only show the expand icon when hovering on the pages
  • support adding a new space from space more menu
  • filter the space view from favorites and recent views

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Jun 13, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 26 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (94f9349) to head (829981d).
Report is 793 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #5531       +/-   ##
==========================================
+ Coverage   9.70%   86.62%   +76.92%     
==========================================
  Files        685      219      -466     
  Lines      31812     5039    -26773     
  Branches       0      833      +833     
==========================================
+ Hits        3086     4365     +1279     
+ Misses     28726      565    -28161     
- Partials       0      109      +109     
Flag Coverage Δ
appflowy_flutter_unit_test ?
appflowy_web_app 86.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 added the bug Something isn't working label Jun 14, 2024
@LucasXu0 LucasXu0 merged commit 785597f into AppFlowy-IO:main Jun 14, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] space issues
1 participant