Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/opentelemetry #1467

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Feature/opentelemetry #1467

merged 15 commits into from
Sep 24, 2024

Conversation

ramonavic
Copy link
Contributor

@ramonavic ramonavic commented Sep 9, 2024 •
edited
Loading

Description

Add a meaningful description explaining the change/fix that is provided in this PR

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations
  • PR was created with the "Allow edits and access to secrets by maintainers" checkbox checked

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@ramonavic ramonavic force-pushed the feature/opentelemetry branch 2 times, most recently from 675bcdc to d191675 Compare September 16, 2024 15:09
@ramonavic ramonavic marked this pull request as ready for review September 19, 2024 13:38
@ramonavic ramonavic requested a review from 4c0n September 19, 2024 13:40
@ramonavic ramonavic force-pushed the feature/opentelemetry branch from 0f66cb4 to f4856ec Compare September 24, 2024 09:09
@ramonavic ramonavic merged commit 24156d8 into main Sep 24, 2024
3 checks passed
@ramonavic ramonavic deleted the feature/opentelemetry branch September 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4c0n 4c0n 4c0n approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonavic @4c0n