Add test container build stage #1375

4c0n · 2023-10-02T11:21:28Z

Description

Add build stage for building container image to run tests in.

Checklist

Keep the PR, and the amount of commits to a minimum
The commit messages are meaningful and descriptive
The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
Check that the branch is based on main and is up to date with main
Check that the PR targets main
There are no merge conflicts and no conflicting Django migrations

How has this been tested?

Provided unit tests that will prove the change/fix works as intended
Tested the change/fix locally and all unit tests still pass
Code coverage is at least 85% (the higher the better)
No iSort, Flake8 and SPDX issues are present in the code

commit 47c33363e8e31352efb3598282a1307eaec70663 Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:39:00 2024 +0100 Bumped version to 2.34.4 commit dd25b1cecac22986ab29b69de62b208658f22665 Merge: 735f745f 1e13a535 Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:37:27 2024 +0100 Merge pull request #1436 from Amsterdam/fix/maintenance-mode-exempt-health-check Exempt the health-check from the maintenance mode commit 1e13a535964242694ef15a1073be1891b5bb932b Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:31:23 2024 +0100 Exempt the health-check from the maintenance mode commit 735f745f9a03f53c9565594b6825f1e6cfa24b3c Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:46:08 2024 +0100 Bumped version to 2.34.3 commit e9900dfcbfba733a5f49bfc16d7b5ff46e992b07 Merge: d441d765 d097c85c Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:43:46 2024 +0100 Merge pull request #1435 from Amsterdam/feature/maintenance-mode Added "Maintenance mode" commit d097c85c22b586d8a34480cc439df34b8f8450c9 Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:35:53 2024 +0100 Added "Maintenance mode", by default this mode is disabled. It can be enabled/disabled by setting the env variable `MAINTENANCE_MODE` to `true` or `false`. commit d441d765e2dd6663e426336c425c1815ce013f0f Author: David van Buiten <[email protected]> Date: Mon Feb 12 08:58:27 2024 +0100 Bumped version to 2.34.2 commit 83345ddb209f77273e6505782d40dd15dd5acf0a Merge: cba36948 46495372 Author: David van Buiten <[email protected]> Date: Fri Feb 9 10:44:44 2024 +0100 Merge pull request #1434 from Amsterdam/chore/update-requirements Updated the requirements commit 46495372f2b3fc5187ff6e1be60ad638237e8f17 Author: David van Buiten <[email protected]> Date: Thu Feb 8 09:39:44 2024 +0100 Updated the requirements commit cba3694862d231fc922d3bf66ebb530fda3983f5 Merge: e7a3d332 5fe78a42 Author: David van Buiten <[email protected]> Date: Thu Feb 8 09:27:39 2024 +0100 Merge pull request #1433 from Amsterdam/dependabot/pip/app/requirements/django-3.2.24 Bump django from 3.2.23 to 3.2.24 in /app/requirements commit 5fe78a4246e5d5879c5f4614e38d4fa5759fb640 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 7 22:56:54 2024 +0000 Bump django from 3.2.23 to 3.2.24 in /app/requirements Bumps [django](https://github.com/django/django) from 3.2.23 to 3.2.24. - [Commits](https://github.com/django/django/compare/3.2.23...3.2.24) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit e7a3d3328d1814880805afa1a80d841715d0f6f3 Author: David van Buiten <[email protected]> Date: Tue Jan 23 10:33:17 2024 +0100 Bumped version to 2.34.1 commit 0254a016dcf62891584db63b5ac8d78c7a73fdfc Merge: 45480673 a9178f33 Author: David van Buiten <[email protected]> Date: Tue Jan 23 10:29:57 2024 +0100 Merge pull request #1432 from Amsterdam/chore/update-requirements Update project dependencies commit a9178f33e6da7ac8a22bc4055b45012210eea3df Author: David van Buiten <[email protected]> Date: Mon Jan 22 14:48:45 2024 +0100 Update project dependencies commit 45480673079060e8b1cd6427fe6cf1938e7f4aa0 Merge: a54fbf5c 735e8558 Author: David van Buiten <[email protected]> Date: Mon Jan 22 08:48:49 2024 +0100 Merge pull request #1417 from delta10/elasticsearch-timeout-pr Add configurable timeout to search app commit 735e8558b44b9a2b431a6bc3813442495b9a6066 Author: Lennart Ackermans <[email protected]> Date: Tue Nov 14 17:15:01 2023 +0100 Add configurable timeout to search app Revert "Add configurable timeout to search app" This reverts commit c1ed0946ac8929a357866ad36389274a4e5174f6. Add configurable timeout to search app (corrected) fix ELASTICSEARCH_TIMEOUT type error commit a54fbf5c7753b5b3b00ff68af66ed1caac855318 Author: David van Buiten <[email protected]> Date: Thu Jan 18 14:07:41 2024 +0100 Bumped version to 2.34.0 commit 3800886a8158f612c1540b60962929ce65983931 Author: Youri Westerman <[email protected]> Date: Tue Jan 9 12:05:15 2024 +0100 Bump version commit f2aad9cd02d680321ee25d6fddbcfe9f945624f4 Author: Youri Westerman <[email protected]> Date: Tue Jan 9 12:04:34 2024 +0100 Use database cache backend (#1431) * Use database cache backend by default * Create cache table in init script commit 9105c7b27c388436b13cb7a3b7dbe356f71d782e Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:16:49 2024 +0100 Bumped API version to 2.34.0-beta.6 commit 23d22ff3736894833807039f5b336b78268777c3 Merge: edf4c374 f01adad0 Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:14:01 2024 +0100 Merge pull request #1430 from Amsterdam/chore/throttling-ident-fix Throttling ident fix commit f01adad013f85dca4c57c9495ada7bb72a8ada18 Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:09:03 2024 +0100 In this commit the `get_ident` method, in the `PostOnlyNoUserRateThrottle` class, is updated to ensure that the identification string is stripped of the colon and port number commit edf4c374afa370e0c094b9f64df5c160ea899b85 Author: Youri Westerman <[email protected]> Date: Mon Jan 8 15:14:32 2024 +0100 Bump version commit 82b3d5c7cc7b54c5f231e37a6a5eb92d5e7d80b6 Author: Youri Westerman <[email protected]> Date: Mon Jan 8 14:56:45 2024 +0100 Throttling not working correctly (#1429) * Add caddy to dev setup * Log throttle result commit 72fe74e6a4a634263f39cc6a743a56b3a2a6b97d Author: Youri Westerman <[email protected]> Date: Thu Jan 4 11:46:00 2024 +0100 bump version commit 8cbe1036e5cc5e4e6717941267d31e15feba3271 Author: Youri Westerman <[email protected]> Date: Thu Jan 4 11:30:17 2024 +0100 Update dependencies (#1428) * Update dependencies * Ignore mypy false positive commit 9aa5e3e12afbf8ee3952dd3d02fe72b3e80d8962 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 4 10:37:07 2024 +0100 Bump jwcrypto from 1.5.0 to 1.5.1 in /app/requirements (#1427) Bumps [jwcrypto](https://github.com/latchset/jwcrypto) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/latchset/jwcrypto/releases) - [Commits](https://github.com/latchset/jwcrypto/compare/v1.5.0...v1.5.1) --- updated-dependencies: - dependency-name: jwcrypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 68dabe2438a68dd654097c2580cc5722dad0079a Author: Bart <[email protected]> Date: Tue Dec 12 12:57:39 2023 +0100 fix: do not include full name in e-mail notification for assigned action (#1416) commit 63198f03c0ddb46f7223d166c8a0248dacb0b2a1 Author: Bart <[email protected]> Date: Tue Dec 12 09:47:42 2023 +0100 Make O365_MAIL_SAVE_TO_SENT configurable (#1357) commit 2c247cba6a8fead8ae3f8b7bc129108f58ada77c Author: Youri Westerman <[email protected]> Date: Mon Dec 11 13:20:24 2023 +0100 Use typed drf amsterdam package (#1418) * Add type to serializer property * Add type annotation for _display property * Add type annotation to _display property * Refactor CategoryHyperlinkedIdentityField and PrivateCategoryHyperlinkedIdentityField to be based on LinksField as is specified in the HALSerializer * Have PrivateSignalLinksField extend LinksField instead of HyperLinkedIdentityField * Have PublicSignalLinksField extend LinksField instead of HyperLinkedIdentityField * Have PrivateSignalLinksFieldWithArchives extend LinksField instead of HyperLinkedIdentityField * Have StoredSignalFilterLinksField extend LinksField instead of HyperLinkedIdentityField * Have QuestionnairePublicHyperlinkedIdentityField extend LinksField instead of HyperLinkedIdentityField * Have SessionPublicLinksField extend LinksField instead of HyperLinkedIdentityField * Have UserHyperlinkedIdentityField extend LinksField instead of HyperLinkedIdentityField * Have PrivateSignalAttachmentLinksField extend LinksField instead of HyperLinkedIdentityField * Have PublicSignalAttachmentLinksField extend LinksField instead of HyperLinkedIdentityField * Havee PrivateSignalWithContextLinksField extend LinksField instead of HyperLinkedIdentityField * Have MySignalDetailLinksField extend LinksField instead of HyperLinkedIdentityField * Have MySignalListLinksField extend LinksField instead of HyperlinkedIdentityField * Have EmptyHyperlinkedIdentityField extend LinksField instead of HyperlinkedIdentityField * Replace mixin with base class * Sync mypy baseline * Small optimization of container build process * Update dependencies * Specify view_name as is required by stubs package commit c2602a574f53225c4dc1259563ee2962e71aff77 Merge: 6821e254 6aa95d69 Author: David van Buiten <[email protected]> Date: Wed Dec 6 09:59:54 2023 +0100 Merge pull request #1426 from Amsterdam/chore/update-github-workflow-build_and_push_to_docker_hub Improve Docker image build and push workflow commit 6aa95d6924c5e197948e227545f7970bbaf9dcd2 Author: David van Buiten <[email protected]> Date: Tue Dec 5 11:48:18 2023 +0100 Improve Docker image build and push workflow - Update actions/checkout to v4 - Use the docker/login-action for logging into Docker Hub - Docker meta extraction with docker/metadata-action v5 - Docker image build and push with docker/build-push-action v5 - Generate 'latest' tag for releases commit 6821e254c8d445757c2f80680ee0cc993dccc599 Merge: 363a0a78 8ad2c57d Author: David van Buiten <[email protected]> Date: Tue Dec 5 10:03:37 2023 +0100 Merge pull request #1425 from Amsterdam/chore/update-github-action-ci Update github action checkout from v3 to v4 for the ci workflow commit 8ad2c57d99203a306b9ba245401b203ad7f837ce Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:55:59 2023 +0100 Update github action checkout from v3 to v4 for the ci workflow commit 363a0a7880733448e020a4e4a3f453a1bb94d772 Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:23:53 2023 +0100 Bumped API version to 2.34.0-beta.3 commit 4844f440663de6aa53d8597058b8c752e8bccc87 Merge: 39614534 13949d73 Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:22:26 2023 +0100 Merge pull request #1424 from Amsterdam/chore/fix-questionnaires-information-exposure Fixed: Information exposure through an exception commit 13949d7332aa0e7ce36ccce658dc501c9ad751ac Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:15:16 2023 +0100 Fixed: Information exposure through an exception commit 39614534f8c221c05873a6d69202285abbf5bb93 Author: David van Buiten <[email protected]> Date: Tue Dec 5 08:42:41 2023 +0100 Bumped API version to 2.34.0-beta.2 commit c903d417ba9da9aae33d99201ea0765e63cd9df9 Merge: 7ba25299 28e30fd7 Author: David van Buiten <[email protected]> Date: Mon Dec 4 16:16:00 2023 +0100 Merge pull request #1423 from Amsterdam/chore/fix-sigmax-XXE-issue Sigmax, fix for XML external entity expansion commit 28e30fd705fed98c0fe81ab8f60acb69d8e3acfd Author: David van Buiten <[email protected]> Date: Mon Dec 4 15:51:20 2023 +0100 Removed `no_network=True`, `True` is the defaul. Updated SPDX headers. Added unit test and XXE test file. commit bb14b820974647f2af15f389f58985241f9e9ac8 Author: David van Buiten <[email protected]> Date: Mon Dec 4 15:02:49 2023 +0100 The lxml `etree.fromstring()` function has a security risk of XXE attacks. A custom XML parser is now used that disables resolving entities and blocks network access. commit 7ba25299fe84baa276646e69c564e2412f026f77 Author: David van Buiten <[email protected]> Date: Wed Nov 29 13:12:18 2023 +0100 Bumped API version to 2.34.0-beta.1 commit 6cb99d96b50afb13bd1bdfb4960bda823f41e47a Merge: bee5f33d e0a625a7 Author: David van Buiten <[email protected]> Date: Wed Nov 29 13:07:55 2023 +0100 Merge pull request #1422 from Amsterdam/chore/update-requirements Updated requirements commit e0a625a72b25eade4408b33f05c133b825f5af9d Merge: 32400f38 bee5f33d Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:56:30 2023 +0100 Merge branch 'main' into chore/update-requirements commit bee5f33d52753e2ad44f122f8c82c46cebd0f844 Merge: 14ddc6a0 fe1de896 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:55:03 2023 +0100 Merge pull request #1420 from Amsterdam/dependabot/pip/app/requirements/pypdf-3.17.0 Bump pypdf from 3.16.4 to 3.17.0 in /app/requirements commit 32400f38dc310c87469d6073c092bb5f38b9d41c Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:47:12 2023 +0100 Updated requirements commit fe1de896d12d209ab1675f85d8f3fedb60903d2f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 11:43:08 2023 +0000 Bump pypdf from 3.16.4 to 3.17.0 in /app/requirements Bumps [pypdf](https://github.com/py-pdf/pypdf) from 3.16.4 to 3.17.0. - [Release notes](https://github.com/py-pdf/pypdf/releases) - [Changelog](https://github.com/py-pdf/pypdf/blob/main/CHANGELOG.md) - [Commits](https://github.com/py-pdf/pypdf/compare/3.16.4...3.17.0) --- updated-dependencies: - dependency-name: pypdf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit 14ddc6a03a5c5b5f39ad92e2e20354f5337485fa Merge: 3bda303e eda8c352 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:49:38 2023 +0100 Merge pull request #1421 from Amsterdam/dependabot/pip/app/requirements/django-3.2.23 Bump django from 3.2.22 to 3.2.23 in /app/requirements commit eda8c352fd8f8c4ae37fccd9ea8d34c625e35508 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 11:43:13 2023 +0000 Bump django from 3.2.22 to 3.2.23 in /app/requirements Bumps [django](https://github.com/django/django) from 3.2.22 to 3.2.23. - [Commits](https://github.com/django/django/compare/3.2.22...3.2.23) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit 3bda303e39ebeb5f130bf30595db5f3d911f7f7f Merge: 076cb496 370d90c4 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:40:47 2023 +0100 Merge pull request #1419 from Amsterdam/dependabot/pip/app/requirements/cryptography-41.0.6 Bump cryptography from 41.0.5 to 41.0.6 in /app/requirements commit 370d90c43d855b2c62dc1ee7fe7bf6e71bb5535e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 00:26:54 2023 +0000 Bump cryptography from 41.0.5 to 41.0.6 in /app/requirements Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.5 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.5...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> commit 076cb496edad550e870c91a4af4e927ff4686c7b Author: David van Buiten <[email protected]> Date: Mon Nov 13 10:12:31 2023 +0100 Bumped API version to 2.33.0 commit 75d8271bb4d26e713d48f927348c35a9914b0aad Author: David van Buiten <[email protected]> Date: Mon Nov 6 09:06:39 2023 +0100 Bumped API version to 2.33.0-beta.1 commit 99650ec079cb58ae79b235c5dc6a2f74fa720b6b Merge: 4d1ef63c 91b2b126 Author: David van Buiten <[email protected]> Date: Wed Nov 1 12:58:08 2023 +0100 Merge pull request #1415 from Amsterdam/feature/attachtment-permissions Added new attachment permissions commit 91b2b12608c9a9d693f6a0e6355d4011354ba560 Author: David van Buiten <[email protected]> Date: Mon Oct 30 16:24:53 2023 +0100 Added the SIAAttachmentPermissions and implemented this permission in the PrivateSignalAttachmentsViewSet + updated and added unit tests commit 0db79d2d7d04e04dda53cae45195074aca8ffeb2 Author: David van Buiten <[email protected]> Date: Mon Oct 30 16:23:56 2023 +0100 Added 2 permissions to the Attachement model + updated tests commit 4d1ef63cee808b6bf06d78848d512e38bad8104a Merge: 8468b43d 8c5ff688 Author: David van Buiten <[email protected]> Date: Wed Oct 25 15:49:12 2023 +0200 Merge pull request #1414 from Amsterdam/chore/add-oidc-create-user-setting Added the `OIDC_CREATE_USER` setting to prevent user creation by the `mozilla-django-oidc` package commit 8c5ff6886b07b9920c85cdbbca57dd087c2a9377 Author: David van Buiten <[email protected]> Date: Wed Oct 25 13:08:08 2023 +0200 Added the `OIDC_CREATE_USER` setting (set to `False`) to prevent user creation. This commits also removes the custom code that was created to prevent this behaviour. This change is made in accordance with the `mozilla-django-oidc` the documentation. commit 8468b43d46d89f1bb0bb082412220fea799b9852 Merge: f3d8636a 5237c33f Author: David van Buiten <[email protected]> Date: Wed Oct 25 15:30:25 2023 +0200 Merge pull request #1413 from Amsterdam/chore/remove-unused-authorization_django-package Removed unused `datapunt-authorization-django` package commit 5237c33f92c800ec51869386fdefbf2a552b839b Author: David van Buiten <[email protected]> Date: Wed Oct 25 11:46:52 2023 +0200 Removed unused authorization_django package commit f3d8636a4a1de4622b0358039836a5fe69157610 Author: Youri Westerman <[email protected]> Date: Wed Oct 25 14:47:21 2023 +0200 Bump version commit c7ae8d970bae0a85cb26e8d154ababe20b7224db Author: Youri Westerman <[email protected]> Date: Wed Oct 25 10:17:33 2023 +0200 Bump Version commit 1545d2542a966af2eb284e021990da93e5509159 Author: Youri Westerman <[email protected]> Date: Wed Oct 25 10:01:29 2023 +0200 Move asserts to the lines where they are required (#1411) * Move asserts to the lines where they are required * Correct the return type of get_description() commit 9b1b39aafac27b9a6deb0031bff41cff12a0cf55 Author: Youri Westerman <[email protected]> Date: Tue Oct 24 12:11:02 2023 +0200 Solve mypy issues services (#1410) * Assert that filename exists * Add some typing info to DslService * Add asserts and type for property * Satisfy isort * Refactor logic to get expression and expression type from query params * Sync mypy baseline commit 5fad6ed8f319eddec07aefc42628beb47586cdc2 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:54:56 2023 +0200 Bumped API version to 2.32.1-beta.1 commit 2d6ea8becd97b484cd6810a2a02a1bbb7c5b6b28 Merge: 88409570 736ee193 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:42:51 2023 +0200 Merge pull request #1409 from Amsterdam/chore/solve-mypy-issues-email_integrations Solve mypy issues email_integrations commit 736ee19378aacf2ed917297d1c9bf52a8cb4c8a3 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:34:18 2023 +0200 Refactored deprecated typing.Union in email_integrations commit 94c8acd8dda09f7cf6288df533700d8791ab30e9 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:27:28 2023 +0200 Solve mypy issues email_integrations commit 88409570cd5106fbae09d6ba94e5521e2ba761d8 Merge: e7d00a32 68f1a003 Author: David van Buiten <[email protected]> Date: Tue Oct 24 09:36:56 2023 +0200 Merge pull request #1408 from Amsterdam/chore/refactor-oidc-admin Small refactor of the OIDC admin commit 68f1a003912cc5bc21597dbbae2b6685b66b5cb2 Author: David van Buiten <[email protected]> Date: Tue Oct 24 09:20:37 2023 +0200 Small refactor of the OIDC admin - Removed the `views.py` and now use the TemplateView for the url path `signals/oidc/login_failure/` - Removed the `update_user` method of the `AuthenticationBackend`. It is already defined (the same way) in the mozilla_django_oidc `OIDCAuthenticationBackend` - Added tests to get 100% coverage commit e7d00a32a35591040d92704e16139b6eb2e207e6 Author: Youri Westerman <[email protected]> Date: Tue Oct 24 09:29:08 2023 +0200 Add networkx stubs (#1407) * Install networkx-stubs * Sync mypy baseline commit 970e510c596efb309255e3cc01f0398452e363a7 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 17:06:08 2023 +0200 Add celery types (#1406) * Alphabetically order test dependencies * Install celery types package * Use correct argument name for celery task priority * Sync mypy baseline commit 0c4928cbd072dd90a7cb358c427c4da067aaecfa Author: Youri Westerman <[email protected]> Date: Mon Oct 23 16:54:43 2023 +0200 Have JWTAuthBackend extend BaseAuthentication (#1405) * Have JWTAuthBackend extend BaseAuthentication * Sync mypy baseline * Move docs inside method * Fix broken test commit 1bd2ad732cb465ca02149031b66a7398fac6abf2 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 16:10:59 2023 +0200 Solve mypy issues api (#1404) * Add type to property address_validation_url * Remove type declaration as it is currently not possible to specify the correct one * Add None asserts * Raise validation error if token does not have expiry date time * Raise exception when permission is used with unsupported view * Assert that request returned from context is a Request * Prevent circular reference by importing inside method * Correct return type and explicitly return None * Add return type * Assert that there is an old reporter * Assert we actually get a Request object from the context and raise exception if passed model is not an Attachment * Assert that we're getting the objects that we're expecting * Add exception to be raised when we don not get the correct model type * Convert mixin into Base class, the mixin was refering to self.context which it did not have * Use correct return types and import timedelta() from the right module * Use the correct argument types for has_permission() override * Use the correct return type * Correct the return type of get_category_names() * Use correct argument type of overriden perform_update() as it should be contravariant * Use list instead of tuple for authentication_classes property * Satisfy isort * Use the correct amount of empty lines between classes * Use list instead of tuple for authentication_classes * Declare headers as empty dict instead of list * Use AbstractUser instead of User, define dict shape, make sure we can assign None to arguments and assert that the signal reporter exists * Add urlpatterns property * Use list instead of tuple for authentication_classes * Make arguments nullable * Add property types * Give freeze_time() the float that it requires * Provide mute_signals() decorator with (Django) Signals instead of strings * Replace return type with AbstractUser * Sync mypy baseline commit bd057299a21c994e8aa66e6b7c8e07ac545c7c05 Merge: 3669aaa6 c508cb8d Author: David van Buiten <[email protected]> Date: Mon Oct 23 15:36:25 2023 +0200 Merge pull request #1403 from Amsterdam/chore/refactor-log-app Moved logging to the settings and removed the logs "app" commit c508cb8d4ed5c93bcdf3cfe4a85c62b1503e80fa Author: David van Buiten <[email protected]> Date: Mon Oct 23 15:28:25 2023 +0200 Moved logging to the settings and removed the logs "app" commit 3669aaa69ba4f048b31ac72d97452ae3b214db97 Merge: 0b5f10bb ec7a5128 Author: David van Buiten <[email protected]> Date: Mon Oct 23 14:07:27 2023 +0200 Merge pull request #1402 from Amsterdam/chore/solve-mypy-issues-questionnaires Solve mypy issues questionnaires commit ec7a51282e93c25525de9348d92e703ce4366919 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:57:11 2023 +0200 Fixed isort issues commit db5b22f64b627304624f68b7372c351e84ba3173 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:44:17 2023 +0200 Synced baseline commit c90fb70062569ec7f376b731c8f65ae40608fa85 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:38:12 2023 +0200 Solved fieldtypes mypy issues commit b8cfc6c2e65ff1118b2d55437269439ac58c4fc8 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:28:17 2023 +0200 Solved (most) admin mypy issues commit 27cfeaa442a594a46640eaa605c161a8fc968e4c Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:06:36 2023 +0200 Solved factories mypy issues commit 5bd594edd445f0310dd31902d85e9a4a261a6ec7 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:04:00 2023 +0200 Solved NameSpace urlpatterns mypy issue commit 0b5f10bb1fd3750596b3695533de4b4d4e948867 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 11:48:39 2023 +0200 Update dependencies (#1401) * Update dependencies * Sync mypy baseline commit 2eedbf12b96aa3a00b269f3b70047c56a30c3cad Author: David van Buiten <[email protected]> Date: Mon Oct 23 09:25:20 2023 +0200 Bumped API version to 2.32.0 commit ceadf9636e88096f75adf02e61e0eebae65d9081 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:56:47 2023 +0200 Bumped API version to 2.32.0-beta.4 commit 5d9c4a46cc688e8bee0accd877a4d79e218dd16e Merge: 6266713b acf2799c Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:51:34 2023 +0200 Merge pull request #1400 from Amsterdam/chore/solve-mypy-issues-signals Chore/solve mypy issues signals commit acf2799c28bde21b23f302ff3009861c39a10e7f Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:44:33 2023 +0200 Removed redundant check commit 1a91792a2b0e8fff1aa2cff9d54d17a7c66c3f08 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:31:53 2023 +0200 Sync baseline commit 98cd54f8c2cebde30c9f58b0b660dfacf1c0fb0e Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:29:27 2023 +0200 Fixed flake8 issues commit 7291b417c19b60ebd122e78751dc8ecc188dcd03 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:14:56 2023 +0200 Solved mypy issues in reporter model commit 61e756c5032ada1085ce93450a2c7b12c983a77c Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:13:07 2023 +0200 Solved mypy issues in status message model commit 616a6b7fecf8c0eef3016baa1ea7e4d64d453850 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:43:54 2023 +0200 Solved mypy issues in category model commit 3d31b53e8c248747ad717d125e6f8f538fed6a89 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:43:13 2023 +0200 The setting API_MAX_UPLOAD_SIZE should always be an integer commit a9382899b643ab588169b0eb684a998ea264f8a9 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:39:13 2023 +0200 Solved mypy issues in deleted signals model commit 65cf9494ead8a8c6464b7e814e11acb48ee37031 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:30:47 2023 +0200 Solved mypy issues in signals migration 0046. Skip type check for AutoSlugField from the django_extensions plugin. commit a696c7f0713232e4059b77f098ecdf1eca96d986 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:29:59 2023 +0200 Solved mypy issues in signals migration 0159. As the migrations are not reversable the fake lambda reverse code has been removed. commit f85843e236e0f3bf05df6b26f7cb35eba6247ca7 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:23:42 2023 +0200 Solved mypy issues in signals migration 0138. The code stated a reverse is not possible, therefore removed the fake lambda reverse code. commit d79b4a081a42cb746386ab57142d33e538237ab3 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:02:00 2023 +0200 Solved mypy issues in signals scenarios context commit 7101c34a4a76b23a5816741e21614c7f10a7b9ce Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:00:09 2023 +0200 Solved mypy issues in deleted signals admin commit 22a93bf05c3317daf3b6c572db18c218bffbea24 Author: David van Buiten <[email protected]> Date: Fri Oct 20 08:56:49 2023 +0200 Solved mypy issues in delete signals task commit 3dd67ea709c9729212af9035125007255aa2c283 Author: David van Buiten <[email protected]> Date: Fri Oct 20 08:48:04 2023 +0200 Solved mypy issues in signals admin commit 12632546031f136a00479297daea7da46be0086b Author: David van Buiten <[email protected]> Date: Thu Oct 19 11:41:56 2023 +0200 Solved mypy issues in signals factories commit 6266713bdbb35d2b1efaf03e1e3957ae5cc7d70c Author: Youri Westerman <[email protected]> Date: Thu Oct 19 08:43:10 2023 +0200 Solve mypy issues user (#1399) * Correct types for profile serializer * Resolve type issues with user factory * Use decorator in admin instead of short_description and no longer functioning allow_tags properties * Update copyright * Add return type to function * Add return type to function * Use list instead of tuple * Sync baseline commit 34b61cdfd992e339db054bc6c8cf34bdd203a609 Merge: 92ee3db1 c5047411 Author: David van Buiten <[email protected]> Date: Wed Oct 18 15:05:21 2023 +0200 Merge pull request #1397 from Amsterdam/chore/solve-mypy-issues-history Solve mypy issues history app commit c5047411aa522f476345ea7eeea3db731e309fb9 Author: David van Buiten <[email protected]> Date: Wed Oct 18 14:50:42 2023 +0200 Add assertion on self.object in the 'translate_content_type' and 'get_description' methods on the Log model commit 98d58ffe22c11f9b7cc22eadaf382e761d3cfb11 Author: David van Buiten <[email protected]> Date: Wed Oct 18 14:40:58 2023 +0200 Add assertion on self.object in the 'get_action' method on the Log model commit 68e883344e6d0c851f6ba2657e4362bef5d006ef Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:56:13 2023 +0200 Sync baseline commit bfa7121ca1a344a6cbc02e7039c7d19f3e596432 Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:55:46 2023 +0200 Resolved mypy issues in the history app commit 92ee3db11fe7a981e4ae9a1976568ea9c78aadf0 Author: Youri Westerman <[email protected]> Date: Wed Oct 18 14:52:43 2023 +0200 Solve mypy issues reporting (#1398) * Correct type hint for path parameter * Correct types in serializer * Use list instead of tuple * Correct types for task save_csv_file_datawarehouse * Correct types in tasks * Add property definition * Sync baseline commit 1581bef908ea5b70e890c06eac7190d742e04fae Merge: b75decaf ab819279 Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:26:25 2023 +0200 Merge pull request #1396 from Amsterdam/chore/solve-mypy-issues-feedback Solve mypy issues feedback commit ab819279b24371d89d537d67a6d56bd7baba0d3f Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:15:10 2023 +0200 Sync baseline commit 4f2711a73cf364dcc1f3b08c638b320d0f48ab9c Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:14:49 2023 +0200 Resolved mypy issues in the feedback app commit b75decafb886a3153f8978ddfc638f74c5fb7824 Author: Youri Westerman <[email protected]> Date: Wed Oct 18 13:05:03 2023 +0200 Solve mypy issues sigmax (#1395) * Add types * Add type to property * Use list instead of tuple * Assert status is not None, log exception and convert minutes to float * Resolve mypy issues in tests * Make check type friendlier * Sync baseline commit 16e8b657c6c9b8a6c78e93e8edb7937ad0f4ba83 Author: Youri Westerman <[email protected]> Date: Tue Oct 17 15:03:36 2023 +0200 Solve mypy issues search (#1394) * Declare authentication classes as list * Don't use list serializer, but use the "many" parameter * Sync baseline commit 9491aa7a94b0c9d21992ceed69d219afee021988 Author: Youri Westerman <[email protected]> Date: Tue Oct 17 14:37:46 2023 +0200 Limit elasticsearch heap to 4gb (#1393) commit 076feab2531cfe354532e4552bb63bcdc166532d Author: David van Buiten <[email protected]> Date: Tue Oct 17 14:15:09 2023 +0200 Bumped API version to 2.32.0-beta.3 commit 3166802585598c0271fd56169e5d52c425a1d60e Author: Youri Westerman <[email protected]> Date: Tue Oct 17 12:48:58 2023 +0200 Solve mypy issues dataset (#1392) * Define types in area loaders * Add type for DATASET_INFO and make sure PROVIDES gets the desired type by converting dict_keys to list * Convert dict_keys to list * Correct type hints * Update copyright year * Import Retry from urllib3 directly * Sync baseline commit f6871e918451f5cac025e5f2ec6361e98fc74d3d Author: David van Buiten <[email protected]> Date: Tue Oct 17 09:40:19 2023 +0200 Bumped API version to 2.32.0-beta.2 commit 0a004c03bd51ee2dade3c5a2a1a518a005aa7873 Merge: b98988f8 210df929 Author: David van Buiten <[email protected]> Date: Tue Oct 17 09:39:24 2023 +0200 Merge pull request #1391 from Amsterdam/task/update-reporter-permission-check Implemented 'sia_can_view_contact_details' permission check on signal reporter endpoints commit 210df929d4df4559199ed0fae6df1a14e6012979 Author: David van Buiten <[email protected]> Date: Tue Oct 17 08:59:47 2023 +0200 Fixed isort issues commit 4735926d773147446d0fde00d1eefdc738c4de95 Author: David van Buiten <[email protected]> Date: Tue Oct 17 08:52:08 2023 +0200 Implemented 'sia_can_view_contact_details' permission check on signal reporter endpoints and updated/added tests commit b98988f8485091d217115cae10f1c30f772e947a Author: Youri Westerman <[email protected]> Date: Mon Oct 16 16:07:16 2023 +0200 Solve mypy issues email integrations app (#1390) * Assert that signal relations are not None * Rename admin to not reflect the model name and set description of custom action using decorator * Explicitly make context argument optional * Assert that there is a reporter with an email address to send mail to * Refactor abstract rules * Make sure we get a float value from the settings * Add null checks * Declare actual list instead of tuple and add None assertions * Use list instead of tuple and add None assertion * Use list instead of tuple and add None assertions * Remove temporary permission exclusions * Use list as declared in type hint * Assert that the action type exists * Create reporter instead of passing factory * Add type hints to properties * Sync baseline commit f0b6a5b6de62e1c6566bba9446b6abc0c47aaf7c Author: David van Buiten <[email protected]> Date: Mon Oct 16 10:41:35 2023 +0200 Bumped API version to 2.32.0-beta.1 commit f88f84c253f3961619c0a55a891a368f42e9fdc7 Merge: 799d145d 0f9db47a Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:29:39 2023 +0200 Merge pull request #1389 from Amsterdam/task/cleanup-github-workflows Cleanup GitHub workflows commit 0f9db47a138183ca5c4d289b8de2edc2c2bc0322 Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:20:47 2023 +0200 Removed build and push to GHCR commit f3b34ba574b0b3f1dd8b14022e67d5e86d9847e6 Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:20:07 2023 +0200 Removed manually build and push to docker commit 6478479b3e905a87cd7a4c2ef359ed4de2dab7dc Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:07:55 2023 +0200 Removed unused github ci review environment actions commit 799d145de55455bb5ba1c8b9318f8cc98ad8b2e3 Merge: 7413a361 d3fef5db Author: David van Buiten <[email protected]> Date: Fri Oct 13 12:30:53 2023 +0200 Merge pull request #1388 from Amsterdam/task/fixing-mypy-issues-in-settings Fixing mypy issues in the settings.py file commit d3fef5dbc2deffbabf8cc1e98d0f45d54a530c0b Author: David van Buiten <[email protected]> Date: Fri Oct 13 09:54:41 2023 +0200 Fixed flake8 issue commit 7b347740c7d1c41df4cdc72350076046d3931746 Author: David van Buiten <[email protected]> Date: Fri Oct 13 09:43:38 2023 +0200 Fixing mypy issues in the settings.py file commit 7413a361888ee8da858a156c7a5c60d75c8da15f Author: Youri Westerman <[email protected]> Date: Thu Oct 12 17:17:01 2023 +0200 Solve mypy issues my signals (#1387) * Use lazy function instead of lazy attribute since we don't use the object itself to generate the email address * Replace setting boolean attribute with decorator * Assert that we're getting from the context what we're expecting * No longer magically assign urlpatterns property * Have both serializers share code by means of an abstract class instead of having one extending the other * Abstract class cannot inherit from derived class * Format is optional * Update baseline commit 2ddcf3c8faaf2073aab78df471723d213a33f3de Merge: 7e5a3230 6c253627 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:52:15 2023 +0200 Merge pull request #1386 from Amsterdam/task/cleanup-requirements Cleanup of requirements in files commit 6c253627472ad89b81ee57057c7d4d4f420662d2 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:20:32 2023 +0200 Cleanup of requirements in files commit 7e5a32308b56fb7ba54246d919b8d1bfab00488f Merge: d7390113 327d1970 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:32:42 2023 +0200 Merge pull request #1385 from Amsterdam/task/refactor-settings Refactored the settings folder into a single settings.py file commit 327d1970ee6050661f0d9cd3c8c337913a1d365c Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:22:51 2023 +0200 Added missing newlines commit 532549ad55f8b8be18bf96c28f01f5769f73932f Author: David van Buiten <[email protected]> Date: Thu Oct 12 09:35:03 2023 +0200 Refactored the settings folder into a single settings.py file, updated the documentation. commit d739011357fd2d9c4488aabfb8beec63d83dfe72 Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:59:37 2023 +0200 Add factory boy stub package (#1384) * Add stubs package for factory-boy package * Update mypy baseline commit e933f1a8246ae070206cbd45fd88fe7b6ed3cde5 Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:25:20 2023 +0200 Add stubs package for django filters (#1383) * Upgrade dependencies and install stub package for django-filter * Update mypy baseline commit eb0fd1a7e3dcea7305a69d900a43474a4ce7aaaf Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:15:42 2023 +0200 Always create a new token and delete the old ones when a new token is requested (#1382) commit f0e71b28766b3afabac04055ca99c3f51a551350 Merge: cfcfd941 03676ed2 Author: David van Buiten <[email protected]> Date: Mon Oct 9 12:21:01 2023 +0200 Merge pull request #1381 from Amsterdam/task/add-stubs-for-mypy Added stubs for improved type checking as suggested by mypy commit 03676ed2e893c2f366fbd661d93b338c008e6083 Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:19:05 2023 +0200 Added types-psycopg2 commit 36f80bff9e484d9018c2072acbf3a9092bacd20b Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:16:00 2023 +0200 Added types-Pygments commit 2fc49b8ab14d78cdab95a94b605b36969016c3eb Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:00:22 2023 +0200 Added lxml-stubs + updated the mypy baseline commit c4079f4ce1e633968feda33458542435432f1091 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:55:56 2023 +0200 Added types-python-dateutil + updated the mypy baseline commit b6df8c359d16132183b6b68611986ed44b0b9a02 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:52:26 2023 +0200 Added types-Markdown + updated the mypy baseline commit c513b91000cbeafd8736657e9f079418090b2ad6 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:47:19 2023 +0200 Added types-Pillow + updated the mypy baseline commit 662a2cd21b387ac323da61d6d3a79a9b6e9267af Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:43:38 2023 +0200 Added types-jsonschema + updated the mypy baseline commit 9bc5bacd2a452260ff8cb6d6e87038a4b7d78d60 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:31:45 2023 +0200 Added types-beautifulsoup4 + updated the mypy baseline commit cfcfd941cc24a4403dabe7a106af8bae755e3f3e Merge: 7b96a434 7bb4b7b0 Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:58:38 2023 +0200 Merge pull request #1380 from Amsterdam/task/add-mypy-djangorestframework-stubs Added the djangorestframework-stubs mypy plugin commit 7bb4b7b0a255ef59469139554c0366ae60a3c24d Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:49:27 2023 +0200 Added the djangorestframework-stubs mypy plugin commit 7b96a4342fb7549ff239efe5b3a436fe4a07de6a Merge: 002dc83f 84370852 Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:36:58 2023 +0200 Merge pull request #1379 from Amsterdam/task/add-mypy-django-stubs Added the django-stubs mypy plugin commit 84370852d3d3391f56fb070589af3b504abaed36 Author: David van Buiten <[email protected]> Date: Fri Oct 6 10:32:45 2023 +0200 Synced mypy baseline commit 5204bc9c5474d9d091d6eadb84cb58f9b1028e19 Author: David van Buiten <[email protected]> Date: Fri Oct 6 09:48:22 2023 +0200 Added the django-stubs mypy plugin commit 002dc83f648a4ba4b78b428f5c3df26376c2523f Author: Youri Westerman <[email protected]> Date: Tue Oct 3 11:55:22 2023 +0200 Install mypy (#1377) * Upgrade dependencies and install mypy and mypy-baseline * Add mypy baseline * Run mypy using tox * Add mypy step to ci commit 0fa3385acdc859fca9a06bbec69f1b49319862b6 Author: Youri Westerman <[email protected]> Date: Tue Oct 3 11:09:57 2023 +0200 Upgrade dependencies (#1378) * Update dependencies * Use the right list index in test commit 47c79b03cc7f0ed3acb765c33a5e72abd0b2274f Author: Youri Westerman <[email protected]> Date: Mon Oct 2 14:43:24 2023 +0200 Use docker-compose in ci (#1376) commit 9108e00cf7ad31d1a2cb1a182a193a214823cd80 Author: Youri Westerman <[email protected]> Date: Mon Oct 2 13:28:50 2023 +0200 Add test container build stage (#1375) * Add test build stage * Add docker-compose file for test environment commit dd4a3adc8147a0ebfec45c13e243feb6dc8b9d7f Author: Youri Westerman <[email protected]> Date: Mon Sep 25 09:32:44 2023 +0200 Bump version commit 191d10dee63f5ffa2ed019a86bf04b67ace8ed55 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:45:44 2023 +0200 Bumped API version to 2.31.0-beta.1 commit 16ced0105dbd599641527f4b114af3b7081e1dc5 Merge: e913c9c3 9a6f5b15 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:44:57 2023 +0200 Merge pull request #1374 from Amsterdam/fix/azure-cannot-overwrite-translations-file Delete translation file before uploading the updated version commit 9a6f5b15495b793f7afaa5f4fd69ac119b7be4a0 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:34:49 2023 +0200 Due to Azure's limitations, we are unable to overwrite the translation file directly. To work around this, we delete the existing file before uploading the updated version. commit e913c9c3dc575ffcedd2573a25efeb05b14c97b5 Author: Youri Westerman <[email protected]> Date: Wed Sep 20 14:02:16 2023 +0200 Bump version commit edd4e69441c69b4c944da7a81d0a3c113b6e0c9f Merge: 68335b63 c00c0bd6 Author: David van Buiten <[email protected]> Date: Wed Sep 20 13:56:10 2023 +0200 Merge pull request #1372 from Amsterdam/feature/public-and-private-endpoints-for-i18next-translation-file Added I18Next translation file creation (private) and retrieval (public) views commit c00c0bd6c0fb72e2268bc28fd7bab8c50b60d108 Author: David van Buiten <[email protected]> Date: Wed Sep 20 13:44:35 2023 +0200 Use TemporaryDirectory as a context manager when testing the translation file endpoints. commit 68335b63f741f9ebf6e75df56fc6e912f0f770ea Author: Youri Westerman <[email protected]> Date: Wed Sep 20 11:57:54 2023 +0200 Enable sorting search results by date (#1373) * Return all documents when no term is provided (previous implementation was broken) * Add ordering parameter * Provide OpenApi spec commit 6ef56b0a59bee49057e9e9ca99ae412f9d5906df Author: David van Buiten <[email protected]> Date: Wed Sep 20 11:03:49 2023 +0200 Renamed the Permission "add_i18next_translation_file" to "sia_add_i18next_translation_file" commit 8847c92e5b717557c2f12ed5980e1cf3c8546fa7 Author: David van Buiten <[email protected]> Date: Wed Sep 20 10:21:03 2023 +0200 Added unit tests for the private and public translation endpoints commit 6974d1747fc8a807ec15fdaa1de184cfe9cf6084 Author: David van Buiten <[email protected]> Date: Tue Sep 19 11:24:41 2023 +0200 Instead of defining the variable `translation_filename` twice use a constant. The constant is named `I18NEXT_TRANSLATION_FILE_PATH` commit 98f48f2c25a46a5648f960a412161fb3fca0d6a0 Author: David van Buiten <[email protected]> Date: Tue Sep 19 11:23:44 2023 +0200 Use `path` instead of `re_path` when defining the route for the private translations endpoint commit de232986cbb47e18f708250dd341429887a4b6c8 Author: David van Buiten <[email protected]> Date: Tue Sep 19 09:30:07 2023 +0200 Added I18Next translation file creation (private) and retrieval (public) views - Added a `PrivateCreateI18NextTranslationFileView` class to create/update the I18Next translation file from JSON data - Added a `PublicRetrieveI18NextTranslationFileView` class to retrieve the latest I18Next translation file - Updated the `urls.py` file to include public and private endpoints for translation file management commit 5564c58b29977b5fb24cc672696bd3d8bf064eb3 Merge: b40708e5 ea1be444 Author: David van Buiten <[email protected]> Date: Mon Sep 18 14:57:15 2023 +0200 Merge pull request #1371 from Amsterdam/task/add-custom-permission-for-storing-18next-translation-file Introduce CustomPermission abstract class and sync_custom_permission function + custom i18next permission commit ea1be44469d40c0015860f7682726c367bc67dac Author: David van Buiten <[email protected]> Date: Mon Sep 18 14:48:22 2023 +0200 This commit adds a new abstract class, CustomPermission, essential for creating custom permissions independent of existing models, as Django auth Permissions necessitate a ContentType association. Additionally, a sync_custom_permission function is included, which responds to the DjangoSignal post_migrate, facilitating the creation of custom permissions if they do not already exist. commit b40708e54d68aeae45bc58f95dccf7f0cc11f683 Author: Youri Westerman <[email protected]> Date: Mon Sep 18 09:43:51 2023 +0200 Ignore dumps folder to save time/memory when building container images (#1370) commit fd018460d2ffceb7bfd6f22487b3accce6b2e6b1 Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:50:28 2023 +0200 Bumped API version to 2.30.7 commit be87aa0b1d112b5c261d280e2c334d2e72644059 Merge: 7a154bd8 9f0e006e Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:49:48 2023 +0200 Merge pull request #1369 from Amsterdam/fix/adding-note-must-update-the-signal-update_at When adding a Note, ensure that ONLY the 'updated_at' timestamp of a Signal is updated commit 9f0e006ea91dae5f8e7c96203809abd12fcc3449 Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:34:37 2023 +0200 Ensures that the 'updated_at' timestamp accurately reflects the most recent activity related to a Signal, without altering any other existing data. In commit 9dc54a1, the 'signal.save()' method was removed. However, this change affected the 'updated_at' timestamp used by the 'geen actie nodig' functionality on a parent Signal. commit 7a154bd8a252298040988a028ba96090017c109f Author: David van Buiten <[email protected]> Date: Thu Sep 14 14:51:46 2023 +0200 Bumped API version to 2.30.6 commit 834c8f521df749b917893a305765273eeedff8ed Merge: b91caa82 3c151a03 Author: David van Buiten <[email protected]> Date: Thu Sep 14 14:51:11 2023 +0200 Merge pull request #1368 from Amsterdam/bugfix/status-not-changing-to-reopened-opn-negative-feedback Don't save signal when creating a note as nothing has changed on the … commit 3c151a0356e665684f6a609c36512c672aa40252 Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:42:40 2023 +0200 Remove now unused variable from test commit e2e5c37d01c5c65c347280f36d4a501d4347a46e Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:40:53 2023 +0200 Remove assertion from test commit 9dc54a1190053d5be678e29d057ed6ef65b859c8 Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:28:29 2023 +0200 Don't save signal when creating a note as nothing has changed on the actual signal commit b91caa82f1504e988e61da7ac113309c5bc67301 Author: Bart <[email protected]> Date: Thu Sep 14 12:04:49 2023 +0200 Make status messages index configurable (#1367) commit 50249561b65b79abebc02b8936d6ce907ab30ab9 Author: David van Buiten <[email protected]> Date: Wed Sep 13 12:45:22 2023 +0200 Bumped API version to 2.30.5 commit 57b06a1008ea7f72910025d964d6c70ab47d2770 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:22:38 2023 +0200 Bumped API version to 2.30.5-beta.2 commit 47f649473b3da8f823d142de37f5400f1ed8809b Merge: eb3df0b4 e2c6099d Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:21:09 2023 +0200 Merge pull request #1366 from Amsterdam/task/fix-signals-celery-tasks-in-db-after-refactor Update Signals task references in the database after restructuring tasks commit e2c6099d08af41ac7eacd8eb8b0c3efafd177bc0 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:12:59 2023 +0200 Fixed flake8 issues commit 56c186358cfef2d4fadba202bf02a03dd3536547 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:03:14 2023 +0200 Fixed isort issues commit eb3df0b4dad24b0d327a37d721ae9f506353fa5a Author: Youri Westerman <[email protected]> Date: Wed Sep 13 10:02:07 2023 +0200 Bugfix/concurrency fault in public attachment uploading (#1365) * Add code to reproduce the problem * Don't acquire row lock for signal when creating notes commit 06cfe70ee0c0dc5aa0bb99438a147fe89b544b7c Author: David van Buiten <[email protected]> Date: Wed Sep 13 09:49:59 2023 +0200 This migration updates the Celery task references in the database to match the new folder structure for tasks. Previously, all tasks were located in a single tasks.py file, but they have now been refactored into individual files within a 'tasks' folder. The FORWARD_MAPPING and REVERSED_MAPPING dictionaries are used to map old task references to new ones. The migration script loops through these mappings, updating the task references in the 'PeriodicTask' model of the 'django_celery_beat' app. commit 83f84a759909cf9a284e404045221887c9362fb0 Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:29:49 2023 +0200 Bumped API version to 2.30.5-beta.1 commit a75aa7a86a7f03c88416d09f60e04953dfe03472 Merge: c91528db 04d355cd Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:28:47 2023 +0200 Merge pull request #1364 from Amsterdam/task/added-deleted-signals-admin-filter-option Added `date_hierarchy` to the DeletedSignalAdmin + us the admin.action decorator commit 04d355cd9b61df126c023715006f4f50e89864dc Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:18:15 2023 +0200 Added `date_hierarchy` to the DeletedSignalAdmin + us the admin.action decorator commit c91528db81e69700f832821797364e05925f1abc Author: David van Buiten <[email protected]> Date: Tue Sep 12 08:27:23 2023 +0200 Bumped API version to 2.30.5-beta.0 commit 7486262050650fa770718bc25f599c8847063c57 Merge: 9c64935a 2eb981d9 Author: David van Buiten <[email protected]> Date: Tue Sep 12 08:19:47 2023 +0200 Merge pull request #1363 from Amsterdam/task/delete-signals-celery-task Refactor the delete signal service so that it can trigger celery tasks per signal commit 9c64935acf1df096d49d0cc996d1300b36ccc395 Author: Youri Westerman <[email protected]> Date: Mon Sep 11 13:59:44 2023 +0200 Bunmp version commit 2d87e55bb117765d87f82cc0d5ec643484b70f1f Author: Bart <[email protected]> Date: Mon Sep 11 13:58:54 2023 +0200 Make status messages index configurable (#1362) commit 2eb981d9296e1069fa1b822dec6bd55e7c917fa4 Author: David van Buiten <[email protected]> Date: Thu Sep 7 15:21:09 2023 +0200 Refacored the SignalsDeleteService into 2 celery tasks. One for determining the signals that are in a state for more than X days and one for the deletion of a signal. commit 6d1db91b16c724df92de0167aaefaa3be7b4e89b Author: David van Buiten <[email protected]> Date: Thu Sep 7 14:30:45 2023 +0200 Removed the dry-run option. Moved delete from elastic to a Signal post_delete listener. Refactored valid_states into VALID_STATES and made it Final. commit b75cdaea7db9af4efd58fc6f99f0237d3c9035e4 Author: David van Buiten <[email protected]> Date: Thu Sep 7 08:30:34 2023 +0200 Fixed calling the DeleteSignalsService when deleting a child signal with the id of the Signal instead of the signal itself. Fixed isort issue commit dcf58b6118f463bbc9ea38093008f0522f687622 Author: David van Buiten <[email protected]> Date: Wed Sep 6 16:28:22 2023 +0200 Refactor 'SignalDeletionService' to enhance code structure and renamed to 'DeleteSignalsService', update code and tests accordingly. Kept the celery task 'delete_closed_signals' for backwards compatibility and added a deprecation warning. It's recommended to use 'delete_signals_in_state_for_x_days' instead. commit ed244bae615a7fcf9004a788d5b2d50e30161e13 Author: David van Buiten <[email protected]> Date: Mon Sep 4 13:56:05 2023 +0200 This commit splits the tasks in app/signals/apps/signals/tasks.py into separate files, making it easier to manage and maintain the code. commit 137f2230e4ca212e0a5747b448c05c9723f7a711 Author: Youri Westerman <[email protected]> Date: Mon Sep 4 13:45:22 2023 +0200 Use mailpit instead of mailhog (#1361) * Use mailpit instead of mailhog * Update mail host in env files * Add documentation about mailpit commit d131a7ccd3481deeac29b0d5afdd20336aed2e28 Author: Youri Westerman <[email protected]> Date: Mon Sep 4 09:16:04 2023 +0200 Bump version commit ccf906624865955a0763dff262846a56a8c16056 Author: Youri Westerman <[email protected]> Date: Fri Sep 1 09:14:06 2023 +0200 Bump version commit 3affc54d6050f8796ad16bb09a916e90d0486776 Author: Youri Westerman <[email protected]> Date: Fri Sep 1 09:12:38 2023 +0200 Provide signal context to reporter mail templates (#1360) commit 42102989c9a5b42c550fa192e6ce46a20c89b93b Author: Youri Westerman <[email protected]> Date: Thu Aug 31 13:15:55 2023 +0200 Refactor entrypoint script for dev environment (#1358)

commit 62c5cd240626c81c9cab25214523e5aae62dbe9a Author: David van Buiten <[email protected]> Date: Mon Feb 26 10:39:42 2024 +0100 Bumped version to 2.34.5-beta.1 commit 1cbb2c461f5403938776953ba82618ef339e26a5 Merge: 44d0298c ea8fd346 Author: David van Buiten <[email protected]> Date: Mon Feb 26 09:05:41 2024 +0100 Merge pull request #1438 from Amsterdam/chore/update-requirements Update requirements commit ea8fd3464482c6e27870b5cd35d157f7ab969c30 Author: David van Buiten <[email protected]> Date: Mon Feb 26 08:59:31 2024 +0100 Update requirements commit 44d0298cb4c2669b3c4685cade992e14bd1f36d1 Merge: 47c33363 1675d8f3 Author: David van Buiten <[email protected]> Date: Mon Feb 26 08:45:51 2024 +0100 Merge pull request #1437 from Amsterdam/dependabot/pip/app/requirements/cryptography-42.0.4 Bump cryptography from 42.0.2 to 42.0.4 in /app/requirements commit 1675d8f3374d91c8dc06de9559aa716f775c3842 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 21 20:44:21 2024 +0000 Bump cryptography from 42.0.2 to 42.0.4 in /app/requirements Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.2 to 42.0.4. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/42.0.2...42.0.4) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> commit 47c33363e8e31352efb3598282a1307eaec70663 Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:39:00 2024 +0100 Bumped version to 2.34.4 commit dd25b1cecac22986ab29b69de62b208658f22665 Merge: 735f745f 1e13a535 Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:37:27 2024 +0100 Merge pull request #1436 from Amsterdam/fix/maintenance-mode-exempt-health-check Exempt the health-check from the maintenance mode commit 1e13a535964242694ef15a1073be1891b5bb932b Author: David van Buiten <[email protected]> Date: Mon Feb 19 14:31:23 2024 +0100 Exempt the health-check from the maintenance mode commit 735f745f9a03f53c9565594b6825f1e6cfa24b3c Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:46:08 2024 +0100 Bumped version to 2.34.3 commit e9900dfcbfba733a5f49bfc16d7b5ff46e992b07 Merge: d441d765 d097c85c Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:43:46 2024 +0100 Merge pull request #1435 from Amsterdam/feature/maintenance-mode Added "Maintenance mode" commit d097c85c22b586d8a34480cc439df34b8f8450c9 Author: David van Buiten <[email protected]> Date: Mon Feb 19 13:35:53 2024 +0100 Added "Maintenance mode", by default this mode is disabled. It can be enabled/disabled by setting the env variable `MAINTENANCE_MODE` to `true` or `false`. commit d441d765e2dd6663e426336c425c1815ce013f0f Author: David van Buiten <[email protected]> Date: Mon Feb 12 08:58:27 2024 +0100 Bumped version to 2.34.2 commit 83345ddb209f77273e6505782d40dd15dd5acf0a Merge: cba36948 46495372 Author: David van Buiten <[email protected]> Date: Fri Feb 9 10:44:44 2024 +0100 Merge pull request #1434 from Amsterdam/chore/update-requirements Updated the requirements commit 46495372f2b3fc5187ff6e1be60ad638237e8f17 Author: David van Buiten <[email protected]> Date: Thu Feb 8 09:39:44 2024 +0100 Updated the requirements commit cba3694862d231fc922d3bf66ebb530fda3983f5 Merge: e7a3d332 5fe78a42 Author: David van Buiten <[email protected]> Date: Thu Feb 8 09:27:39 2024 +0100 Merge pull request #1433 from Amsterdam/dependabot/pip/app/requirements/django-3.2.24 Bump django from 3.2.23 to 3.2.24 in /app/requirements commit 5fe78a4246e5d5879c5f4614e38d4fa5759fb640 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Feb 7 22:56:54 2024 +0000 Bump django from 3.2.23 to 3.2.24 in /app/requirements Bumps [django](https://github.com/django/django) from 3.2.23 to 3.2.24. - [Commits](https://github.com/django/django/compare/3.2.23...3.2.24) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit e7a3d3328d1814880805afa1a80d841715d0f6f3 Author: David van Buiten <[email protected]> Date: Tue Jan 23 10:33:17 2024 +0100 Bumped version to 2.34.1 commit 0254a016dcf62891584db63b5ac8d78c7a73fdfc Merge: 45480673 a9178f33 Author: David van Buiten <[email protected]> Date: Tue Jan 23 10:29:57 2024 +0100 Merge pull request #1432 from Amsterdam/chore/update-requirements Update project dependencies commit a9178f33e6da7ac8a22bc4055b45012210eea3df Author: David van Buiten <[email protected]> Date: Mon Jan 22 14:48:45 2024 +0100 Update project dependencies commit 45480673079060e8b1cd6427fe6cf1938e7f4aa0 Merge: a54fbf5c 735e8558 Author: David van Buiten <[email protected]> Date: Mon Jan 22 08:48:49 2024 +0100 Merge pull request #1417 from delta10/elasticsearch-timeout-pr Add configurable timeout to search app commit 735e8558b44b9a2b431a6bc3813442495b9a6066 Author: Lennart Ackermans <[email protected]> Date: Tue Nov 14 17:15:01 2023 +0100 Add configurable timeout to search app Revert "Add configurable timeout to search app" This reverts commit c1ed0946ac8929a357866ad36389274a4e5174f6. Add configurable timeout to search app (corrected) fix ELASTICSEARCH_TIMEOUT type error commit a54fbf5c7753b5b3b00ff68af66ed1caac855318 Author: David van Buiten <[email protected]> Date: Thu Jan 18 14:07:41 2024 +0100 Bumped version to 2.34.0 commit 3800886a8158f612c1540b60962929ce65983931 Author: Youri Westerman <[email protected]> Date: Tue Jan 9 12:05:15 2024 +0100 Bump version commit f2aad9cd02d680321ee25d6fddbcfe9f945624f4 Author: Youri Westerman <[email protected]> Date: Tue Jan 9 12:04:34 2024 +0100 Use database cache backend (#1431) * Use database cache backend by default * Create cache table in init script commit 9105c7b27c388436b13cb7a3b7dbe356f71d782e Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:16:49 2024 +0100 Bumped API version to 2.34.0-beta.6 commit 23d22ff3736894833807039f5b336b78268777c3 Merge: edf4c374 f01adad0 Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:14:01 2024 +0100 Merge pull request #1430 from Amsterdam/chore/throttling-ident-fix Throttling ident fix commit f01adad013f85dca4c57c9495ada7bb72a8ada18 Author: David van Buiten <[email protected]> Date: Mon Jan 8 16:09:03 2024 +0100 In this commit the `get_ident` method, in the `PostOnlyNoUserRateThrottle` class, is updated to ensure that the identification string is stripped of the colon and port number commit edf4c374afa370e0c094b9f64df5c160ea899b85 Author: Youri Westerman <[email protected]> Date: Mon Jan 8 15:14:32 2024 +0100 Bump version commit 82b3d5c7cc7b54c5f231e37a6a5eb92d5e7d80b6 Author: Youri Westerman <[email protected]> Date: Mon Jan 8 14:56:45 2024 +0100 Throttling not working correctly (#1429) * Add caddy to dev setup * Log throttle result commit 72fe74e6a4a634263f39cc6a743a56b3a2a6b97d Author: Youri Westerman <[email protected]> Date: Thu Jan 4 11:46:00 2024 +0100 bump version commit 8cbe1036e5cc5e4e6717941267d31e15feba3271 Author: Youri Westerman <[email protected]> Date: Thu Jan 4 11:30:17 2024 +0100 Update dependencies (#1428) * Update dependencies * Ignore mypy false positive commit 9aa5e3e12afbf8ee3952dd3d02fe72b3e80d8962 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 4 10:37:07 2024 +0100 Bump jwcrypto from 1.5.0 to 1.5.1 in /app/requirements (#1427) Bumps [jwcrypto](https://github.com/latchset/jwcrypto) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/latchset/jwcrypto/releases) - [Commits](https://github.com/latchset/jwcrypto/compare/v1.5.0...v1.5.1) --- updated-dependencies: - dependency-name: jwcrypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 68dabe2438a68dd654097c2580cc5722dad0079a Author: Bart <[email protected]> Date: Tue Dec 12 12:57:39 2023 +0100 fix: do not include full name in e-mail notification for assigned action (#1416) commit 63198f03c0ddb46f7223d166c8a0248dacb0b2a1 Author: Bart <[email protected]> Date: Tue Dec 12 09:47:42 2023 +0100 Make O365_MAIL_SAVE_TO_SENT configurable (#1357) commit 2c247cba6a8fead8ae3f8b7bc129108f58ada77c Author: Youri Westerman <[email protected]> Date: Mon Dec 11 13:20:24 2023 +0100 Use typed drf amsterdam package (#1418) * Add type to serializer property * Add type annotation for _display property * Add type annotation to _display property * Refactor CategoryHyperlinkedIdentityField and PrivateCategoryHyperlinkedIdentityField to be based on LinksField as is specified in the HALSerializer * Have PrivateSignalLinksField extend LinksField instead of HyperLinkedIdentityField * Have PublicSignalLinksField extend LinksField instead of HyperLinkedIdentityField * Have PrivateSignalLinksFieldWithArchives extend LinksField instead of HyperLinkedIdentityField * Have StoredSignalFilterLinksField extend LinksField instead of HyperLinkedIdentityField * Have QuestionnairePublicHyperlinkedIdentityField extend LinksField instead of HyperLinkedIdentityField * Have SessionPublicLinksField extend LinksField instead of HyperLinkedIdentityField * Have UserHyperlinkedIdentityField extend LinksField instead of HyperLinkedIdentityField * Have PrivateSignalAttachmentLinksField extend LinksField instead of HyperLinkedIdentityField * Have PublicSignalAttachmentLinksField extend LinksField instead of HyperLinkedIdentityField * Havee PrivateSignalWithContextLinksField extend LinksField instead of HyperLinkedIdentityField * Have MySignalDetailLinksField extend LinksField instead of HyperLinkedIdentityField * Have MySignalListLinksField extend LinksField instead of HyperlinkedIdentityField * Have EmptyHyperlinkedIdentityField extend LinksField instead of HyperlinkedIdentityField * Replace mixin with base class * Sync mypy baseline * Small optimization of container build process * Update dependencies * Specify view_name as is required by stubs package commit c2602a574f53225c4dc1259563ee2962e71aff77 Merge: 6821e254 6aa95d69 Author: David van Buiten <[email protected]> Date: Wed Dec 6 09:59:54 2023 +0100 Merge pull request #1426 from Amsterdam/chore/update-github-workflow-build_and_push_to_docker_hub Improve Docker image build and push workflow commit 6aa95d6924c5e197948e227545f7970bbaf9dcd2 Author: David van Buiten <[email protected]> Date: Tue Dec 5 11:48:18 2023 +0100 Improve Docker image build and push workflow - Update actions/checkout to v4 - Use the docker/login-action for logging into Docker Hub - Docker meta extraction with docker/metadata-action v5 - Docker image build and push with docker/build-push-action v5 - Generate 'latest' tag for releases commit 6821e254c8d445757c2f80680ee0cc993dccc599 Merge: 363a0a78 8ad2c57d Author: David van Buiten <[email protected]> Date: Tue Dec 5 10:03:37 2023 +0100 Merge pull request #1425 from Amsterdam/chore/update-github-action-ci Update github action checkout from v3 to v4 for the ci workflow commit 8ad2c57d99203a306b9ba245401b203ad7f837ce Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:55:59 2023 +0100 Update github action checkout from v3 to v4 for the ci workflow commit 363a0a7880733448e020a4e4a3f453a1bb94d772 Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:23:53 2023 +0100 Bumped API version to 2.34.0-beta.3 commit 4844f440663de6aa53d8597058b8c752e8bccc87 Merge: 39614534 13949d73 Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:22:26 2023 +0100 Merge pull request #1424 from Amsterdam/chore/fix-questionnaires-information-exposure Fixed: Information exposure through an exception commit 13949d7332aa0e7ce36ccce658dc501c9ad751ac Author: David van Buiten <[email protected]> Date: Tue Dec 5 09:15:16 2023 +0100 Fixed: Information exposure through an exception commit 39614534f8c221c05873a6d69202285abbf5bb93 Author: David van Buiten <[email protected]> Date: Tue Dec 5 08:42:41 2023 +0100 Bumped API version to 2.34.0-beta.2 commit c903d417ba9da9aae33d99201ea0765e63cd9df9 Merge: 7ba25299 28e30fd7 Author: David van Buiten <[email protected]> Date: Mon Dec 4 16:16:00 2023 +0100 Merge pull request #1423 from Amsterdam/chore/fix-sigmax-XXE-issue Sigmax, fix for XML external entity expansion commit 28e30fd705fed98c0fe81ab8f60acb69d8e3acfd Author: David van Buiten <[email protected]> Date: Mon Dec 4 15:51:20 2023 +0100 Removed `no_network=True`, `True` is the defaul. Updated SPDX headers. Added unit test and XXE test file. commit bb14b820974647f2af15f389f58985241f9e9ac8 Author: David van Buiten <[email protected]> Date: Mon Dec 4 15:02:49 2023 +0100 The lxml `etree.fromstring()` function has a security risk of XXE attacks. A custom XML parser is now used that disables resolving entities and blocks network access. commit 7ba25299fe84baa276646e69c564e2412f026f77 Author: David van Buiten <[email protected]> Date: Wed Nov 29 13:12:18 2023 +0100 Bumped API version to 2.34.0-beta.1 commit 6cb99d96b50afb13bd1bdfb4960bda823f41e47a Merge: bee5f33d e0a625a7 Author: David van Buiten <[email protected]> Date: Wed Nov 29 13:07:55 2023 +0100 Merge pull request #1422 from Amsterdam/chore/update-requirements Updated requirements commit e0a625a72b25eade4408b33f05c133b825f5af9d Merge: 32400f38 bee5f33d Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:56:30 2023 +0100 Merge branch 'main' into chore/update-requirements commit bee5f33d52753e2ad44f122f8c82c46cebd0f844 Merge: 14ddc6a0 fe1de896 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:55:03 2023 +0100 Merge pull request #1420 from Amsterdam/dependabot/pip/app/requirements/pypdf-3.17.0 Bump pypdf from 3.16.4 to 3.17.0 in /app/requirements commit 32400f38dc310c87469d6073c092bb5f38b9d41c Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:47:12 2023 +0100 Updated requirements commit fe1de896d12d209ab1675f85d8f3fedb60903d2f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 11:43:08 2023 +0000 Bump pypdf from 3.16.4 to 3.17.0 in /app/requirements Bumps [pypdf](https://github.com/py-pdf/pypdf) from 3.16.4 to 3.17.0. - [Release notes](https://github.com/py-pdf/pypdf/releases) - [Changelog](https://github.com/py-pdf/pypdf/blob/main/CHANGELOG.md) - [Commits](https://github.com/py-pdf/pypdf/compare/3.16.4...3.17.0) --- updated-dependencies: - dependency-name: pypdf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit 14ddc6a03a5c5b5f39ad92e2e20354f5337485fa Merge: 3bda303e eda8c352 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:49:38 2023 +0100 Merge pull request #1421 from Amsterdam/dependabot/pip/app/requirements/django-3.2.23 Bump django from 3.2.22 to 3.2.23 in /app/requirements commit eda8c352fd8f8c4ae37fccd9ea8d34c625e35508 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 11:43:13 2023 +0000 Bump django from 3.2.22 to 3.2.23 in /app/requirements Bumps [django](https://github.com/django/django) from 3.2.22 to 3.2.23. - [Commits](https://github.com/django/django/compare/3.2.22...3.2.23) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> commit 3bda303e39ebeb5f130bf30595db5f3d911f7f7f Merge: 076cb496 370d90c4 Author: David van Buiten <[email protected]> Date: Wed Nov 29 12:40:47 2023 +0100 Merge pull request #1419 from Amsterdam/dependabot/pip/app/requirements/cryptography-41.0.6 Bump cryptography from 41.0.5 to 41.0.6 in /app/requirements commit 370d90c43d855b2c62dc1ee7fe7bf6e71bb5535e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 29 00:26:54 2023 +0000 Bump cryptography from 41.0.5 to 41.0.6 in /app/requirements Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.5 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.5...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> commit 076cb496edad550e870c91a4af4e927ff4686c7b Author: David van Buiten <[email protected]> Date: Mon Nov 13 10:12:31 2023 +0100 Bumped API version to 2.33.0 commit 75d8271bb4d26e713d48f927348c35a9914b0aad Author: David van Buiten <[email protected]> Date: Mon Nov 6 09:06:39 2023 +0100 Bumped API version to 2.33.0-beta.1 commit 99650ec079cb58ae79b235c5dc6a2f74fa720b6b Merge: 4d1ef63c 91b2b126 Author: David van Buiten <[email protected]> Date: Wed Nov 1 12:58:08 2023 +0100 Merge pull request #1415 from Amsterdam/feature/attachtment-permissions Added new attachment permissions commit 91b2b12608c9a9d693f6a0e6355d4011354ba560 Author: David van Buiten <[email protected]> Date: Mon Oct 30 16:24:53 2023 +0100 Added the SIAAttachmentPermissions and implemented this permission in the PrivateSignalAttachmentsViewSet + updated and added unit tests commit 0db79d2d7d04e04dda53cae45195074aca8ffeb2 Author: David van Buiten <[email protected]> Date: Mon Oct 30 16:23:56 2023 +0100 Added 2 permissions to the Attachement model + updated tests commit 4d1ef63cee808b6bf06d78848d512e38bad8104a Merge: 8468b43d 8c5ff688 Author: David van Buiten <[email protected]> Date: Wed Oct 25 15:49:12 2023 +0200 Merge pull request #1414 from Amsterdam/chore/add-oidc-create-user-setting Added the `OIDC_CREATE_USER` setting to prevent user creation by the `mozilla-django-oidc` package commit 8c5ff6886b07b9920c85cdbbca57dd087c2a9377 Author: David van Buiten <[email protected]> Date: Wed Oct 25 13:08:08 2023 +0200 Added the `OIDC_CREATE_USER` setting (set to `False`) to prevent user creation. This commits also removes the custom code that was created to prevent this behaviour. This change is made in accordance with the `mozilla-django-oidc` the documentation. commit 8468b43d46d89f1bb0bb082412220fea799b9852 Merge: f3d8636a 5237c33f Author: David van Buiten <[email protected]> Date: Wed Oct 25 15:30:25 2023 +0200 Merge pull request #1413 from Amsterdam/chore/remove-unused-authorization_django-package Removed unused `datapunt-authorization-django` package commit 5237c33f92c800ec51869386fdefbf2a552b839b Author: David van Buiten <[email protected]> Date: Wed Oct 25 11:46:52 2023 +0200 Removed unused authorization_django package commit f3d8636a4a1de4622b0358039836a5fe69157610 Author: Youri Westerman <[email protected]> Date: Wed Oct 25 14:47:21 2023 +0200 Bump version commit c7ae8d970bae0a85cb26e8d154ababe20b7224db Author: Youri Westerman <[email protected]> Date: Wed Oct 25 10:17:33 2023 +0200 Bump Version commit 1545d2542a966af2eb284e021990da93e5509159 Author: Youri Westerman <[email protected]> Date: Wed Oct 25 10:01:29 2023 +0200 Move asserts to the lines where they are required (#1411) * Move asserts to the lines where they are required * Correct the return type of get_description() commit 9b1b39aafac27b9a6deb0031bff41cff12a0cf55 Author: Youri Westerman <[email protected]> Date: Tue Oct 24 12:11:02 2023 +0200 Solve mypy issues services (#1410) * Assert that filename exists * Add some typing info to DslService * Add asserts and type for property * Satisfy isort * Refactor logic to get expression and expression type from query params * Sync mypy baseline commit 5fad6ed8f319eddec07aefc42628beb47586cdc2 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:54:56 2023 +0200 Bumped API version to 2.32.1-beta.1 commit 2d6ea8becd97b484cd6810a2a02a1bbb7c5b6b28 Merge: 88409570 736ee193 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:42:51 2023 +0200 Merge pull request #1409 from Amsterdam/chore/solve-mypy-issues-email_integrations Solve mypy issues email_integrations commit 736ee19378aacf2ed917297d1c9bf52a8cb4c8a3 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:34:18 2023 +0200 Refactored deprecated typing.Union in email_integrations commit 94c8acd8dda09f7cf6288df533700d8791ab30e9 Author: David van Buiten <[email protected]> Date: Tue Oct 24 10:27:28 2023 +0200 Solve mypy issues email_integrations commit 88409570cd5106fbae09d6ba94e5521e2ba761d8 Merge: e7d00a32 68f1a003 Author: David van Buiten <[email protected]> Date: Tue Oct 24 09:36:56 2023 +0200 Merge pull request #1408 from Amsterdam/chore/refactor-oidc-admin Small refactor of the OIDC admin commit 68f1a003912cc5bc21597dbbae2b6685b66b5cb2 Author: David van Buiten <[email protected]> Date: Tue Oct 24 09:20:37 2023 +0200 Small refactor of the OIDC admin - Removed the `views.py` and now use the TemplateView for the url path `signals/oidc/login_failure/` - Removed the `update_user` method of the `AuthenticationBackend`. It is already defined (the same way) in the mozilla_django_oidc `OIDCAuthenticationBackend` - Added tests to get 100% coverage commit e7d00a32a35591040d92704e16139b6eb2e207e6 Author: Youri Westerman <[email protected]> Date: Tue Oct 24 09:29:08 2023 +0200 Add networkx stubs (#1407) * Install networkx-stubs * Sync mypy baseline commit 970e510c596efb309255e3cc01f0398452e363a7 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 17:06:08 2023 +0200 Add celery types (#1406) * Alphabetically order test dependencies * Install celery types package * Use correct argument name for celery task priority * Sync mypy baseline commit 0c4928cbd072dd90a7cb358c427c4da067aaecfa Author: Youri Westerman <[email protected]> Date: Mon Oct 23 16:54:43 2023 +0200 Have JWTAuthBackend extend BaseAuthentication (#1405) * Have JWTAuthBackend extend BaseAuthentication * Sync mypy baseline * Move docs inside method * Fix broken test commit 1bd2ad732cb465ca02149031b66a7398fac6abf2 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 16:10:59 2023 +0200 Solve mypy issues api (#1404) * Add type to property address_validation_url * Remove type declaration as it is currently not possible to specify the correct one * Add None asserts * Raise validation error if token does not have expiry date time * Raise exception when permission is used with unsupported view * Assert that request returned from context is a Request * Prevent circular reference by importing inside method * Correct return type and explicitly return None * Add return type * Assert that there is an old reporter * Assert we actually get a Request object from the context and raise exception if passed model is not an Attachment * Assert that we're getting the objects that we're expecting * Add exception to be raised when we don not get the correct model type * Convert mixin into Base class, the mixin was refering to self.context which it did not have * Use correct return types and import timedelta() from the right module * Use the correct argument types for has_permission() override * Use the correct return type * Correct the return type of get_category_names() * Use correct argument type of overriden perform_update() as it should be contravariant * Use list instead of tuple for authentication_classes property * Satisfy isort * Use the correct amount of empty lines between classes * Use list instead of tuple for authentication_classes * Declare headers as empty dict instead of list * Use AbstractUser instead of User, define dict shape, make sure we can assign None to arguments and assert that the signal reporter exists * Add urlpatterns property * Use list instead of tuple for authentication_classes * Make arguments nullable * Add property types * Give freeze_time() the float that it requires * Provide mute_signals() decorator with (Django) Signals instead of strings * Replace return type with AbstractUser * Sync mypy baseline commit bd057299a21c994e8aa66e6b7c8e07ac545c7c05 Merge: 3669aaa6 c508cb8d Author: David van Buiten <[email protected]> Date: Mon Oct 23 15:36:25 2023 +0200 Merge pull request #1403 from Amsterdam/chore/refactor-log-app Moved logging to the settings and removed the logs "app" commit c508cb8d4ed5c93bcdf3cfe4a85c62b1503e80fa Author: David van Buiten <[email protected]> Date: Mon Oct 23 15:28:25 2023 +0200 Moved logging to the settings and removed the logs "app" commit 3669aaa69ba4f048b31ac72d97452ae3b214db97 Merge: 0b5f10bb ec7a5128 Author: David van Buiten <[email protected]> Date: Mon Oct 23 14:07:27 2023 +0200 Merge pull request #1402 from Amsterdam/chore/solve-mypy-issues-questionnaires Solve mypy issues questionnaires commit ec7a51282e93c25525de9348d92e703ce4366919 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:57:11 2023 +0200 Fixed isort issues commit db5b22f64b627304624f68b7372c351e84ba3173 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:44:17 2023 +0200 Synced baseline commit c90fb70062569ec7f376b731c8f65ae40608fa85 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:38:12 2023 +0200 Solved fieldtypes mypy issues commit b8cfc6c2e65ff1118b2d55437269439ac58c4fc8 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:28:17 2023 +0200 Solved (most) admin mypy issues commit 27cfeaa442a594a46640eaa605c161a8fc968e4c Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:06:36 2023 +0200 Solved factories mypy issues commit 5bd594edd445f0310dd31902d85e9a4a261a6ec7 Author: David van Buiten <[email protected]> Date: Mon Oct 23 13:04:00 2023 +0200 Solved NameSpace urlpatterns mypy issue commit 0b5f10bb1fd3750596b3695533de4b4d4e948867 Author: Youri Westerman <[email protected]> Date: Mon Oct 23 11:48:39 2023 +0200 Update dependencies (#1401) * Update dependencies * Sync mypy baseline commit 2eedbf12b96aa3a00b269f3b70047c56a30c3cad Author: David van Buiten <[email protected]> Date: Mon Oct 23 09:25:20 2023 +0200 Bumped API version to 2.32.0 commit ceadf9636e88096f75adf02e61e0eebae65d9081 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:56:47 2023 +0200 Bumped API version to 2.32.0-beta.4 commit 5d9c4a46cc688e8bee0accd877a4d79e218dd16e Merge: 6266713b acf2799c Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:51:34 2023 +0200 Merge pull request #1400 from Amsterdam/chore/solve-mypy-issues-signals Chore/solve mypy issues signals commit acf2799c28bde21b23f302ff3009861c39a10e7f Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:44:33 2023 +0200 Removed redundant check commit 1a91792a2b0e8fff1aa2cff9d54d17a7c66c3f08 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:31:53 2023 +0200 Sync baseline commit 98cd54f8c2cebde30c9f58b0b660dfacf1c0fb0e Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:29:27 2023 +0200 Fixed flake8 issues commit 7291b417c19b60ebd122e78751dc8ecc188dcd03 Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:14:56 2023 +0200 Solved mypy issues in reporter model commit 61e756c5032ada1085ce93450a2c7b12c983a77c Author: David van Buiten <[email protected]> Date: Fri Oct 20 11:13:07 2023 +0200 Solved mypy issues in status message model commit 616a6b7fecf8c0eef3016baa1ea7e4d64d453850 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:43:54 2023 +0200 Solved mypy issues in category model commit 3d31b53e8c248747ad717d125e6f8f538fed6a89 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:43:13 2023 +0200 The setting API_MAX_UPLOAD_SIZE should always be an integer commit a9382899b643ab588169b0eb684a998ea264f8a9 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:39:13 2023 +0200 Solved mypy issues in deleted signals model commit 65cf9494ead8a8c6464b7e814e11acb48ee37031 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:30:47 2023 +0200 Solved mypy issues in signals migration 0046. Skip type check for AutoSlugField from the django_extensions plugin. commit a696c7f0713232e4059b77f098ecdf1eca96d986 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:29:59 2023 +0200 Solved mypy issues in signals migration 0159. As the migrations are not reversable the fake lambda reverse code has been removed. commit f85843e236e0f3bf05df6b26f7cb35eba6247ca7 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:23:42 2023 +0200 Solved mypy issues in signals migration 0138. The code stated a reverse is not possible, therefore removed the fake lambda reverse code. commit d79b4a081a42cb746386ab57142d33e538237ab3 Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:02:00 2023 +0200 Solved mypy issues in signals scenarios context commit 7101c34a4a76b23a5816741e21614c7f10a7b9ce Author: David van Buiten <[email protected]> Date: Fri Oct 20 09:00:09 2023 +0200 Solved mypy issues in deleted signals admin commit 22a93bf05c3317daf3b6c572db18c218bffbea24 Author: David van Buiten <[email protected]> Date: Fri Oct 20 08:56:49 2023 +0200 Solved mypy issues in delete signals task commit 3dd67ea709c9729212af9035125007255aa2c283 Author: David van Buiten <[email protected]> Date: Fri Oct 20 08:48:04 2023 +0200 Solved mypy issues in signals admin commit 12632546031f136a00479297daea7da46be0086b Author: David van Buiten <[email protected]> Date: Thu Oct 19 11:41:56 2023 +0200 Solved mypy issues in signals factories commit 6266713bdbb35d2b1efaf03e1e3957ae5cc7d70c Author: Youri Westerman <[email protected]> Date: Thu Oct 19 08:43:10 2023 +0200 Solve mypy issues user (#1399) * Correct types for profile serializer * Resolve type issues with user factory * Use decorator in admin instead of short_description and no longer functioning allow_tags properties * Update copyright * Add return type to function * Add return type to function * Use list instead of tuple * Sync baseline commit 34b61cdfd992e339db054bc6c8cf34bdd203a609 Merge: 92ee3db1 c5047411 Author: David van Buiten <[email protected]> Date: Wed Oct 18 15:05:21 2023 +0200 Merge pull request #1397 from Amsterdam/chore/solve-mypy-issues-history Solve mypy issues history app commit c5047411aa522f476345ea7eeea3db731e309fb9 Author: David van Buiten <[email protected]> Date: Wed Oct 18 14:50:42 2023 +0200 Add assertion on self.object in the 'translate_content_type' and 'get_description' methods on the Log model commit 98d58ffe22c11f9b7cc22eadaf382e761d3cfb11 Author: David van Buiten <[email protected]> Date: Wed Oct 18 14:40:58 2023 +0200 Add assertion on self.object in the 'get_action' method on the Log model commit 68e883344e6d0c851f6ba2657e4362bef5d006ef Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:56:13 2023 +0200 Sync baseline commit bfa7121ca1a344a6cbc02e7039c7d19f3e596432 Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:55:46 2023 +0200 Resolved mypy issues in the history app commit 92ee3db11fe7a981e4ae9a1976568ea9c78aadf0 Author: Youri Westerman <[email protected]> Date: Wed Oct 18 14:52:43 2023 +0200 Solve mypy issues reporting (#1398) * Correct type hint for path parameter * Correct types in serializer * Use list instead of tuple * Correct types for task save_csv_file_datawarehouse * Correct types in tasks * Add property definition * Sync baseline commit 1581bef908ea5b70e890c06eac7190d742e04fae Merge: b75decaf ab819279 Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:26:25 2023 +0200 Merge pull request #1396 from Amsterdam/chore/solve-mypy-issues-feedback Solve mypy issues feedback commit ab819279b24371d89d537d67a6d56bd7baba0d3f Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:15:10 2023 +0200 Sync baseline commit 4f2711a73cf364dcc1f3b08c638b320d0f48ab9c Author: David van Buiten <[email protected]> Date: Wed Oct 18 13:14:49 2023 +0200 Resolved mypy issues in the feedback app commit b75decafb886a3153f8978ddfc638f74c5fb7824 Author: Youri Westerman <[email protected]> Date: Wed Oct 18 13:05:03 2023 +0200 Solve mypy issues sigmax (#1395) * Add types * Add type to property * Use list instead of tuple * Assert status is not None, log exception and convert minutes to float * Resolve mypy issues in tests * Make check type friendlier * Sync baseline commit 16e8b657c6c9b8a6c78e93e8edb7937ad0f4ba83 Author: Youri Westerman <[email protected]> Date: Tue Oct 17 15:03:36 2023 +0200 Solve mypy issues search (#1394) * Declare authentication classes as list * Don't use list serializer, but use the "many" parameter * Sync baseline commit 9491aa7a94b0c9d21992ceed69d219afee021988 Author: Youri Westerman <[email protected]> Date: Tue Oct 17 14:37:46 2023 +0200 Limit elasticsearch heap to 4gb (#1393) commit 076feab2531cfe354532e4552bb63bcdc166532d Author: David van Buiten <[email protected]> Date: Tue Oct 17 14:15:09 2023 +0200 Bumped API version to 2.32.0-beta.3 commit 3166802585598c0271fd56169e5d52c425a1d60e Author: Youri Westerman <[email protected]> Date: Tue Oct 17 12:48:58 2023 +0200 Solve mypy issues dataset (#1392) * Define types in area loaders * Add type for DATASET_INFO and make sure PROVIDES gets the desired type by converting dict_keys to list * Convert dict_keys to list * Correct type hints * Update copyright year * Import Retry from urllib3 directly * Sync baseline commit f6871e918451f5cac025e5f2ec6361e98fc74d3d Author: David van Buiten <[email protected]> Date: Tue Oct 17 09:40:19 2023 +0200 Bumped API version to 2.32.0-beta.2 commit 0a004c03bd51ee2dade3c5a2a1a518a005aa7873 Merge: b98988f8 210df929 Author: David van Buiten <[email protected]> Date: Tue Oct 17 09:39:24 2023 +0200 Merge pull request #1391 from Amsterdam/task/update-reporter-permission-check Implemented 'sia_can_view_contact_details' permission check on signal reporter endpoints commit 210df929d4df4559199ed0fae6df1a14e6012979 Author: David van Buiten <[email protected]> Date: Tue Oct 17 08:59:47 2023 +0200 Fixed isort issues commit 4735926d773147446d0fde00d1eefdc738c4de95 Author: David van Buiten <[email protected]> Date: Tue Oct 17 08:52:08 2023 +0200 Implemented 'sia_can_view_contact_details' permission check on signal reporter endpoints and updated/added tests commit b98988f8485091d217115cae10f1c30f772e947a Author: Youri Westerman <[email protected]> Date: Mon Oct 16 16:07:16 2023 +0200 Solve mypy issues email integrations app (#1390) * Assert that signal relations are not None * Rename admin to not reflect the model name and set description of custom action using decorator * Explicitly make context argument optional * Assert that there is a reporter with an email address to send mail to * Refactor abstract rules * Make sure we get a float value from the settings * Add null checks * Declare actual list instead of tuple and add None assertions * Use list instead of tuple and add None assertion * Use list instead of tuple and add None assertions * Remove temporary permission exclusions * Use list as declared in type hint * Assert that the action type exists * Create reporter instead of passing factory * Add type hints to properties * Sync baseline commit f0b6a5b6de62e1c6566bba9446b6abc0c47aaf7c Author: David van Buiten <[email protected]> Date: Mon Oct 16 10:41:35 2023 +0200 Bumped API version to 2.32.0-beta.1 commit f88f84c253f3961619c0a55a891a368f42e9fdc7 Merge: 799d145d 0f9db47a Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:29:39 2023 +0200 Merge pull request #1389 from Amsterdam/task/cleanup-github-workflows Cleanup GitHub workflows commit 0f9db47a138183ca5c4d289b8de2edc2c2bc0322 Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:20:47 2023 +0200 Removed build and push to GHCR commit f3b34ba574b0b3f1dd8b14022e67d5e86d9847e6 Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:20:07 2023 +0200 Removed manually build and push to docker commit 6478479b3e905a87cd7a4c2ef359ed4de2dab7dc Author: David van Buiten <[email protected]> Date: Mon Oct 16 09:07:55 2023 +0200 Removed unused github ci review environment actions commit 799d145de55455bb5ba1c8b9318f8cc98ad8b2e3 Merge: 7413a361 d3fef5db Author: David van Buiten <[email protected]> Date: Fri Oct 13 12:30:53 2023 +0200 Merge pull request #1388 from Amsterdam/task/fixing-mypy-issues-in-settings Fixing mypy issues in the settings.py file commit d3fef5dbc2deffbabf8cc1e98d0f45d54a530c0b Author: David van Buiten <[email protected]> Date: Fri Oct 13 09:54:41 2023 +0200 Fixed flake8 issue commit 7b347740c7d1c41df4cdc72350076046d3931746 Author: David van Buiten <[email protected]> Date: Fri Oct 13 09:43:38 2023 +0200 Fixing mypy issues in the settings.py file commit 7413a361888ee8da858a156c7a5c60d75c8da15f Author: Youri Westerman <[email protected]> Date: Thu Oct 12 17:17:01 2023 +0200 Solve mypy issues my signals (#1387) * Use lazy function instead of lazy attribute since we don't use the object itself to generate the email address * Replace setting boolean attribute with decorator * Assert that we're getting from the context what we're expecting * No longer magically assign urlpatterns property * Have both serializers share code by means of an abstract class instead of having one extending the other * Abstract class cannot inherit from derived class * Format is optional * Update baseline commit 2ddcf3c8faaf2073aab78df471723d213a33f3de Merge: 7e5a3230 6c253627 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:52:15 2023 +0200 Merge pull request #1386 from Amsterdam/task/cleanup-requirements Cleanup of requirements in files commit 6c253627472ad89b81ee57057c7d4d4f420662d2 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:20:32 2023 +0200 Cleanup of requirements in files commit 7e5a32308b56fb7ba54246d919b8d1bfab00488f Merge: d7390113 327d1970 Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:32:42 2023 +0200 Merge pull request #1385 from Amsterdam/task/refactor-settings Refactored the settings folder into a single settings.py file commit 327d1970ee6050661f0d9cd3c8c337913a1d365c Author: David van Buiten <[email protected]> Date: Thu Oct 12 13:22:51 2023 +0200 Added missing newlines commit 532549ad55f8b8be18bf96c28f01f5769f73932f Author: David van Buiten <[email protected]> Date: Thu Oct 12 09:35:03 2023 +0200 Refactored the settings folder into a single settings.py file, updated the documentation. commit d739011357fd2d9c4488aabfb8beec63d83dfe72 Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:59:37 2023 +0200 Add factory boy stub package (#1384) * Add stubs package for factory-boy package * Update mypy baseline commit e933f1a8246ae070206cbd45fd88fe7b6ed3cde5 Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:25:20 2023 +0200 Add stubs package for django filters (#1383) * Upgrade dependencies and install stub package for django-filter * Update mypy baseline commit eb0fd1a7e3dcea7305a69d900a43474a4ce7aaaf Author: Youri Westerman <[email protected]> Date: Wed Oct 11 15:15:42 2023 +0200 Always create a new token and delete the old ones when a new token is requested (#1382) commit f0e71b28766b3afabac04055ca99c3f51a551350 Merge: cfcfd941 03676ed2 Author: David van Buiten <[email protected]> Date: Mon Oct 9 12:21:01 2023 +0200 Merge pull request #1381 from Amsterdam/task/add-stubs-for-mypy Added stubs for improved type checking as suggested by mypy commit 03676ed2e893c2f366fbd661d93b338c008e6083 Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:19:05 2023 +0200 Added types-psycopg2 commit 36f80bff9e484d9018c2072acbf3a9092bacd20b Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:16:00 2023 +0200 Added types-Pygments commit 2fc49b8ab14d78cdab95a94b605b36969016c3eb Author: David van Buiten <[email protected]> Date: Fri Oct 6 16:00:22 2023 +0200 Added lxml-stubs + updated the mypy baseline commit c4079f4ce1e633968feda33458542435432f1091 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:55:56 2023 +0200 Added types-python-dateutil + updated the mypy baseline commit b6df8c359d16132183b6b68611986ed44b0b9a02 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:52:26 2023 +0200 Added types-Markdown + updated the mypy baseline commit c513b91000cbeafd8736657e9f079418090b2ad6 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:47:19 2023 +0200 Added types-Pillow + updated the mypy baseline commit 662a2cd21b387ac323da61d6d3a79a9b6e9267af Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:43:38 2023 +0200 Added types-jsonschema + updated the mypy baseline commit 9bc5bacd2a452260ff8cb6d6e87038a4b7d78d60 Author: David van Buiten <[email protected]> Date: Fri Oct 6 15:31:45 2023 +0200 Added types-beautifulsoup4 + updated the mypy baseline commit cfcfd941cc24a4403dabe7a106af8bae755e3f3e Merge: 7b96a434 7bb4b7b0 Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:58:38 2023 +0200 Merge pull request #1380 from Amsterdam/task/add-mypy-djangorestframework-stubs Added the djangorestframework-stubs mypy plugin commit 7bb4b7b0a255ef59469139554c0366ae60a3c24d Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:49:27 2023 +0200 Added the djangorestframework-stubs mypy plugin commit 7b96a4342fb7549ff239efe5b3a436fe4a07de6a Merge: 002dc83f 84370852 Author: David van Buiten <[email protected]> Date: Fri Oct 6 11:36:58 2023 +0200 Merge pull request #1379 from Amsterdam/task/add-mypy-django-stubs Added the django-stubs mypy plugin commit 84370852d3d3391f56fb070589af3b504abaed36 Author: David van Buiten <[email protected]> Date: Fri Oct 6 10:32:45 2023 +0200 Synced mypy baseline commit 5204bc9c5474d9d091d6eadb84cb58f9b1028e19 Author: David van Buiten <[email protected]> Date: Fri Oct 6 09:48:22 2023 +0200 Added the django-stubs mypy plugin commit 002dc83f648a4ba4b78b428f5c3df26376c2523f Author: Youri Westerman <[email protected]> Date: Tue Oct 3 11:55:22 2023 +0200 Install mypy (#1377) * Upgrade dependencies and install mypy and mypy-baseline * Add mypy baseline * Run mypy using tox * Add mypy step to ci commit 0fa3385acdc859fca9a06bbec69f1b49319862b6 Author: Youri Westerman <[email protected]> Date: Tue Oct 3 11:09:57 2023 +0200 Upgrade dependencies (#1378) * Update dependencies * Use the right list index in test commit 47c79b03cc7f0ed3acb765c33a5e72abd0b2274f Author: Youri Westerman <[email protected]> Date: Mon Oct 2 14:43:24 2023 +0200 Use docker-compose in ci (#1376) commit 9108e00cf7ad31d1a2cb1a182a193a214823cd80 Author: Youri Westerman <[email protected]> Date: Mon Oct 2 13:28:50 2023 +0200 Add test container build stage (#1375) * Add test build stage * Add docker-compose file for test environment commit dd4a3adc8147a0ebfec45c13e243feb6dc8b9d7f Author: Youri Westerman <[email protected]> Date: Mon Sep 25 09:32:44 2023 +0200 Bump version commit 191d10dee63f5ffa2ed019a86bf04b67ace8ed55 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:45:44 2023 +0200 Bumped API version to 2.31.0-beta.1 commit 16ced0105dbd599641527f4b114af3b7081e1dc5 Merge: e913c9c3 9a6f5b15 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:44:57 2023 +0200 Merge pull request #1374 from Amsterdam/fix/azure-cannot-overwrite-translations-file Delete translation file before uploading the updated version commit 9a6f5b15495b793f7afaa5f4fd69ac119b7be4a0 Author: David van Buiten <[email protected]> Date: Wed Sep 20 14:34:49 2023 +0200 Due to Azure's limitations, we are unable to overwrite the translation file directly. To work around this, we delete the existing file before uploading the updated version. commit e913c9c3dc575ffcedd2573a25efeb05b14c97b5 Author: Youri Westerman <[email protected]> Date: Wed Sep 20 14:02:16 2023 +0200 Bump version commit edd4e69441c69b4c944da7a81d0a3c113b6e0c9f Merge: 68335b63 c00c0bd6 Author: David van Buiten <[email protected]> Date: Wed Sep 20 13:56:10 2023 +0200 Merge pull request #1372 from Amsterdam/feature/public-and-private-endpoints-for-i18next-translation-file Added I18Next translation file creation (private) and retrieval (public) views commit c00c0bd6c0fb72e2268bc28fd7bab8c50b60d108 Author: David van Buiten <[email protected]> Date: Wed Sep 20 13:44:35 2023 +0200 Use TemporaryDirectory as a context manager when testing the translation file endpoints. commit 68335b63f741f9ebf6e75df56fc6e912f0f770ea Author: Youri Westerman <[email protected]> Date: Wed Sep 20 11:57:54 2023 +0200 Enable sorting search results by date (#1373) * Return all documents when no term is provided (previous implementation was broken) * Add ordering parameter * Provide OpenApi spec commit 6ef56b0a59bee49057e9e9ca99ae412f9d5906df Author: David van Buiten <[email protected]> Date: Wed Sep 20 11:03:49 2023 +0200 Renamed the Permission "add_i18next_translation_file" to "sia_add_i18next_translation_file" commit 8847c92e5b717557c2f12ed5980e1cf3c8546fa7 Author: David van Buiten <[email protected]> Date: Wed Sep 20 10:21:03 2023 +0200 Added unit tests for the private and public translation endpoints commit 6974d1747fc8a807ec15fdaa1de184cfe9cf6084 Author: David van Buiten <[email protected]> Date: Tue Sep 19 11:24:41 2023 +0200 Instead of defining the variable `translation_filename` twice use a constant. The constant is named `I18NEXT_TRANSLATION_FILE_PATH` commit 98f48f2c25a46a5648f960a412161fb3fca0d6a0 Author: David van Buiten <[email protected]> Date: Tue Sep 19 11:23:44 2023 +0200 Use `path` instead of `re_path` when defining the route for the private translations endpoint commit de232986cbb47e18f708250dd341429887a4b6c8 Author: David van Buiten <[email protected]> Date: Tue Sep 19 09:30:07 2023 +0200 Added I18Next translation file creation (private) and retrieval (public) views - Added a `PrivateCreateI18NextTranslationFileView` class to create/update the I18Next translation file from JSON data - Added a `PublicRetrieveI18NextTranslationFileView` class to retrieve the latest I18Next translation file - Updated the `urls.py` file to include public and private endpoints for translation file management commit 5564c58b29977b5fb24cc672696bd3d8bf064eb3 Merge: b40708e5 ea1be444 Author: David van Buiten <[email protected]> Date: Mon Sep 18 14:57:15 2023 +0200 Merge pull request #1371 from Amsterdam/task/add-custom-permission-for-storing-18next-translation-file Introduce CustomPermission abstract class and sync_custom_permission function + custom i18next permission commit ea1be44469d40c0015860f7682726c367bc67dac Author: David van Buiten <[email protected]> Date: Mon Sep 18 14:48:22 2023 +0200 This commit adds a new abstract class, CustomPermission, essential for creating custom permissions independent of existing models, as Django auth Permissions necessitate a ContentType association. Additionally, a sync_custom_permission function is included, which responds to the DjangoSignal post_migrate, facilitating the creation of custom permissions if they do not already exist. commit b40708e54d68aeae45bc58f95dccf7f0cc11f683 Author: Youri Westerman <[email protected]> Date: Mon Sep 18 09:43:51 2023 +0200 Ignore dumps folder to save time/memory when building container images (#1370) commit fd018460d2ffceb7bfd6f22487b3accce6b2e6b1 Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:50:28 2023 +0200 Bumped API version to 2.30.7 commit be87aa0b1d112b5c261d280e2c334d2e72644059 Merge: 7a154bd8 9f0e006e Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:49:48 2023 +0200 Merge pull request #1369 from Amsterdam/fix/adding-note-must-update-the-signal-update_at When adding a Note, ensure that ONLY the 'updated_at' timestamp of a Signal is updated commit 9f0e006ea91dae5f8e7c96203809abd12fcc3449 Author: David van Buiten <[email protected]> Date: Fri Sep 15 09:34:37 2023 +0200 Ensures that the 'updated_at' timestamp accurately reflects the most recent activity related to a Signal, without altering any other existing data. In commit 9dc54a1, the 'signal.save()' method was removed. However, this change affected the 'updated_at' timestamp used by the 'geen actie nodig' functionality on a parent Signal. commit 7a154bd8a252298040988a028ba96090017c109f Author: David van Buiten <[email protected]> Date: Thu Sep 14 14:51:46 2023 +0200 Bumped API version to 2.30.6 commit 834c8f521df749b917893a305765273eeedff8ed Merge: b91caa82 3c151a03 Author: David van Buiten <[email protected]> Date: Thu Sep 14 14:51:11 2023 +0200 Merge pull request #1368 from Amsterdam/bugfix/status-not-changing-to-reopened-opn-negative-feedback Don't save signal when creating a note as nothing has changed on the … commit 3c151a0356e665684f6a609c36512c672aa40252 Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:42:40 2023 +0200 Remove now unused variable from test commit e2e5c37d01c5c65c347280f36d4a501d4347a46e Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:40:53 2023 +0200 Remove assertion from test commit 9dc54a1190053d5be678e29d057ed6ef65b859c8 Author: Youri Westerman <[email protected]> Date: Thu Sep 14 14:28:29 2023 +0200 Don't save signal when creating a note as nothing has changed on the actual signal commit b91caa82f1504e988e61da7ac113309c5bc67301 Author: Bart <[email protected]> Date: Thu Sep 14 12:04:49 2023 +0200 Make status messages index configurable (#1367) commit 50249561b65b79abebc02b8936d6ce907ab30ab9 Author: David van Buiten <[email protected]> Date: Wed Sep 13 12:45:22 2023 +0200 Bumped API version to 2.30.5 commit 57b06a1008ea7f72910025d964d6c70ab47d2770 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:22:38 2023 +0200 Bumped API version to 2.30.5-beta.2 commit 47f649473b3da8f823d142de37f5400f1ed8809b Merge: eb3df0b4 e2c6099d Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:21:09 2023 +0200 Merge pull request #1366 from Amsterdam/task/fix-signals-celery-tasks-in-db-after-refactor Update Signals task references in the database after restructuring tasks commit e2c6099d08af41ac7eacd8eb8b0c3efafd177bc0 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:12:59 2023 +0200 Fixed flake8 issues commit 56c186358cfef2d4fadba202bf02a03dd3536547 Author: David van Buiten <[email protected]> Date: Wed Sep 13 10:03:14 2023 +0200 Fixed isort issues commit eb3df0b4dad24b0d327a37d721ae9f506353fa5a Author: Youri Westerman <[email protected]> Date: Wed Sep 13 10:02:07 2023 +0200 Bugfix/concurrency fault in public attachment uploading (#1365) * Add code to reproduce the problem * Don't acquire row lock for signal when creating notes commit 06cfe70ee0c0dc5aa0bb99438a147fe89b544b7c Author: David van Buiten <[email protected]> Date: Wed Sep 13 09:49:59 2023 +0200 This migration updates the Celery task references in the database to match the new folder structure for tasks. Previously, all tasks were located in a single tasks.py file, but they have now been refactored into individual files within a 'tasks' folder. The FORWARD_MAPPING and REVERSED_MAPPING dictionaries are used to map old task references to new ones. The migration script loops through these mappings, updating the task references in the 'PeriodicTask' model of the 'django_celery_beat' app. commit 83f84a759909cf9a284e404045221887c9362fb0 Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:29:49 2023 +0200 Bumped API version to 2.30.5-beta.1 commit a75aa7a86a7f03c88416d09f60e04953dfe03472 Merge: c91528db 04d355cd Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:28:47 2023 +0200 Merge pull request #1364 from Amsterdam/task/added-deleted-signals-admin-filter-option Added `date_hierarchy` to the DeletedSignalAdmin + us the admin.action decorator commit 04d355cd9b61df126c023715006f4f50e89864dc Author: David van Buiten <[email protected]> Date: Tue Sep 12 11:18:15 2023 +0200 Added `date_hierarchy` to the DeletedSignalAdmin + us the admin.action decorator commit c91528db81e69700f832821797364e05925f1abc Author: David van Buiten <[email protected]> Date: Tue Sep 12 08:27:23 2023 +0200 Bumped API version to 2.30.5-beta.0 commit 7486262050650fa770718bc25f599c8847063c57 Merge: 9c64935a 2eb981d9 Author: David van Buiten <[email protected]> Date: Tue Sep 12 08:19:47 2023 +0200 Merge pull request #1363 from Amsterdam/task/delete-signals-celery-task Refactor the delete signal service so that it can trigger celery tasks per signal commit 9c64935acf1df096d49d0cc996d1300b36ccc395 Author: Youri Westerman <[email protected]> Date: Mon Sep 11 13:59:44 2023 +0200 Bunmp version commit 2d87e55bb117765d87f82cc0d5ec643484b70f1f Author: Bart <[email protected]> Date: Mon Sep 11 13:58:54 2023 +0200 Make status messages index configurable (#1362) commit 2eb981d9296e1069fa1b822dec6bd55e7c917fa4 Author: David van Buiten <[email protected]> Date: Thu Sep 7 15:21:09 2023 +0200 Refacored the SignalsDeleteService into 2 celery tasks. One for determining the signals that are in a state for more than X days and one for the deletion of a signal. commit 6d1db91b16c724df92de0167aaefaa3be7b4e89b Author: David van Buiten <[email protected]> Date: Thu Sep 7 14:30:45 2023 +0200 Removed the dry-run option. Moved delete from elastic to a Signal post_delete listener. Refactored valid_states into VALID_STATES and made it Final. commit b75cdaea7db9af4efd58fc6f99f0237d3c9035e4 Author: David van Buiten <[email protected]> Date: Thu Sep 7 08:30:34 2023 +0200 Fixed calling the DeleteSignalsService when deleting a child signal with the id of the Signal instead of the signal itself. Fixed isort issue commit dcf58b6118f463bbc9ea38093008f0522f687622 Author: David van Buiten <[email protected]> Date: Wed Sep 6 16:28:22 2023 +0200 Refactor 'SignalDeletionService' to enhance code structure and renamed to 'DeleteSignalsService', update code and tests accordingly. Kept the celery task 'delete_closed_signals' for backwards compatibility and added a deprecation warning. It's recommended to use 'delete_signals_in_state_for_x_days' instead. commit ed244bae615a7fcf9004a788d5b2d50e30161e13 Author: David van Buiten <[email protected]> Date: Mon Sep 4 13:56:05 2023 +0200 This commit splits the tasks in app/signals/apps/signals/tasks.py into separate files, making it easier to manage and maintain the code. commit 137f2230e4ca212e0a5747b448c05c9723f7a711 Author: Youri Westerman <[email protected]> Date: Mon Sep 4 13:45:22 2023 +0200 Use mailpit instead of mailhog (#1361) * Use mailpit instead of mailhog * Update mail host in env files * Add documentation about mailpit commit d131a7ccd3481deeac29b0d5afdd20336aed2e28 Author: Youri Westerman <[email protected]> Date: Mon Sep 4 09:16:04 2023 +0200 Bump version commit ccf906624865955a0763dff262846a56a8c16056 Author: Youri Westerman <[email protected]> Date: Fri Sep 1 09:14:06 2023 +0200 Bump version commit 3affc54d6050f8796ad16bb09a916e90d0486776 Author: Youri Westerman <[email protected]> Date: Fri Sep 1 09:12:38 2023 +0200 Provide signal context to reporter mail templates (#1360) commit 42102989c9a5b42c550fa192e6ce46a20c89b93b Author: Youri Westerman <[email protected]> Date: Thu Aug 31 13:15:55 2023 +0200 Refactor entrypoint script for dev environment (#1358)

4c0n added 2 commits October 2, 2023 12:48

Add test build stage

5303b56

Add docker-compose file for test environment

b2365ae

4c0n requested a review from vanbuiten October 2, 2023 11:21

vanbuiten approved these changes Oct 2, 2023

View reviewed changes

4c0n merged commit 9108e00 into main Oct 2, 2023
7 checks passed

4c0n deleted the chore/add-test-container-build-stage branch October 2, 2023 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test container build stage #1375

Add test container build stage #1375

4c0n commented Oct 2, 2023

Add test container build stage #1375

Add test container build stage #1375

Conversation

4c0n commented Oct 2, 2023

Description

Checklist

How has this been tested?