FAKE: for gihub action testing #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to have a single source of truth
…gh xml file at the default location Add inputs to save the new file at the default location with the default filename Also ask for spm and rawdatadir locations when using the base parameter xml as seed, since those are required for a minimal-complete parameter xml file.
…rectly Use aas_create_parameter_xml to create the user parameter xml file with the default name in the default location. Additionally, update various comments in the file Final changes to complete automaticanalysis#301
tutorial_1: add downloaddemo call, remove aa_close call other examples: remove aa_close call, it is not needed when aa runs successfully, as it is already part of both aa_doprocessing and aa_report
This to enable adding non-use-case tests, which needs more advanced filtering options, while keeping aa_test as the entry point for all testing For now, the changes are backward compatible with how aa_test could be used before. Only the log file has more info in it now.
Because TestParameterDefinition only available as of 2021a. Actually nicer this way, inputargs are not really a test parameter, so better to use a TestClassSetup function.
Only predefined datasets can be downloaded by aa_downloaddemo: this makes it possible to test that the datasets are still available through Continuous Integration tests. No rawdatadir manipulations inside aa_downloaddemo: When using aa_downloaddemo, the input must specify exactly where the data should go. Since this function is for use in demo scripts, can require that aap.directory_conventions.rawdatadir is set to expectation of this function. And makes this function single-purpose. No aas_shell calls in aa_downloaddemo: only use Matlab provided functions, no need to use system functions. This also makes aa_downloaddemo windows compatible. Add aa_downloaddemo_datasets to hold the list of predefined datasets. This makes it easy to loop over all predefined datasets in a test. Adapt all examples that use aa_downloaddemo to use the new calling convention.
… artifactn Fixes issue automaticanalysis#275
Although this tutorial is to help users set up a parameter file, adapt it so it can also run without user interaction. In order to be able to have an automated test for tutorial_1
Tests for downloaddemo and tutorial_1, also made part of aa_test list of tests
Introduce tag-based filtering in aa_test, to have more fine-grained filtering. And add tags to the use-case tests. Add a dedicated actions yml file for the non-use-case tests.
One of the demo datasets is an unzipped tar, which can give an error with untar if an incorrect file extension is specified.
AljenU
force-pushed
the
feature-downloaddemo-simplification
branch
4 times, most recently
from
2dab2f4 to
e4b9bea
Compare
Single-step install and configure, make parameter file name an env var
AljenU
force-pushed
the
feature-downloaddemo-simplification
branch
from
bc26d5d to
3cbd320
Compare
|
I can give this a review, once you're finished with the changes. |
AljenU
force-pushed
the
feature-downloaddemo-simplification
branch
3 times, most recently
from
e51ae7c to
f16077d
Compare
AljenU
force-pushed
the
feature-downloaddemo-simplification
branch
from
f16077d to
d9ad33a
Compare
So they do not overwrite each other. Also add aa_test.log artifact to use_case tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New workflows were added, they only show up in Actions when on master, OR when a PR to master is opened.....