feat: improve TypeMoney with an export to JSON method

AlcidesRC · May 20, 2024 · 4110201 · 4110201
1 parent b7bd2e7
commit 4110201
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 34 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/TypeMoney.php b/src/TypeMoney.php
@@ -48,17 +48,11 @@ public function __invoke(): array
         return [$this->amount, $this->currency];
     }
 
-    public function toJson(): string
+    public function toJson(): string|false
     {
         return json_encode([
             ($this->amount)(),
             $this->currency->value
         ]);
     }
-
-    public static function fromJson(string $data): self
-    {
-        [$amount, $currency] = json_decode($data, true);
-        return self::set($amount, $currency);
-    }
 }
diff --git a/tests/Unit/TypeMoneyTest.php b/tests/Unit/TypeMoneyTest.php
@@ -158,26 +158,4 @@ public static function dataProviderForToJson(): array
             'Negative' => [TypeMoney::set(-123.45, 'USD'), '[-123.45,"USD"]'],
         ];
     }
-
-    // ---------------------------------------------------------------------------------------------------------------
-
-    #[Test]
-    #[DataProvider('dataProviderForFromJson')]
-    public function checkFromJson(string $data, TypeMoney $expected): void
-    {
-        $aux = TypeMoney::fromJson($data);
-
-        self::assertTrue($aux->isEqualTo($expected));
-    }
-
-    /**
-     * @return array<string, array<int, mixed>>
-     */
-    public static function dataProviderForFromJson(): array
-    {
-        return [
-            'Positive' => ['[123.45,"EUR"]', TypeMoney::set(123.45, 'EUR')],
-            'Negative' => ['[-123.45,"USD"]', TypeMoney::set(-123.45, 'USD')],
-        ];
-    }
 }