testing merging dev-upgrade-18 #10766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #10445 ## Description IBC Denoms are unique to a chain but not all not all chains. e.g., if `channel-0` points to `osmosis` for two chains, the `uosmo` denom will be `ibc/ED07A3391A112B175915CD8FAF43A2DA8E4790EDE12566649D0C2F97716B8518` for both. This change requires callers to specify the `holdingChainName` for the denom they wish to retrieve information about. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Updates existing tests. Motivated from work in #10571 which surfaced this issue. ### Upgrade Considerations Breaking change, but for library code that will be part on NPM or FUSDC release.
incidental ## Description Remove `tsx` now that we can use `ts-blank-space` throughout. It aligns better with future `.ts` support in Node. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations fewer cases, fewer deps ### Testing Considerations CI ### Upgrade Considerations none
Rename types/functions/parameters as suggested at: * #10348 (comment) * #10348 (comment)
Implements suggestions from: * #10348 (comment) * #10348 (comment) * #10348 (comment) * #10348 (comment)
- shape used for pfm ForwardInfo options
- provide `chainInfo` and `assetInfo` in commonPrivateArgs for contracts to use - register common assets used in testing - provide `populateChainHub` function for use in exo unit testing in favor of `registerAgoricBld`
this test can no longer rely on the IST brand being available, so we - added checks to ensure brands are accepted for `.transfer` and `.send`. marked as failing for now - filed #10449 since this surfaced a bug in `amountToCoin` - use Moolah issuer for "no denom for brand" failure path tests
- enables sending offers with brands
- chainInfo and assetInfo are provided as `commonPrivateArgs`. include them in `ContractMeta`
- auto-stake-it initializes `chainHub` with data so existing tests that use `.transfer()` pass
- no longer needed since we call `registerChainsAndAssets`
- no longer relies on buggy agoricNames - continues to test async-flow resumability and cross-chain vow settlement across upgrade Co-authored-by: 0xPatrick <[email protected]>
- test/bootstrapTests/orchestration.test.ts used a mixed of test and test.serial - the test without `.serial` interleaved and was confusing to debug - this mainly updates inline snapshots, which return different account and channel identifiers since all tests in this file share the same context
- basic-flows.contract.js is provided with `chainInfo` and `assetInfo` in `privateArgs` via builder options - needed for tests that use `localAccount.transfer()`, now reliant on asset info, to pass
refs: #10598 ## Description The dashboard will requires data for each transaction. In the course of designing that we explored how to design the storage node paths without creating too much cost in IAVL. (The data in HEAD carry a burden of magnitude O(k+v) for all network nodes (including non-validators) into perpetuity.) Examining [the trade-offs](https://alpha.decidedly.co/d/b27cbb6a-df71-4136-aa27-3e947015e84b/view) we arrived at: - store one node per transaction - push all changes through it - rely on indexer to demux - delete on demand - when we have [an API for block-safe deletion](#7405) it can delete in the operation - until then keep track of what to delete - a core-eval can be run to cull data whenever necessary ### Security Considerations none ### Scaling Considerations One storage path per transaction, which persists until the deletion job is called. One entry in a set to keep track of transactions to delete. ### Documentation Considerations Not developer facing ### Testing Considerations CI ### Upgrade Considerations not yet deployed
closes: #10399 ## Description Adds the upgrade of the reserve to upgrade 19. To ensure that this upgrade will succeed, we've also added test coverage in A3P. One caveat we discovered while testing was that the `adminFacet` that's produced with the `reserveKit` was referencing the `adminFacet` of the governor. Luckily, we were able to get the `adminFacet` of the reserve contract by calling `getAdminFacet` on the governor's `creatorFacet`. ### Upgrade Considerations This PR adds the reserve to the list of vat upgrades for upgrade-19. These upgrades are currently commented out as we are still in the process of getting upgrade-18 out the door. We've added A3P tests to ensure that the upgrade is successful and that assets are still in the reserve after the upgrade.
closes: #10094 ## Description Add a direct way to retrieve the governed parameters from the vaultDirector ### Security Considerations This was already accessible (and intended to be public) via vstorage. It just adds a direct way to request the values when you have the vaultFactory publicFacet. ### Scaling Considerations No effect. ### Documentation Considerations No change ### Testing Considerations Added a Unit test. ### Upgrade Considerations The purpose was to simplify retrieving the previous values for upgrade.
mujahidkay
commented
Dec 23, 2024
packages/fast-usdc/package.json
Outdated
Comment on lines
2
to
4
| "name": "@agoric/fast-usdc", | ||
| "version": "0.1.0", | ||
| "description": "CLI and library for Fast USDC product", |
There was a problem hiding this comment.
@mhofman I've intentionally reset this to 0.1.0 because its now a public package (didn't really get published before)
There was a problem hiding this comment.
Also, the CHANGELOG file is not in the diff but should we also wipe it clean?
There was a problem hiding this comment.
I would avoid mucking with the versions here, and leave the previously auto-incremented one even if it wasn't published.
packages/fast-usdc/package.json
Outdated
Comment on lines
35
to
44
| "@agoric/client-utils": "^0.1.0", | ||
| "@agoric/cosmic-proto": "^0.4.0", | ||
| "@agoric/ertp": "^0.16.2", | ||
| "@agoric/internal": "^0.3.2", | ||
| "@agoric/notifier": "^0.6.2", | ||
| "@agoric/orchestration": "^0.1.0", | ||
| "@agoric/store": "^0.9.2", | ||
| "@agoric/vat-data": "^0.5.2", | ||
| "@agoric/vow": "^0.1.0", | ||
| "@agoric/zoe": "^0.26.2", |
There was a problem hiding this comment.
@mhofman I believe we need to match the agoric deps versions with the rest of the packages (with u18 pre-ids). Will need to do it manually. Kindly confirm
|
aw shucks my local dev-upgrade-18 branch was behind. resolving further conflicts |
Deploying agoric-sdk with
|
| Latest commit: |
698b0c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec093398.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mk-test-u18-merge.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept agoric deps versions from dev-upgrade-18 but endo (and other) deps versions from master.