fix(acceptance): fix flakey psm test #10747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was no skipped test to begin with. The tests passed when the job is re-run.
|
Chris-Hibbert
approved these changes
Dec 26, 2024
anilhelvaci
force-pushed
the
anil/10728-fix-tx-timeout
branch
from
5e9b3bc to
6f84f5a
Compare
Deploying agoric-sdk with
|
| Latest commit: |
6f84f5a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://779df158.agoric-sdk.pages.dev |
| Branch Preview URL: | https://anil-10728-fix-tx-timeout.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10728
Description
Using
-bblockcaused inconsistent timeout behavior due to txs not getting into a block on time.psm.test.jsis observed to be the only test that sends transactions with-bblockset. In this PR we switch to the default option which issync.Security Considerations
None.
Scaling Considerations
Removing flakiness will help landing code faster.
Documentation Considerations
None.
Testing Considerations
Should force integration tests.
Upgrade Considerations
z:acceptanceruns after every upgrade.