clean up liveslots tests #10739
Open
clean up liveslots tests #10739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
9b64cca
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5585ad77.agoric-sdk.pages.dev |
| Branch Preview URL: | https://5575-liveslots-gc.agoric-sdk.pages.dev |
turadg
force-pushed
the
5575-liveslots-gc
branch
from
fe9c874 to
9b64cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5575
Description
I read #5575 (comment) and thought it would be good to be on the latest version of Ava and default configuration before reworking the tests more.
This does that and also changes the four
test.failingto usetestthat are confirmed to be the correct behavior. Since the test is of test failures, it uses a new spy instead.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
This is one package of the monorepo on Ava 6. I tried bumping them all before but ran into problems. We should tackle them all eventually,
Testing Considerations
This might solve #5575 but we won't know for a while since it's intermittent. Still it reduces variables in solving that problem.
Upgrade Considerations
none