Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to AEM 6.4 dependencies #2422

Merged
merged 2 commits into from
Dec 14, 2020
Merged

update to AEM 6.4 dependencies #2422

merged 2 commits into from
Dec 14, 2020

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Sep 27, 2020

No description provided.

@kwin kwin requested a review from joerghoh September 27, 2020 16:32
@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@kwin kwin force-pushed the feature/update-osgi-dependencies branch 2 times, most recently from 41bbd31 to d9e8a62 Compare September 27, 2020 17:48
@kwin kwin mentioned this pull request Sep 27, 2020
Open
20 tasks
@kwin kwin requested a review from davidjgonzalez September 27, 2020 17:52
@kwin kwin force-pushed the feature/update-osgi-dependencies branch from d9e8a62 to 7fef4ff Compare September 27, 2020 18:10
@kwin
Copy link
Contributor Author

kwin commented Oct 8, 2020

@joerghoh and @davidjgonzalez Is there any way we can move forward here? This is quite fundamental for 5.0 IMHO and this merge blocks further improvements.

@kwin kwin force-pushed the feature/update-osgi-dependencies branch 5 times, most recently from 0c13a58 to bc4f5a2 Compare November 1, 2020 19:25
@kwin
update to AEM 6.4 dependencies
20b8328 
clean up dependencies
@kwin kwin force-pushed the feature/update-osgi-dependencies branch from bc4f5a2 to 20b8328 Compare November 2, 2020 08:59
@kwin
Copy link
Contributor Author

kwin commented Nov 2, 2020 •
edited
Loading

@adamcin or @justinedelson
Any idea how to easily update https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/oakpal-checks/src/main/resources/bundleinfo/6.4.json added in #1797. The information from the JSON is incorrect for AEM 6.4!

I am getting the following errors (e.g. in https://api.travis-ci.org/v3/job/740785650/log.txt)

[INFO] --- oakpal-maven-plugin:2.1.0:verify (oakpal-verify) @ acs-aem-commons-ui.apps ---
[INFO] OakPAL Check Reports
[INFO]   com.adobe.acs.acs-aem-commons-oakpal-checks/acs-internal/base-version-compatibility
[ERROR]    +- <SEVERE> Package import com.fasterxml.jackson.annotation;version="[2.9.0,3.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (2.8.4). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec.digest;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec.net;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.builder;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.exception;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.reflect;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.time;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.tuple;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.osgi.framework;version="[1.9.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.8.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[INFO]   com.adobe.acs.acs-aem-commons-oakpal-checks/acs-internal/base-version-compatibility
[ERROR]    +- <SEVERE> Package import com.fasterxml.jackson.annotation;version="[2.9.0,3.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (2.8.4). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec.digest;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.codec.net;version="[1.13.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.10.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.builder;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.exception;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.reflect;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.time;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.apache.commons.lang3.tuple;version="[3.9.0,4.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (3.6.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR]    +- <SEVERE> Package import org.osgi.framework;version="[1.9.0,2.0.0)" cannot be satisified by AEM Version 6.4. Available package versions are (1.8.0). [acs-aem-commons-ui.apps-4.8.5-SNAPSHOT.zip]
[ERROR] ** Violations were reported at or above severity: MAJOR **

They all seem to be false positives!

@davidjgonzalez davidjgonzalez added this to the 5.0.0 milestone Nov 3, 2020
@kwin
Copy link
Contributor Author

kwin commented Nov 9, 2020 •
edited
Loading

Actually I was wrong, and they are not false positives. Also I found the profile extract-bundle-info which allows to update the bundle info json. Some versions are just too new still for AEM 6.4. Will downgrade those.

@kwin
Downgrade some versions to be in line with 6.4.0
6c7a309 
improve output of ExtractBundleInfo.groovy
@kwin kwin marked this pull request as ready for review November 23, 2020 07:08
@kwin
Copy link
Contributor Author

kwin commented Nov 23, 2020

This is now ready for merge. The build just fails because of #2472. (but it fails with the same error on the target branch feature/2288-prepare-release-500)

@davidjgonzalez davidjgonzalez changed the base branch from feature/2288-prepare-release-500 to acs-aem-commons-5.0.0 December 14, 2020 21:24
@davidjgonzalez davidjgonzalez merged commit bac12f9 into Adobe-Consulting-Services:acs-aem-commons-5.0.0 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerghoh joerghoh Awaiting requested review from joerghoh

@davidjgonzalez davidjgonzalez Awaiting requested review from davidjgonzalez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kwin @davidjgonzalez