Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/open-in-explorer-for-wallets-on-account-screen #695

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

NikIvv
Copy link
Collaborator

@NikIvv NikIvv commented Dec 16, 2024

No description provided.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 8:06pm

Copy link

github-actions bot commented Dec 16, 2024

Deployed to https://msg-adamant-pr-695.surge.sh 🚀

@NikIvv
Copy link
Collaborator Author

NikIvv commented Dec 16, 2024

Some notes on the current implementations: explorer.btc.com was not accessible during my testing; removed 'Open In Explorer' menu option for USDT and USDC as they have not been described in configs.

src/components/ShareURIDialog.vue Outdated Show resolved Hide resolved
src/components/ShareURIDialog.vue Outdated Show resolved Hide resolved
src/components/ShareURIDialog.vue Outdated Show resolved Hide resolved
@@ -32,7 +40,9 @@
<script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the issues, I suggest you to do a little refactor by rewriting the component using Composition API and TypeScript. Follow the guidelines https://developers.adamant.im/template-classes.html

@bludnic
Copy link
Member

bludnic commented Dec 26, 2024

Some notes on the current implementations: explorer.btc.com was not accessible during my testing; removed 'Open In Explorer' menu option for USDT and USDC as they have not been described in configs.

@NikIvv Bitcoin explorer was replaced in Adamant-im/adamant-wallets#101
We will include these changes in the next release.

@@ -22,6 +22,11 @@
{{ $t('home.show_qr_code') }}
</v-list-item-title>
</v-list-item>
<v-list-item v-if="!isErc" @click="openInExplorer">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC20 tokens also have an address (same as for ETH).
Handle that logic in the openInExplorer method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants