Rae Elwell Weather Report #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Dec 16, 2021
There was a problem hiding this comment.
Great job!
Your code looks pretty solid generally though you rely a little too much on <div>s containing things for styles. (It's not a big deal, it's just a good habit to start doing a final pass in a project and go "do I need this div?".) Otherwise things look good!
Well done!
Comment on lines
+22
to
+24
| <div class = 'widget text' id ='Temperature Title'> | ||
| <p>Temperature</p> | ||
| </div> |
There was a problem hiding this comment.
It's more appropriate to use a heading tag (<h2>, <h3> depending on how nested) for something like a <section> title:
Suggested change
| <div class = 'widget text' id ='Temperature Title'> | |
| <p>Temperature</p> | |
| </div> | |
| <h2 class = 'widget text' id ='Temperature Title'> | |
| Temperature | |
| </h2> |
| skyDisplay.textContent = "☀️ ☀️ ☀️ ☀️ ☀️ ☀️ ☀️ ☀️ ☀️"; | ||
| groundDisplay.textContent ="🌱 🌱 🌱 🌱 🌱 🌱 🌱 🌱"; | ||
| cityInput.textContent = "My Hometown"; | ||
| bgDisplay.style.backgroundColor = "orange"; |
There was a problem hiding this comment.
It's a best practice to avoid directly setting the style of an element in JS. (This is because then we only have one place we need to update styles when we change the theme of the site.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.