Cedar - Laurel #59
Open
Cedar - Laurel #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </head> | ||
| <body> | ||
|
|
||
| <h1 id='display-city'>Seattle</h1> | ||
| <div id=pretty-picture> |
There was a problem hiding this comment.
Minor note: you might consider making the div for each of the sections a section element
| @@ -0,0 +1,240 @@ | |||
| const state = { | |||
There was a problem hiding this comment.
Great use of state object for temp and color class. You might consider making a separate object to hold the constants
| } | ||
| } | ||
|
|
||
| // does it make sense to use state this way? |
There was a problem hiding this comment.
state is generally used to hold the current state of the app, so data that might change
|
|
||
| // HELPER FUNCTIONS | ||
|
|
||
| const styleColorAndLandscape = () => { |
There was a problem hiding this comment.
Great work encapsulating this different functionality in their own functions.
|
|
||
|
|
||
|
|
||
| // this function is responsible for changing two things in one function... |
There was a problem hiding this comment.
Nice work refactoring and DRYing up your code! Remember to remove commented code for the final code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weather Report submission