Leticia -Cedar #89
Open
Leticia -Cedar #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "id": self.task_id, | ||
| "title": self.title, | ||
| "description": self.description, | ||
| "is_complete": self.completed_at is not None |
There was a problem hiding this comment.
This is a clever way to turn self.completed_at into a boolean!
| "is_complete": self.completed_at is not None | ||
| } | ||
|
|
||
| def post_message_on_slack(self): |
There was a problem hiding this comment.
Good work making this a instance method.
| 'channel': "task_notifications", | ||
| 'text': f"Someone just completed the task: {self.title}" | ||
| } | ||
| requests.post(url, data) |
There was a problem hiding this comment.
It looks like there's a small error here. The syntax for sending a request body is requests.pos(url, data=data) https://docs.python-requests.org/en/latest/user/quickstart/#make-a-request
Suggested change
| requests.post(url, data) | |
| requests.post(url, data=data) |
Comment on lines
+87
to
+103
| @tasks_bp.route("/<task_id>/mark_complete", methods=["PATCH"]) | ||
| def mark_complete_on_incomplete_task(task_id): | ||
|
|
||
| task = get_task_from_id(task_id) | ||
|
|
||
| task.completed_at = datetime.date.today() | ||
| db.session.commit() | ||
|
|
||
| task.post_message_on_slack() | ||
| ####i do not know what is missing here### | ||
|
|
||
| @tasks_bp.route("/<task_id>/mark_incomplete", methods=["PATCH"]) | ||
| def mark_incomplete_on_complete_task(task_id): | ||
| task = get_task_from_id(task_id) | ||
|
|
||
| task.completed_at = None | ||
| db.session.commit() |
There was a problem hiding this comment.
These two methods still need to return a response. All route functions are required to return something. It can simply be a response code, but we should look to our tests for what exactly the response should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.