Melinda H. Pine #86
Open
Melinda H. Pine #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Nov 18, 2021
Comment on lines
+32
to
+34
| list = [] | ||
| for task in self.tasks: | ||
| list.append(task.to_dict) |
There was a problem hiding this comment.
I think there's a small bug here:
Suggested change
| list = [] | |
| for task in self.tasks: | |
| list.append(task.to_dict) | |
| list = [] | |
| for task in self.tasks: | |
| list.append(task.to_dict()) |
This loop is also a great candidate for a list comprehension similar to line 28:
Suggested change
| list = [] | |
| for task in self.tasks: | |
| list.append(task.to_dict) | |
| list = [task.to_dict() for task in self.tasks] |
|
|
||
| } | ||
|
|
||
| def check_for_complete_task(self): |
|
|
||
|
|
||
| tasks_bp = Blueprint("tasks_bp", __name__, url_prefix="/tasks") | ||
| def valid_int(number,parameter_type): |
Comment on lines
+36
to
+43
| tasks_response.append( | ||
| { | ||
| "description": task.description, | ||
| "id": task.id, | ||
| "is_complete": False if has_complete == None else has_complete, | ||
| "title": task.title, | ||
| } | ||
| ) |
There was a problem hiding this comment.
This works, I recommend using the to_dict helper function to DRY this section:
Suggested change
| tasks_response.append( | |
| { | |
| "description": task.description, | |
| "id": task.id, | |
| "is_complete": False if has_complete == None else has_complete, | |
| "title": task.title, | |
| } | |
| ) | |
| tasks_response.append(task.to_dict()) |
| @tasks_bp.route("/<task_id>", methods=["GET", "PUT", "DELETE"]) | ||
| def handle_one_task(task_id): | ||
| valid_int(task_id,"task_id") | ||
| task = Task.query.get_or_404(task_id) |
| json_response = jsonify(response) | ||
| return make_response(json_response, 200) | ||
|
|
||
| def slack_bot(title): |
|
|
||
| #Wave 3 | ||
| @tasks_bp.route("/<task_id>/mark_complete", methods=["PATCH"]) | ||
| def handle_completed_task(task_id): |
There was a problem hiding this comment.
Great work, the use of helper functions and get_or_404 in this function really streamline the code!
| tasks = db.relationship("Task", backref="goal", lazy=True) | ||
|
|
||
| def to_dict(self): | ||
| if self.list_of_task_ids(): |
There was a problem hiding this comment.
Storing this result of function call here in a variable (ie task_ids = self.list_of_task_ids()) and then testing could create a slight optimization, because then the variable could be used on line 19 ("task_ids": task_ids) instead of calling the function again.
| goal.title = form_data["title"] | ||
|
|
||
| db.session.commit() | ||
| return jsonify({"goal":{"goal_id":goal.id, "title":goal.title}}),200 |
There was a problem hiding this comment.
Suggested change
| return jsonify({"goal":{"goal_id":goal.id, "title":goal.title}}),200 | |
| return jsonify({"goal":goal.to_dict()}),200 |
|
|
||
| #Wave # 6 | ||
| @goals_bp.route("/<goal_id>/tasks", methods=["POST"]) | ||
| def post_task_ids_to_goal(goal_id): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.