Lia Gaetano task-list #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Nov 8, 2021
| "tasks": tasks | ||
| } | ||
|
|
||
| def update_from_dict(self, data): |
| "id": self.id, | ||
| "title": self.title, | ||
| "description": self.description, | ||
| "is_complete": self.check_if_completed() |
| @require_instance_or_404 | ||
| def get_task(task): | ||
| """Retrieve one stored task by id.""" | ||
| if task.goal_id: |
There was a problem hiding this comment.
This works but to simplify the code I would recommend pushing this check to the to_dict method and add the goal_id key-value pair if goal_id exists inside the to_dict function.
Comment on lines
+48
to
+51
| mandatory_fields = ["title", "description", "completed_at"] | ||
| for field in mandatory_fields: | ||
| if field not in form_data: | ||
| return jsonify({"details": "Invalid data"}), 400 |
| from app.models.task import Task | ||
| from app.models.goal import Goal | ||
|
|
||
| def require_instance_or_404(endpoint): |
| return {"task": new_task.to_dict()}, 201 | ||
|
|
||
| @tasks_bp.route("/<task_id>", methods=["PUT"]) | ||
| @require_instance_or_404 |
There was a problem hiding this comment.
Nice work with this decorator! Setting up task as the parameter in the function makes the code in the function very streamlined!
|
|
||
| for task_id in form_data["task_ids"]: | ||
| query = Task.query.get(task_id) | ||
| if not query: |
There was a problem hiding this comment.
Very minor suggestion, query is a little confusing here as a variable name as the value being stored is a task not a query, I'd recommend something like task or current_task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.