Nourhan - Spruce - C16 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jul 22, 2022
| @@ -23,39 +23,58 @@ def enqueue(self, element): | |||
| In the store are occupied | |||
| returns None | |||
| """ | |||
| pass | |||
| if self.size == INITIAL_QUEUE_SIZE: | |||
There was a problem hiding this comment.
I would suggest using buffer_size over INITIAL_QUEUE_SIZE here. Imagine you alter your implementation so that the buffer_size could expand in certain cases. Then you would have to manually change all of your references to INITIAL_QUEUE_SIZE to maintain your code.
Suggested change
| if self.size == INITIAL_QUEUE_SIZE: | |
| if self.size == self.buffer_size: |
Comment on lines
+28
to
+31
| index = self.rear % self.buffer_size | ||
| self.store[index] = element | ||
| self.rear -= 1 | ||
| self.size += 1 |
There was a problem hiding this comment.
Interesting to decrease the rear pointer instead of increasing it! 😎
| index = self.rear % self.buffer_size | ||
| self.store[index] = element | ||
| self.rear -= 1 | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): | ||
| """ Removes and returns an element from the Queue | ||
| Raises a QueueEmptyException if | ||
| The Queue is empty. | ||
| """ |
| element = self.store[index] | ||
| self.front -= 1 | ||
| self.size -= 1 | ||
| return element | ||
|
|
||
| def front(self): | ||
| """ Returns an element from the front | ||
| of the Queue and None if the Queue | ||
| is empty. Does not remove anything. | ||
| """ |
|
|
||
| def empty(self): | ||
| """ Returns True if the Queue is empty | ||
| And False otherwise. | ||
| """ | ||
| pass | ||
| return self.size == 0 |
|
|
||
| def __str__(self): | ||
| """ Returns the Queue in String form like: | ||
| [3, 4, 7] | ||
| Starting with the front of the Queue and | ||
| ending with the rear of the Queue. | ||
| """ | ||
| pass | ||
| result = [] |
| @@ -12,27 +12,36 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_last(element) | |||
| if self.empty(): | ||
| raise StackEmptyException() | ||
|
|
||
| return self.store.remove_last() |
|
|
||
| def empty(self): | ||
| """ Returns True if the Stack is empty | ||
| And False otherwise | ||
| """ | ||
| pass | ||
| return self.store.empty() |
|
|
||
| def empty(self): | ||
| """ Returns True if the Stack is empty | ||
| And False otherwise | ||
| """ | ||
| pass | ||
| return self.store.empty() | ||
|
|
||
| def __str__(self): | ||
| """ Returns the Stack in String form like: | ||
| [3, 4, 7] | ||
| Starting with the top of the Stack and | ||
| ending with the bottom of the Stack. | ||
| """ |
There was a problem hiding this comment.
✨ This does work, but you could also take advantage of the str method in the LinkedList class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation