Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cedar - Lux Barker #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 47 additions & 7 deletions stacks_queues/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,39 +23,79 @@ def enqueue(self, element):
In the store are occupied
returns None
"""
pass
# is queue full?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫 Very readable implementation!

if self.size == len(self.store):
raise QueueFullException
# is queue empty?
if self.front == -1:
self.front = 0
self.rear = 0
self.store[self.rear] = element
# does rear need to wrap?
elif self.rear == len(self.store) - 1:
self.rear = 0
self.store[self.rear] = element
else:
self.rear += 1
self.store[self.rear] = element
self.size += 1

def dequeue(self):
""" Removes and returns an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
# is queue empty
if self.empty():
raise QueueEmptyException
# grab the element from the front of the queue
element = self.store[self.front]
self.store[self.front] = None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 Really like that you reset value to None in addition to moving the pointer

# check if array is now empty
if self.front == self.rear:
self.front = -1
self.rear = -1
# check if front needs to wrap
elif self.front == len(self.store) - 1:
self.front = 0
else:
self.front += 1
self.size -= 1
return element

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns an element from the front
of the Queue and None if the Queue
is empty. Does not remove anything.
"""
pass

if self.size > 0:
return self.store[self.front]

def size(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns the number of elements in
The Queue
"""
pass
return self.size

def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns True if the Queue is empty
And False otherwise.
"""
pass
return self.size == 0

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns the Queue in String form like:
[3, 4, 7]
Starting with the front of the Queue and
ending with the rear of the Queue.
"""
pass
q = []
start = self.front
while len(q) < self.size:
q.append(self.store[start])
if start < len(self.store) - 1:
start += 1
else:
start = 0
return str(q)

6 changes: 3 additions & 3 deletions stacks_queues/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_first(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def pop(self):
""" Removes an element from the top
Expand All @@ -21,13 +21,13 @@ def pop(self):
The Stack is empty.
returns None
"""
pass
return self.store.remove_first() if not self.empty() else StackEmptyException()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def empty(self):
""" Returns True if the Stack is empty
And False otherwise
"""
pass
return self.store.empty()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Looks like you missed implementing this one!

""" Returns the Stack in String form like:
Expand Down