Citlalli Z- Cedar #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jun 14, 2022
| @@ -15,47 +16,82 @@ def __init__(self): | |||
| self.front = -1 | |||
| self.rear = -1 | |||
| self.size = 0 | |||
|
|
|||
|
|
|||
| def enqueue(self, element): | |||
Comment on lines
+44
to
+46
| if self.size == 0: | ||
| self.front = -1 | ||
| self.rear = -1 |
There was a problem hiding this comment.
I would recommend moving this to after line 52. If the queue is empty to start, it should be caught by your if statement on line 41. However, it may be the case that after dequeueing an element, your queue is now empty and you want to reset the front and rear pointers.
|
|
||
| self.store[self.rear] = element | ||
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): |
There was a problem hiding this comment.
✨ Nice work! Just have one suggestion below ⬇️
| self.front = (self.front + 1) % self.buffer_size | ||
| self.size -= 1 | ||
|
|
||
| return front_item | ||
|
|
||
| def front(self): |
| pass | ||
| if self.front == -1: | ||
| raise QueueEmptyException("Queue is empty") | ||
| return self.store[self.front] | ||
|
|
||
|
|
||
| def size(self): |
| """ | ||
| pass | ||
| self.store.add_first(element) | ||
| return None |
There was a problem hiding this comment.
Functions return None by default. If we aren't returning any other values, we usually prefer to let the function to implicitly return None
Suggested change
| return None |
| @@ -9,30 +9,19 @@ def __init__(self): | |||
| self.store = LinkedList() | |||
|
|
|||
| def push(self, element): | |||
| """ | ||
| pass | ||
| self.store.add_first(element) | ||
| return None | ||
|
|
||
| def pop(self): |
| pass | ||
| if self.store.empty(): | ||
| raise StackEmptyException("Stack is empty.") | ||
| return self.store.remove_first() | ||
|
|
||
| def empty(self): |
| And False otherwise | ||
| """ | ||
| pass | ||
| return self.store.empty() | ||
|
|
||
| def __str__(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation