cedar mac #29
cedar mac #29
Conversation
There was a problem hiding this comment.
Great work on your first Flask project. Your code is clear and readable, and you have successfully implemented all the features. I've left a few comments to consider for the next project on how to handle invalid user input. Please let me know if you have any questions. 🎃
| @planets_bp.route("", methods=["GET", "POST"]) | ||
| def handle_planets(): | ||
| if request.method == "GET": | ||
| name_query = request.args.get("name") |
|
|
||
| elif request.method == "POST": | ||
| request_body = request.get_json() | ||
| new_planet = Planet( |
There was a problem hiding this comment.
Consider how this code would behave if "name" or "description" were missing from the request body. One way to handle this sort of invalid request body is with the following code:
if "name" not in request_body or "description" not in request_body":
return {"error":"incomplete request body", 400
|
|
||
| @planets_bp.route("/<planet_id>", methods=["GET", "PUT", "DELETE"]) | ||
| def handle_planet(planet_id): | ||
| planet = Planet.query.get_or_404(planet_id) |
There was a problem hiding this comment.
Good use of get_or_404. If you were to separate out handle_planet into different functions for each verb, consider how you could move this functionality into a helper function.
There was a problem hiding this comment.
Consider also how this method would behave if planet_id was not an integer. How can we build in error checking for the parameters in the route.
No description provided.