Maple - Stephanie & Ayaka #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Nov 23, 2021
There was a problem hiding this comment.
Wow, wonderful job, Stephani and Ayaka! Your code was very readable, very simple, and understandable. My only feedback for you is to try being more consistent with your return statements when it comes to returning status codes and such. An API's routes should be predictable for other developers to use.
Nicely done!
| id = db.Column(db.Integer, primary_key=True) |
| videos = db.relationship("Video", secondary="rental", backref="customers") | ||
|
|
||
| def to_dict(self): |
| id = db.Column(db.Integer, primary_key=True) |
| is_checked_in = db.Column(db.Boolean, default=False) | ||
|
|
||
| def to_dict(self): |
| id = db.Column(db.Integer, primary_key=True) |
| db.session.delete(video) | ||
| db.session.commit() | ||
|
|
||
| return video.to_dict() |
There was a problem hiding this comment.
Suggested change
| return video.to_dict() | |
| return video.to_dict(), 200 |
|
|
||
| return video.to_dict() | ||
|
|
||
| @videos_bp.route("/<video_id>", methods=["PUT"]) |
|
|
||
| db.session.commit() | ||
|
|
||
| return video.to_dict() |
There was a problem hiding this comment.
Suggested change
| return video.to_dict() | |
| return video.to_dict(), 200 |
|
|
||
| return video.to_dict() | ||
|
|
||
| @videos_bp.route("/<video_id>/rentals", methods=["GET"]) |
| customer["due_date"] = rental.due_date | ||
| customers.append(customer) | ||
|
|
||
| return jsonify(customers) |
There was a problem hiding this comment.
Suggested change
| return jsonify(customers) | |
| return jsonify(customers), 200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.