Maple - Mariama & Rachael #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… routes.py file; registers customers_bp blueprint in app/__init__.py
…y, and adds a separate helpers.py file for shared validation helper methods
…in video_route.py
…details method was repeated twice)
…sed on optional query params
…iting, and pagination functionality for GET requests for videos and customers
spitsfire
reviewed
Nov 30, 2021
| id = db.Column(db.Integer, primary_key=True, autoincrement=True) |
Comment on lines
+21
to
+27
| return Customer( | ||
| name=request_data["name"], | ||
| postal_code=request_data["postal_code"], | ||
| phone=request_data["phone"], | ||
| register_at = datetime.now() | ||
| ) |
There was a problem hiding this comment.
ooo good idea! one thing to think about is, in order to use this method, it already needs an instance, which defeats the purpose of your method. BUT! why don't we change it into a @classmethod?? Now we can call it directly on the class Customer itself!
Suggested change
| def new_customer(self, request_data): | |
| return Customer( | |
| name=request_data["name"], | |
| postal_code=request_data["postal_code"], | |
| phone=request_data["phone"], | |
| register_at = datetime.now() | |
| ) | |
| @classmethod | |
| def new_customer(cls, request_data): | |
| return cls( | |
| name=request_data["name"], | |
| postal_code=request_data["postal_code"], | |
| phone=request_data["phone"], | |
| register_at = datetime.now() | |
| ) |
| id = db.Column(db.Integer, primary_key=True) |
| id = db.Column(db.Integer, primary_key=True, autoincrement=True) |
|
|
||
| customers_bp = Blueprint("customer", __name__, url_prefix="/customers") | ||
|
|
||
| @customers_bp.route("", methods=["GET"]) |
| rentals_response = [rental.to_json() for rental in rentals] | ||
| return jsonify(rentals_response), 200 | ||
|
|
||
| @rentals_bp.route("/check-out", methods=["POST"]) |
|
|
||
| return video_to_check_out.to_json(), 200 | ||
|
|
||
| @rentals_bp.route("/check-in", methods=["POST"]) |
| videos_response = [video.to_json() for video in videos] | ||
| return jsonify(videos_response), 200 | ||
|
|
||
| @videos_bp.route("", methods=["POST"]) |
|
|
||
| return jsonify(video.to_json()), 201 | ||
|
|
||
| @videos_bp.route("/<video_id>", methods=["GET", "PUT", "DELETE"]) |
| db.session.commit() | ||
| return make_response({"id": video.id}, 200) | ||
|
|
||
| @videos_bp.route("<video_id>/rentals", methods=["GET"]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.