forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pine - Tori D. #63
Open
VictoriaDuke
wants to merge
2
commits into
Ada-C16:main
Choose a base branch
from
VictoriaDuke:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,588
−45
Open
Pine - Tori D. #63
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,29 +3,33 @@ import './Board.css'; | |
import Square from './Square'; | ||
import PropTypes from 'prop-types'; | ||
|
||
|
||
const generateSquareComponents = (squares, onClickCallback) => { | ||
// Complete this for Wave 1 | ||
// squares is a 2D Array, but | ||
// squares is a 2D Array, but | ||
// you need to return a 1D array | ||
// of square components | ||
|
||
} | ||
const arr1d = [].concat.apply([], squares); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neat solution! |
||
return arr1d.map((square) => ( | ||
<Square | ||
key={square.id} | ||
value={square.value} | ||
onClickCallback={onClickCallback} | ||
></Square> | ||
)); | ||
}; | ||
Comment on lines
+12
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
const Board = ({ squares, onClickCallback }) => { | ||
const squareList = generateSquareComponents(squares, onClickCallback); | ||
console.log(squareList); | ||
return <div className="grid" > | ||
{squareList} | ||
</div> | ||
} | ||
return <div className="grid">{squareList}</div>; | ||
}; | ||
|
||
Board.propTypes = { | ||
squares: PropTypes.arrayOf( | ||
PropTypes.arrayOf( | ||
PropTypes.shape({ | ||
id: PropTypes.number.isRequired, | ||
value: PropTypes.string.isRequired | ||
value: PropTypes.string.isRequired, | ||
}) | ||
) | ||
), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,37 @@ | ||
import React from 'react'; | ||
import '@testing-library/jest-dom/extend-expect'; | ||
import Square from './Square'; | ||
import { render, screen, fireEvent, waitFor } from '@testing-library/react' | ||
|
||
import { render, screen, fireEvent, waitFor } from '@testing-library/react'; | ||
|
||
describe('Wave 1: Square', () => { | ||
test('it renders with X given', () => { | ||
render(<Square value="X" id={1} onClickCallback={() => { }} />) | ||
const button = screen.getByText("X"); | ||
render(<Square value="X" id={1} onClickCallback={() => {}} />); | ||
|
||
const button = screen.getByText('X'); | ||
|
||
expect(button).toBeInTheDocument(); | ||
}); | ||
|
||
test('it renders with O given', () => { | ||
render(<Square value="O" id={1} onClickCallback={() => { }} />) | ||
const button = screen.getByText("O"); | ||
render(<Square value="O" id={1} onClickCallback={() => {}} />); | ||
|
||
const button = screen.getByText('O'); | ||
|
||
expect(button).toBeInTheDocument(); | ||
}); | ||
}); | ||
|
||
describe('Wave 2: Square', () => { | ||
test.skip('when clicked on it calls the callback function', async () => { | ||
test('when clicked on it calls the callback function', async () => { | ||
const callback = jest.fn(); | ||
|
||
render(<Square value="X" id={1} onClickCallback={callback} />); | ||
// Wait for it to render | ||
await waitFor(() => screen.getByText('X')) | ||
await waitFor(() => screen.getByText('X')); | ||
|
||
const button = screen.getByText('X'); | ||
|
||
fireEvent.click(button); | ||
expect(callback).toHaveBeenCalled(); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section of code isn't working because squares is a 2D array. In this case there may be a way to get
map
to work (perhaps by nesting) but I recommend a nested for loop.