Cedar - Lizet and Kristin #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccaelenzil
reviewed
Jan 3, 2022
| // When it is clicked on. | ||
| // Then pass it into the squares as a callback | ||
| const setSquareValue = (id) => { | ||
| const newSquares = [...squares]; |
| for (let row of newSquares) { | ||
| for (let square of row) { | ||
| if (square.id === id) { | ||
| if (square.value === '') { |
There was a problem hiding this comment.
Great check that the square is empty!
Comment on lines
+38
to
+39
| if (square.id === id) { | ||
| if (square.value === '') { |
There was a problem hiding this comment.
Consider combing with a compound conditional
Comment on lines
+41
to
+45
| if (currentPlayer === PLAYER_1) { | ||
| setCurrentPlayer(PLAYER_2); | ||
| } else { | ||
| setCurrentPlayer(PLAYER_1); | ||
| } |
There was a problem hiding this comment.
This could be a nice place to refactor with a ternary
| const checkForWinner = (squares) => { | ||
| let newWinner; | ||
| let i = 0; | ||
| while (i < 3) { |
There was a problem hiding this comment.
A while loop works, but can be easy to introduce a bug. Consider using a for loop if you're looping a set number of times.
beccaelenzil
reviewed
Jan 6, 2022
| } | ||
| } | ||
| } | ||
| checkForWinner(newSquares); |
There was a problem hiding this comment.
Note that this function is called even after there has been a winner, so a player can continue playing after the other player wins. Consider how you can put in a check to update the winner only if there isn't a current winner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.