Cedar - Kit/Laurel #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alope107
reviewed
Jan 12, 2022
Comment on lines
+30
to
+32
| const [squares, setSquares] = useState(generateSquares()); | ||
| const[winner, setWinner] = useState(null); | ||
| const [currentPlayer, setCurrentPlayer] = useState(PLAYER_1); |
Comment on lines
+34
to
+35
| let i = 0; | ||
| while (i < 3) { |
There was a problem hiding this comment.
Consider using a for loop here instead.
Comment on lines
+76
to
+88
| let newBoard = squares.map((square)=>{ | ||
| for (let property of square){ | ||
| if (property.id === id && property.value === ''){ | ||
| if (currentPlayer === PLAYER_1){ | ||
| property.value = PLAYER_1; | ||
|
|
||
| } else if (currentPlayer === PLAYER_2){ | ||
| property.value = PLAYER_2; | ||
| } | ||
| } | ||
| } | ||
| return square; | ||
| }); |
| header = <h2>Winner is {winner}</h2>; | ||
| } else { | ||
| header = <h2>The Current Player is {currentPlayer}</h2>; | ||
| boardCallback = onClickCallback; |
There was a problem hiding this comment.
Because this callback is only set if there's not a winner weird bugs can arise. For example, if someone wins the game, and then a square is clicked again, your whole React app will crash (not even the reset button will work anymore). Consider ways you can resolve this by always passing a callback but having it do different things if the game is won or not.
| return ( | ||
| <div className="App"> | ||
| <header className="App-header"> | ||
| <h1>React Tic Tac Toe</h1> | ||
| <h2>The winner is ... -- Fill in for wave 3 </h2> | ||
| <button>Reset Game</button> | ||
| {header} |
| <Square value={square.value} | ||
| id={square.id} | ||
| onClickCallback={onClickCallback} | ||
| key={square.id} |
|
|
||
| } | ||
|
|
||
| const singleSquares = [].concat(...squares); |
There was a problem hiding this comment.
This can be done slightly simpler with const singleSquares = [...squares];
| // Component to alert a parent | ||
| // component when it's clicked on. | ||
|
|
||
| const hardestButtonToButton = () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tic-tac-toe submission