Spruce - Asha P.

[ashapa]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	No
Why is it important to consider and use semantic HTML?	It helps to add clearer meaning to the structure of the content on the page.
How did you decide to structure your CSS?	It's structured as if all the styled pages were on one long continuous scrollable page. It starts with the most general styling, then the nav all the way down to the footer.
What was the most challenging piece of this assignment?	Working to incorporate both CSS Flexbox and CSS Grid had its challenges because some properties did not work how I thought they would.
Describe one area that you gained more clarity on when completing this assignment	I gained a better understanding of using class selectors to add similar styling across multiple elements.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?	N/A

[audreyandoy]

Great work Asha! The color scheme and design of your portfolio are really pretty. I can tell you had a lot of fun with HTML/CSS in this project 😄

Here are my recommendations for your portfolio:

• Portfolio
  • Add a short description about your projects so visitors can get an idea of what the project is prior to clicking on your github repo. This description can be a short sentence and a list of the technologies used.
• About
  • Include a blurb about your career and learnings from Ada, why you like tech etc.
    Include a pdf of your resume
• Contact
  • This is a beautiful form but didn't appear to be working? You'll need to add some javascript logic to this form in order for it to actually send to your email.

Whenever you have the chance to revisit frontend development here's a great list of different resources to check out:

https://dev.to/nickytonline/frontend-developer-resources-2022-4cp2
Project Grade: 🟢

[audreyandoy]

I recommend moving this file, index.html, to the top level of this project, especially if you consider this file as the 'homepage' or the starting point of your site. In general, moving index.html to the root is a pretty standard way of setting up a static project. However, web servers can be configured to point to any file but it tends to be easier to point to the index.html file at the root of the project, rather one that's nested within the directory.

[audreyandoy]

If you move index.html to the project root, the path to style.css would be:

Suggested change

	<link rel="stylesheet" href="/styles/style.css">
	<link rel="stylesheet" href="./styles/style.css">

[audreyandoy]

Suggested change

	<div class="logo"><a href="/pages/index.html" target="_blank" rel="noopener noreferrer">Asha<span>Paul</span></a></div>
	<ul class="menu">
	<li><a href="/pages/portfolio.html" class="menu-btn" target="_blank" rel="noopener noreferrer">Portfolio</a></li>
	<li><a href="/pages/about.html" class="menu-btn" target="_blank" rel="noopener noreferrer">About</a></li>
	<li><a href="/pages/contact.html" class="menu-btn" target="_blank" rel="noopener noreferrer">Contact</a></li>
	<div class="logo"><a href="./pages/index.html" target="_blank" rel="noopener noreferrer">Asha<span>Paul</span></a></div>
	<ul class="menu">
	<li><a href="./pages/portfolio.html" class="menu-btn" target="_blank" rel="noopener noreferrer">Portfolio</a></li>
	<li><a href="./pages/about.html" class="menu-btn" target="_blank" rel="noopener noreferrer">About</a></li>
	<li><a href="./pages/contact.html" class="menu-btn" target="_blank" rel="noopener noreferrer">Contact</a></li>

[audreyandoy]

Nice work opening the links into a new tab! While it's not very common to open different parts of your site into a new tab, it is especially useful for external links (external as an outside of your site project). I highly recommend you continue to use the target and rel attributes for anchor tags when you decide to add your github repos, deployed apps, LinkedIn, and resume.

[audreyandoy]

Because you only have one column for your entire page, it's not necessary to use grid. But good work finding a way to practice using CSS grid.

[audreyandoy]

Great work using flexbox!