Sandra Caballero-Spruce #85
Conversation
| background:rgb(255,160,122); | ||
| } | ||
|
|
||
| .grid-container { |
There was a problem hiding this comment.
It looks like there's quite a lot of repetition in the CSS files. Try to extract as many of the rules into the general style file, and then only put the differences into per-page style files. Then on the various pages, simply link both the general and the per-page CSS file, with the per-page file coming second. It will override the general style rules, cutting down significantly on the duplication between files.
| } | ||
|
|
||
| img{ | ||
| display:flexbox; |
There was a problem hiding this comment.
It shouldn't be necessary to explicitly set the display to flexbox. So long as the img is a child of an element marked as display flex, then the other flex rules will apply.
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Bebas+Neue&family=Readex+Pro:wght@200&display=swap" rel="stylesheet"> |
| <title> Sandra P Caballero </title> | ||
| </head> | ||
| <body> | ||
| <div> |
There was a problem hiding this comment.
Consider using a nav tag, since this section groups together the main navigation links.
| <div class="grid-spacing"> <a href="portfolio.html">Portfolio</a></div> | ||
| </div> | ||
| </div> | ||
| </main> |
There was a problem hiding this comment.
This looks like a stray closing tag (running through a validator can catch things like this).
| </head> | ||
| <body> | ||
| <header> | ||
| <center><h1>Programming Portfolio</h1></center> |
There was a problem hiding this comment.
The center tag shouldn't be used anymore. We should use style rules (such as text-align) to achieve centered text.
| <p> | ||
| ✨Thank you for visiting✨ | ||
| </p> | ||
| </body> |
There was a problem hiding this comment.
Missing the closing footer tag here. A validator can help us catch issues like this.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions