-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cedar-Bailey #75
base: master
Are you sure you want to change the base?
Cedar-Bailey #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I noticed a couple of little things (the mis-used h3
and the copy/pasting styles) but everything looks great for this being your first major HTML/CSS project!
This is an awesome start, well done!
@@ -4,9 +4,48 @@ | |||
<meta charset="UTF-8"> | |||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
<title>Document</title> | |||
<title>About Me</title> | |||
<link href="../styles/about-style.css" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually import multiple stylesheets so you could have one that had all your shared styles and then a separate one per page (you mentioned wanting to DRY up your CSS):
<link href="../styles/about-style.css" rel="stylesheet"> | |
<link href="../styles/common-style.css" rel="stylesheet"> | |
<link href="../styles/about-style.css" rel="stylesheet"> |
</article> | ||
<article> | ||
<h2><a href="https://github.com/beaniebaye/adagrams-py">Adagrams</a></h2> | ||
<h3>In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably just be a styled paragraph, not a <h3>
. The reason is because you wouldn't want to put In Collaboration with
... as an entry in your table of contents:
<h3>In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></h3> | |
<p class="collaboration-note">In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></p> |
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions