Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cedar-Bailey #75

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Cedar-Bailey #75

wants to merge 7 commits into from

Conversation

beaniebaye
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, on my portfolio page the validator suggested that I add a header tag under the section tag.
Why is it important to consider and use semantic HTML? To make your web page as accessible as possible. The overall concept of that makes sense, but I am worried I wasn't able to do that effectively.
How did you decide to structure your CSS? A separate CSS file for each page, contained in a styles folder.
What was the most challenging piece of this assignment? Honestly it was really difficult to just come up with idea of how I wanted my website to look. I also don't think that my CSS is very DRY but I look forward to improving on the next project.
Describe one area that you gained more clarity on when completing this assignment EVERYTHING, I don't feel particularly comfortable with HTML/CSS so this was a nice learning opportunity and I hope that I can push myself further on the next frontend project.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? No I did not.

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I noticed a couple of little things (the mis-used h3 and the copy/pasting styles) but everything looks great for this being your first major HTML/CSS project!

This is an awesome start, well done!

@@ -4,9 +4,48 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<title>About Me</title>
<link href="../styles/about-style.css" rel="stylesheet">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually import multiple stylesheets so you could have one that had all your shared styles and then a separate one per page (you mentioned wanting to DRY up your CSS):

Suggested change
<link href="../styles/about-style.css" rel="stylesheet">
<link href="../styles/common-style.css" rel="stylesheet">
<link href="../styles/about-style.css" rel="stylesheet">

</article>
<article>
<h2><a href="https://github.com/beaniebaye/adagrams-py">Adagrams</a></h2>
<h3>In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be a styled paragraph, not a <h3>. The reason is because you wouldn't want to put In Collaboration with... as an entry in your table of contents:

Suggested change
<h3>In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></h3>
<p class="collaboration-note">In Collaboration with <a href="https://github.com/jacyyang04" class="partner">Jacy Yang</a></p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants