Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sierra Pine #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sierra Pine #69

wants to merge 2 commits into from

Conversation

heysierra
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? nah.
Why is it important to consider and use semantic HTML? for readability!
How did you decide to structure your CSS? flex boxes first, content style second, two separate style sheets.
What was the most challenging piece of this assignment? formatting content.
Describe one area that you gained more clarity on when completing this assignment Flex Box!
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sierra, the site looks ok, if a bit bare. You also had it fairly nicely styled. I found a few small mistakes, but overall this is a solid submission.

<ul>
<li><a href="https://github.com/heysierra/" target="_blank" rel="noopener noreferrer"><i class="fab fa-github"></i></a></li>
<li><a href="https://www.linkedin.com/in/sierra-parsons-1320a21a1" target="_blank" rel="noopener noreferrer"><i class="fab fa-linkedin"></i></a></li>
<li><a href = "mailto: [email protected]" target="_blank" rel="noopener noreferrer"><i class="fas fa-at"></i></a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href = "mailto: [email protected]" target="_blank" rel="noopener noreferrer"><i class="fas fa-at"></i></a></li>
<li><a href="mailto:[email protected]" target="_blank" rel="noopener noreferrer"><i class="fas fa-at"></i></a></li>

</article>
<section>

<div class = "grid-3-columns">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div is not closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants