Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cedar - Laurel #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

paperbackwriter2
Copy link

@paperbackwriter2 paperbackwriter2 commented Dec 1, 2021

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? No. But I do have an image that was flagged for having a space in its file name.
Why is it important to consider and use semantic HTML? This helps accessibility and also helps keep your page organized.
How did you decide to structure your CSS? I decided to keep a separate stylesheet for each of my pages.
What was the most challenging piece of this assignment? I did not know how to keep things organized and I really did not create a responsive site. I've really been struggling with understanding how these front-end technologies work.
Describe one area that you gained more clarity on when completing this assignment I gained more clarity in using css grid, though I'm not sure if I necessarily used it the way it was intended.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@paperbackwriter2 paperbackwriter2 changed the title Add html, stylesheets and images Cedar - Laurel Dec 1, 2021
Copy link

@beccaelenzil beccaelenzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this creative project. Good use of classes to style your site. I've left a few inline comments. The biggest piece is to make sure that you have the correct paths to the different pages and style sheets -- the viewer in VSCode doesn't catch this bug. Please let me know if you have any questions. Nice work!

@@ -5,8 +5,31 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link href="/styles/styles-about.css" rel="stylesheet">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the .. to get the correct path. The VSCode extension doesn't catch this issue with the path. It is also true for the images directory.

Suggested change
<link href="/styles/styles-about.css" rel="stylesheet">
<link href="../styles/styles-about.css" rel="stylesheet">

</head>
<body>

<body class="grid-container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a convention to organize the files such that index.html is at the project root director level, and the rest of the pages are in a pages directory.

<img src="/images/cursor-png-1111.png" />
</div>
</li>
<li><a class="active" href="index.html">Home</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the use of the active class for styling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants