-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cedar - Laurel #66
base: master
Are you sure you want to change the base?
Cedar - Laurel #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this creative project. Good use of classes to style your site. I've left a few inline comments. The biggest piece is to make sure that you have the correct paths to the different pages and style sheets -- the viewer in VSCode doesn't catch this bug. Please let me know if you have any questions. Nice work!
@@ -5,8 +5,31 @@ | |||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
<title>Document</title> | |||
<link href="/styles/styles-about.css" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the ..
to get the correct path. The VSCode extension doesn't catch this issue with the path. It is also true for the images
directory.
<link href="/styles/styles-about.css" rel="stylesheet"> | |
<link href="../styles/styles-about.css" rel="stylesheet"> |
</head> | ||
<body> | ||
|
||
<body class="grid-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a convention to organize the files such that index.html
is at the project root director level, and the rest of the pages are in a pages
directory.
<img src="/images/cursor-png-1111.png" /> | ||
</div> | ||
</li> | ||
<li><a class="active" href="index.html">Home</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the use of the active
class for styling!
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions