Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cedar - Makhabat M. #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

makhabatmaksatbekova
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Had to remove unnecessary, and put closing tag.
Why is it important to consider and use semantic HTML? to have meaningful tags and information inside is helpful for code readability.
How did you decide to structure your CSS? I used the grid for the main page's layout, as each section is a grid box. For the portfolio page, I used flex boxes.
What was the most challenging piece of this assignment? stop playing with CSS and choose one style over another one. Always wanted to make it perfect.
Describe one area that you gained more clarity on when completing this assignment I had experience with grid, so it was a good repetition for me.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? No, I did not.

Copy link

@beccaelenzil beccaelenzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this creative project. You've created a nice, clean layout. Nice use of placeholder links in your footer to develop later. I've left a few in-line comments for you to review. Please let me know if you have any questions.


<section class="about_me">
<h1>Passion</h1>
<h3>Software Engineering</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we don't want to skip from an h1 to and h3. We can use a class name to apply the styling we are looking for.

Suggested change
<h3>Software Engineering</h3>
<h2 class="passion-detail">Software Engineering</h2>

<h3>Tulpar-Kol Lake in the Alay Valley of southern Kyrgyzstan</h3>
</section>
</main>
<footer class="footer">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This footer is in the middle of your portfolio page. There are many different ways to apply styles to move it to the bottom. Consider the approach you would like to take here.

<title>Contact me</title>
<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css">
<link rel="stylesheet" href="../stylesheets/index.css">
<style>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we prefer including styles in a separate style sheet.

@@ -4,9 +4,37 @@
<meta charset="UTF-8">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a convention to include index.html at the project root level and additional pages in a directory such as pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants