-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cedar - Makhabat M. #65
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this creative project. You've created a nice, clean layout. Nice use of placeholder links in your footer to develop later. I've left a few in-line comments for you to review. Please let me know if you have any questions.
|
||
<section class="about_me"> | ||
<h1>Passion</h1> | ||
<h3>Software Engineering</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we don't want to skip from an h1 to and h3. We can use a class name to apply the styling we are looking for.
<h3>Software Engineering</h3> | |
<h2 class="passion-detail">Software Engineering</h2> |
<h3>Tulpar-Kol Lake in the Alay Valley of southern Kyrgyzstan</h3> | ||
</section> | ||
</main> | ||
<footer class="footer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This footer is in the middle of your portfolio page. There are many different ways to apply styles to move it to the bottom. Consider the approach you would like to take here.
<title>Contact me</title> | ||
<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css"> | ||
<link rel="stylesheet" href="../stylesheets/index.css"> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we prefer including styles in a separate style sheet.
@@ -4,9 +4,37 @@ | |||
<meta charset="UTF-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a convention to include index.html at the project root level and additional pages in a directory such as pages
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions