Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diana's Portfolio #64

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"recommendations": [
"negokaz.live-server-preview"
]
}
Binary file added images/Astronaut.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Astronaut3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/AstronautDahlia.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/AstronautSof.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Colombia.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Dahlia B.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Dahlia.webp
Binary file not shown.
Binary file added images/Dahlia2.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Dahlia3.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Dahlia4.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Deathstar.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Howls3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Kiki.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Maya2.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Maya3.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Maya4.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Maya5.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Mononoke.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Ponyo.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Screenshot (21).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Sof1.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Sof2.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Sof4.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Sof5.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Sof6.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Solar system.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Spirited.jpeg
Binary file added images/Sully.jpg
Binary file added images/Sully1.jpeg
Binary file added images/Sully2.jpeg
Binary file added images/Sully3.jpeg
Binary file added images/Sully5.jpeg
Binary file added images/Sully6.jpeg
Binary file added images/Supermassiveblackhole.png
Binary file added images/Task list.jpeg
Binary file added images/Viewing party.jpeg
Binary file added images/pinkspace.jpeg
Binary file added images/spacebg.jpeg
Binary file added images/swap meet.jpeg
33 changes: 33 additions & 0 deletions pages/Dahlia.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<html lang="en" class="Dahlia">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<h1 class="Dahlia">Dahlia</h1>
</header>
<img class="dahlia-img" src="/images/Dahlia.webp" alt="Dahlia">
<img class="dahlia-img" src="/images/Dahlia2.jpeg" alt="Weasel">
<img class="dahlia-img" src="/images/Dahlia4.jpeg" alt="Growth">

<main class="dahlia-text">
<ul>
<p>Age: 10 months old</p>
<p>Breed: Husky</p>
<p>Loves to:
<li>Hunt Maya</li>
<li>Eat the house she lives in</li>
<li>Run around like a crazy dog</li>
<li>Interrupt Diana during class</li>
</p>
<p>Main Jobs: Make sure Diana goes on a walk at least once a day and act as Weasel's body double</p>
</ul>
</main>

</body>
</html>
34 changes: 34 additions & 0 deletions pages/Maya.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<!DOCTYPE html>
<html lang="en" class="Maya">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<h1 class="Maya">Maya</h1>
</header>
<img class="maya-img" src="/images/Maya2.jpeg" alt="Lion">
<img class="maya-img" src="/images/Maya3.jpeg" alt="Pikachu">
<img class="maya-img" src="/images/Maya4.jpeg" alt="Smile">
<img class="maya-img" src="/images/Maya5.jpeg" alt="Lion">
<main class="maya-text">
<ul>
<p>Age: 7 years old</p>
<p>Breed: Shiba</p>
<p>Loves to:
<li>Run!</li>
<li>Be left alone</li>
<li>Guard the house</li>
<li>Bark at Dahlia</li>
<li>Clean the other dog's teeth</li>
</p>
<p>Main Job: Make sure Diana goes on a run a couple of times a week</p>
</ul>
</main>

</body>
</html>
34 changes: 34 additions & 0 deletions pages/Sofia.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<!DOCTYPE html>
<html lang="en" class="Sofia">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<h1 class="Sofia">Sofia</h1>
</header>
<img class="sofia-img" src="/images/Sof1.jpeg" alt="Sofia">
<img class="sofia-img" src="/images/Sof2.jpeg" alt="Minnie">
<img class="sofia-img" src="/images/Sof4.jpeg" alt="Snow white">
<img class="sofia-img" src="/images/Sof6.jpeg" alt="Family">
<main class= "sofia-text">
<ul>
<p>Age: 7 years old</p>
<p>Breed: Maltipoo</p>
<p>Loves to:
<li>Cuddle</li>
<li>Eat anything that falls off the counters and tables</li>
<li>Sleep all day long</li>
<li>Go on adventures in her backpack, sometimes walk</li>
<li>Kiss Sully</li>
</p>
<p>Main Jobs: Currently retired from being a nanny dog for 5 years. Sometimes she becomes Diana's little pillow</p>
</ul>
</main>

</body>
</html>
32 changes: 32 additions & 0 deletions pages/Sully.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<!DOCTYPE html>
<html lang="en" class="Sully">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<h1 class="Sully">Sully</h1>
</header>
<img class="sully-img" src="/images/Sully1.jpeg" alt="Pikachu">
<img class="sully-img" src="/images/Sully2.jpeg" alt="Smile">
<img class="sully-img" src="/images/Sully3.jpeg" alt="Lion">
<main class="sully-text">
<ul>
<p>Age: 4 years old</p>
<p>Breed: Lab mix</p>
<p>Loves to:
<li>Chase small animals</li>
<li>Eat anything</li>
<li>Sleep all day long</li>
<li>Play with water</li>
<li>Bark at anything or anyone who dares to come near his house</li>
</p>
<p>Main Jobs: Provide lots of cuddles and act as Diana's bodyguard. Pikachu's body double</p>
</ul>
</main>
</body>
</html>
24 changes: 23 additions & 1 deletion pages/about.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,34 @@
<!DOCTYPE html>
<html lang="en">
<html lang="en" class="about-D">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<hi class="about-header">Hola!</hi>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be h1

Suggested change
<hi class="about-header">Hola!</hi>
<h1 class="about-header">Hola!</h1>

</header>
<main>
<img class="about-img" src="/images/Screenshot (21).png" alt="Diana">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use relative paths. Also img is a self-closing element. Also in general for web servers it's a bad idea to use spaces in file names.

Suggested change
<img class="about-img" src="/images/Screenshot (21).png" alt="Diana">
<img class="about-img" src="../images/Screenshot (21).png" alt="Diana" />

<ul>
<p class="Dianas-paragraph">My name is Diana, I am a current student at ADA, on my way to become a full stack programmer</p>
<p class="Dianas-paragraph">I love to create things, I love my dogs, I love to travel </p>
<p class="Dianas-paragraph">Tools/languages I can use:
Comment on lines +16 to +19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only li should be a child of ul

Suggested change
<ul>
<p class="Dianas-paragraph">My name is Diana, I am a current student at ADA, on my way to become a full stack programmer</p>
<p class="Dianas-paragraph">I love to create things, I love my dogs, I love to travel </p>
<p class="Dianas-paragraph">Tools/languages I can use:
<p class="Dianas-paragraph">My name is Diana, I am a current student at ADA, on my way to become a full stack programmer</p>
<p class="Dianas-paragraph">I love to create things, I love my dogs, I love to travel </p>
<p class="Dianas-paragraph">Tools/languages I can use:
<ul>

<li class="Dianas-paragraph">Python</li>
<li class="Dianas-paragraph">Flask</li>
<li class="Dianas-paragraph">Postman</li>
<li class="Dianas-paragraph">SQL</li>
<li class="Dianas-paragraph">Heroku</li>
<li class="Dianas-paragraph">Github</li>
<p class="Dianas-paragraph">Feel free to explore my previous projects:</p>
<a class ="Dianas-paragraph" href="portfolio.html">My creations</a>

</p>
</ul>
Comment on lines +26 to +30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be after the list

Suggested change
<p class="Dianas-paragraph">Feel free to explore my previous projects:</p>
<a class ="Dianas-paragraph" href="portfolio.html">My creations</a>
</p>
</ul>
</ul>
<p class="Dianas-paragraph">Feel free to explore my previous projects:</p>
<a class ="Dianas-paragraph" href="portfolio.html">My creations</a>
</p>

</main>

</body>
</html>
18 changes: 16 additions & 2 deletions pages/index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,26 @@
<!DOCTYPE html>
<html lang="en">
<!DOCTYPE html >
<html lang="en" class="Index">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>
<header>
<h1> Welcome to Diana's Portfolio </h1>
</header>
<a href="/pages/portfolio.html"><img class= "Dianaport" src="/images/Supermassiveblackhole.png"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For accessibility your img elements should have an alt attribute.

Suggested change
<a href="/pages/portfolio.html"><img class= "Dianaport" src="/images/Supermassiveblackhole.png"></a>
<a href="/pages/portfolio.html"><img class= "Dianaport" src="/images/Supermassiveblackhole.png" alt="supermassive black hole" /></a>

<a href="/pages/about.html"><img class= "Dianabout" src="/images/Deathstar.png"></a>
<main>
<!--Creating links to the other pages-->
<a href="/pages/Maya.html"><img class= "DogMaya" src="/images/Astronaut3.png"></a>
<a href="/pages/Sully.html"><img class= "DogSul" src="/images/Astronaut.png"></a>
<a href="/pages/Dahlia.html"><img class= "DogDahl" src="/images/AstronautDahlia.png"></a>
<a href="/pages/Sofia.html"><img class= "DogSof" src="/images/AstronautSof.png"></a>

</main>

</body>
</html>
10 changes: 8 additions & 2 deletions pages/portfolio.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<!DOCTYPE html>
<html lang="en">
<html lang="en" class="Portfolio">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="../style.css">
<title>Document</title>
</head>
<body>

<header>
<h1 class="Portfolio"></h1>Projects</header>
<div class="portfolio-text"><a class="portfolio-text" href="https://github.com/DLozanoC/task-list-api.git"><img class="image" src="/images/Task list.jpeg" alt="Task List API"><div class="middle"><div class="text">Task List API</div></div></div>
<div class="portfolio-text"><a class="portfolio-text" href="https://github.com/DLozanoC/solar-system-api.git"><img class="image" src="/images/Solar system.jpeg" alt="Solar System API"><div class="middle"><div class="text">Solar system API</div></div></div>
<div class="portfolio-text"><a class="portfolio-text" href="https://github.com/DLozanoC/swap-meet.git"><img class="image"src="/images/swap meet.jpeg" alt="Swap Meet" ><div class="middle"><div class="text">Swap Meet</div></div></div>
<div class="portfolio-text"><a class="portfolio-text" href="https://github.com/DLozanoC/viewing-party.git"><img class="image" src="/images/Viewing party.jpeg" alt="Viewing Party"><div class="middle"><div class="text">Viewing Party</div></div></div>
</body>
</html>
Loading