Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruiz #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ruiz #73

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 161 additions & 35 deletions linked_list/linked_list.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@

# Defines a node in the singly linked list
from calendar import c


class Node:

def __init__(self, value, next_node = None):
Expand All @@ -16,64 +19,152 @@ def __init__(self):
# Time Complexity: ?
# Space Complexity: ?
Comment on lines 19 to 20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱🪐 Time and space complexity?

def get_first(self):
pass
if self.head:
return self.head.value
return None



# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(1)
# Space Complexity: o(1)
def add_first(self, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
self.head = Node(value, self.head)



# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def search(self, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
return False
if self.head.value == value:
return True

current = self.head
while current.next:
if current.next.value == value:
return True
current = current.next

return False

# method that returns the length of the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def length(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
return 0

current = self.head
count = 0
while current:
count += 1
current = current.next
return count

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns None if there are fewer nodes in the linked list than the index value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: o(1)
def get_at_index(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if self.length() <= index:
return None

current = self.head
count = 0

while current:
if count == index:
return current.value
count += 1
current = current.next
return None



# method that returns the value of the last node in the linked list
# returns None if the linked list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def get_last(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
return None
current = self.head
while current.next:
current = current.next
return current.value
# return self.tail.value

# method that inserts a given value as a new last node in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def add_last(self, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
self.add_first(value)
else:
new_node = Node(value)
current = self.head
while current.next:
current = current.next
current.next = new_node

# method to return the max value in the linked list
# returns the data value and not the node
def find_max(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
return None
current = self.head
max = current.value

while current:
if max < current.value:
max = current.value
current = current.next
return max

# method to delete the first node found with specified value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def delete(self, value):
pass
if not self.head:
return
# current = self.head
elif current.value == value:
Comment on lines +136 to +137

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now you are referencing current before it exists

Suggested change
# current = self.head
elif current.value == value:
current = self.head
if current.value == value:

self.head = current.next
return True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to return a value here

Suggested change
return True
return

else:
current = self.head
while current.next and current.next.value != value:
current = current.next
current.next = current.next.next
# if self.head:
# self.head.previous = None
# if not self.head:
# self.tail = None
# return None

# previous = current

# while current.next:
# if current.next.value == value:
# current.next = current.next.next
# if current.next:
# current.next.previous = current
# if not current.next:
# self.tail = current

# return None



# method to print all the values in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪐 Space complexity will be O(n) here since you are creating the list helper_list which will end up holding all of the nodes in the linked list

def visit(self):
helper_list = []
current = self.head
Expand All @@ -86,32 +177,67 @@ def visit(self):

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def reverse(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
if not self.head:
return None

prev = None
current = self.head

while current:
next = current.next
current.next = prev
prev = current
current = next
self.head = prev

## Advanced/ Exercises
# returns the value at the middle element in the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def find_middle_value(self):
pass
temp =self.head
count = 0
while self.head:
count += 1
self.head = self.head.next
self.head = temp
if count % 2 == 0:
return self.get_at_index(count//2)
else:
return self.get_at_index(count//2 + 1) # return the value at the middle index
# Time Complexity: O(n)

# Space Complexity: O(1)

# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)
def find_nth_from_end(self, n):
pass
i = 0
if not self.head:
return None
return self.get_at_index(self.length() - n - 1)

# Time Complexity: O(n)

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
# Time Complexity: ?
# Space Complexity: ?
def has_cycle(self):
pass
# curr = head
s = set()
while curr:
if curr in s:
return True
s.add(curr)
curr = curr.next
return False

# Helper method for tests
# Creates a cycle in the linked list for testing purposes
Expand Down
12 changes: 6 additions & 6 deletions tests/linked_list_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def test_reverse_will_reverse_five_element_list(list):
for i in range(0, 5):
assert list.get_at_index(i) == i

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_middle_value_returns_middle_element_of_five_element_list(list):
list.add_first(10)
list.add_first(30)
Expand All @@ -206,7 +206,7 @@ def test_find_middle_value_returns_middle_element_of_five_element_list(list):
list.add_first(20)
assert list.find_middle_value() == 50

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_middle_value_returns_element_at_index_two_of_six_element_list(list):
list.add_first(10)
list.add_first(30)
Expand All @@ -216,11 +216,11 @@ def test_find_middle_value_returns_element_at_index_two_of_six_element_list(list
list.add_first(100)
assert list.find_middle_value() == 60

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_nth_from_n_when_list_is_empty(list):
assert list.find_nth_from_end(3) == None

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_nth_from_n_when_length_less_than_n(list):
list.add_first(5)
list.add_first(4)
Expand All @@ -230,7 +230,7 @@ def test_find_nth_from_n_when_length_less_than_n(list):

assert list.find_nth_from_end(6) == None

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_nth_from_n(list):
list.add_first(1)
list.add_first(2)
Expand All @@ -243,7 +243,7 @@ def test_find_nth_from_n(list):
assert list.find_nth_from_end(3) == 4
assert list.find_nth_from_end(4) == None

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_has_cycle(list):
assert list.has_cycle() == False

Expand Down