Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaina Beth C16 Spruce #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 94 additions & 30 deletions linked_list/linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,67 +13,126 @@ def __init__(self):

# returns the value in the first node
# returns None if the list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head == None:
return None
return self.head.value


# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def add_first(self, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
new_head = Node(value, self.head)
self.head = new_head

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def search(self, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
cur = self.head
while cur != None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one way we can shorten this is by:

Suggested change
while cur != None:
while cur:

if cur.value == value:
return True
cur = cur.next
return False

# method that returns the length of the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def length(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
cur = self.head
i = 0
while cur != None:
cur = cur.next
i += 1
return i

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns None if there are fewer nodes in the linked list than the index value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_at_index(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
cur = self.head
for i in range(index):
if cur == None:
return None
cur = cur.next
Comment on lines +62 to +65

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works! though it's not very common. I'd recommend using a while loop to stay consistent with the rest of your methods

return cur.value


# method that returns the value of the last node in the linked list
# returns None if the linked list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_last(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head == None:
return None
cur = self.head
prev = None
while cur != None:
prev = cur
cur = cur.next
return prev.value
Comment on lines +76 to +81

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another way we can do this to save a variable is starting the while loop at while cur.next != None:

Suggested change
cur = self.head
prev = None
while cur != None:
prev = cur
cur = cur.next
return prev.value
cur = self.head
while cur.next != None:
cur = cur.next
return cur.value


# method that inserts a given value as a new last node in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def add_last(self, value):
pass
if self.head == None:
self.head = Node(value, None)
return
cur = self.head
prev = None
while cur != None:
prev = cur
cur = cur.next
prev.next = Node(value, None)
Comment on lines +91 to +95

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above! we can start our while loop at while curnext ! None:

Suggested change
prev = None
while cur != None:
prev = cur
cur = cur.next
prev.next = Node(value, None)
while cur.next != None:
cur = cur.next
cur.next = Node(value, None)



# method to return the max value in the linked list
# returns the data value and not the node
def find_max(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head == None:
return None
cur = self.head
cur_max = cur.value
cur = cur.next
while cur != None:
if cur.value > cur_max:
cur_max = cur.value
cur = cur.next
return cur_max


# method to delete the first node found with specified value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def delete(self, value):
pass
if self.head == None:
return None
if self.head.value == value:
self.head = self.head.next

prev = self.head
cur = self.head.next
while cur != None and cur.value != value:
prev = cur
cur = cur.next

if cur != None:
prev.next = cur.next
Comment on lines +122 to +129

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works! let's take away one of the variables, though. again, let's start the while loop with cur.next != None:

Suggested change
prev = self.head
cur = self.head.next
while cur != None and cur.value != value:
prev = cur
cur = cur.next
if cur != None:
prev.next = cur.next
cur = self.head
while cur.next != None and cur.next.value != value:
cur = cur.next
cur.next = cur.next.next




# method to print all the values in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def visit(self):
helper_list = []
current = self.head
Expand All @@ -86,10 +145,15 @@ def visit(self):

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def reverse(self):
pass
cur = self.head
last_made = None
while cur != None:
last_made = Node(cur.value, last_made)
cur = cur.next
self.head = last_made
Comment on lines +151 to +156

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm we shouldn't be adding nodes, only reversing the pointers so the last node is now the head and vice versa.

It's commonly done with three pointers: previous, current, and future node


## Advanced/ Exercises
# returns the value at the middle element in the singly linked list
Expand Down