Makhabat - Cedar #62
Open
Makhabat - Cedar #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jul 12, 2022
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
| if self.head == None: | ||
| return False | ||
| current = self.head | ||
| while current != None: |
There was a problem hiding this comment.
we can shorten this to:
Suggested change
| while current != None: | |
| while current: |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
| pass | ||
| lenght = 0 | ||
| current = self.head | ||
| while current != None: |
There was a problem hiding this comment.
Suggested change
| while current != None: | |
| while current: |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def add_last(self, value): |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def visit(self): |
| def visit(self): | ||
| helper_list = [] | ||
| current = self.head | ||
|
|
||
| while current: | ||
| helper_list.append(str(current.value)) | ||
| current = current.next | ||
|
|
||
|
|
||
| print(", ".join(helper_list)) | ||
|
|
||
| # method to reverse the singly linked list | ||
| # note: the nodes should be moved and not just the values in the nodes | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def reverse(self): |
Comment on lines
146
to
147
| # Time Complexity: ? | ||
| # Space Complexity: ? |
There was a problem hiding this comment.
What do you think the space and time complexity of this is? Is the time complexity dependent on the length of the linked list? Is there any new variables being created that grow larger depending upon the input?
| @@ -1,96 +1,165 @@ | |||
|
|
|||
| # Defines a node in the singly linked list | |||
| class Node: | |||
| from platform import node | |||
There was a problem hiding this comment.
where is this coming from? You've created your own Node class on line 6, so you don't need to import a third-party class
Suggested change
| from platform import node |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.