Kayla - Linked Lists #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jun 6, 2022
There was a problem hiding this comment.
🌸 Most of your implementation was quite solid, Kayla! However, your implementation missed updating the attributes your Node class had to accommodate a doubly linked list. Additionally, as only one time and space complexity question was filled out, I will be marking this as a yellow. Let me know what questions you have!
🟡
|
|
||
| # Defines the singly linked list | ||
| class LinkedList: | ||
| def __init__(self): | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.tail = None | ||
|
|
||
| # returns the value in the first node | ||
| # returns None if the list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first(self): |
There was a problem hiding this comment.
✨ Your implementation is solid, but time and space complexity?
|
|
||
| # Defines the singly linked list | ||
| class LinkedList: | ||
| def __init__(self): | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.tail = None |
| if self.head is None: | ||
| self.head = self.tail = Node(value) | ||
| else: | ||
| new_Node = Node(value, self.head) |
There was a problem hiding this comment.
Remember our Python style conventions!
Suggested change
| new_Node = Node(value, self.head) | |
| new_node = Node(value, self.head) | |
| # Defines a node in the singly linked list | ||
| class Node: | ||
|
|
||
| def __init__(self, value, next_node = None): | ||
| def __init__(self, value, next_Node = None): |
There was a problem hiding this comment.
With Python Pep8 style conventions, we'd like our variables to be all lowercase. You also use previous in your methods below, but no attribute previous exists.
Suggested change
| def __init__(self, value, next_Node = None): | |
| def __init__(self, value, next_node = None, previous_node = None): | |
| self.value = value | ||
| self.next = next_node | ||
| self.next = next_Node |
There was a problem hiding this comment.
Suggested change
| self.next = next_Node | |
| self.next = next_node | |
| self.previous = previous_node | |
| current = current.next | ||
| return None | ||
|
|
||
|
|
||
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns None if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last(self): |
| if self.tail is None: | ||
| return None | ||
|
|
||
| return self.tail.value | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(self, value): |
| new_Node.previous = self.tail | ||
| self.tail.next = new_Node | ||
| self.tail = new_Node | ||
|
|
||
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
| max_value = current.value | ||
| current = current.next | ||
| return max_value | ||
|
|
||
|
|
||
| # method to delete the first node found with specified value | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def delete(self, value): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.