C16 - Afina Walton #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jun 28, 2022
| // Time Complexity: ? | ||
| // Space Complexity: ? | ||
| // Time Complexity: O(n log n) | ||
| // Space Complexity: O(n) | ||
| function heapsort(list) { |
| // Time complexity: ? | ||
| // Space complexity: ? | ||
| // Time complexity: O(log n) | ||
| // Space complexity: O(1) |
There was a problem hiding this comment.
✨ However, because of the recursive call stack space complexity will be O(log n)
|
|
||
| // base case | ||
| if (index === 0 || parent.key < element.key) { | ||
| // pass |
There was a problem hiding this comment.
This works however, it's generally considered bad style to leave the body of an if statement empty
Suggested change
| // pass | |
| return |
| // Time complexity: ? | ||
| // Space complexity: ? | ||
| // Time complexity: O(1) | ||
| // Space complexity: O(1) | ||
| isEmpty() { |
| // Time Complexity: ? | ||
| // Space Complexity: ? | ||
| // Time Complexity: O(log n) | ||
| // Space Complexity: O(1) | ||
| remove() { |
There was a problem hiding this comment.
✨ However space complexity will be O(log n) here because of the recursive call stack of heap_down
| // Time Complexity: ? | ||
| // Space Complexity: ? | ||
| // Time Complexity: O(log n) | ||
| // Space Complexity: O(1) | ||
| add(key, value = key) { |
There was a problem hiding this comment.
✨ However space complexity will be O(log n) here because of the recursive call stack of heap_up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?