-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches - Xinran #35
base: master
Are you sure you want to change the base?
Conversation
…created index, show, new, create, edit and update controller methods; created views for index, show, new and edit methods
…, uncomplete methods; created css; created unit tests of nonimal cases for edit, update, destroy, complete and uncomplete methods; changed time zone in controller to display time locally
…dded edge cases for 'update', 'destroy', 'complete' and 'incomplete' methods in controller test
Task ListWhat We're Looking For
Great work on this project, Xinran! Your TaskList looks and works great! And your tests are very complete and work great too. I only have a minor comment on how to make a test more thorough! Other than that, your TaskList looks great. Keep up the great work! |
# Your tests go here | ||
it "must update the completed time to nil and redirect to index page" do | ||
patch uncomplete_task_path(task.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: It might be nice to check that Task.count
won't change here, too
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions