Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Dominique and Mariya #26

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

dtaylor73
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way Passengers and drivers have many trips and trips belongs to passenger and driver.
Describe the role of model validations in your application Model validations ensured that the the driver and name fields are present and made up of only letters.
How did your team break up the work to be done? We checked in frequently and utilized our Trello board.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized the functional features and set aside CSS styling.
What was one thing that your team collectively gained more clarity on after completing this assignment? Testing, debugging, and strong params
What is your Trello board URL? https://trello.com/b/GHeeB5Ec/rails-rideshare
What is the Heroku URL of your deployed application? Experienced issues with Heroku - no URL.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? Communicating more frequently about our needs and problem solving ways to move the project forward in a timely fashion.

@M-Burr
Copy link

M-Burr commented Oct 13, 2019

We figured out how to get Heroku to work. The link is: https://md-rideshare.herokuapp.com/

@dtaylor73
Copy link
Author

dtaylor73 commented Oct 14, 2019 via email

@M-Burr
Copy link

M-Burr commented Oct 14, 2019 via email

@dHelmgren
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing yes
Answered comprehension questions yes
Uses named routes (like _path) yes
RESTful routes utilized yes
Project Requirements
Table relationships yes
Validation rules for Models yes
Business logic is in the models yes
Tests for validations yes
Tests for relationships yes
Tests for custom model methods yes
Tests for controller actions yes
Database is seeded from the CSV files yes
Trello board is created and utilized in project management yes
Heroku instance is online yes
The app is styled to create an attractive user interface no. There is no styling!
Overall You hit the major goals for this project, but I would have liked to see some styling. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants